[jira] [Work logged] (KNOX-1835) Jupyter Enterprise Gateway Dispatch Handler

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KNOX-1835?focusedWorklogId=219491&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-219491 ]

ASF GitHub Bot logged work on KNOX-1835:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Mar/19 17:44
            Start Date: 27/Mar/19 17:44
    Worklog Time Spent: 10m 
      Work Description: risdenk commented on pull request #79: KNOX-1835 JKG KERNEL_USERNAME should be added when not present
URL: https://github.com/apache/knox/pull/79#discussion_r269687912
 
 

 ##########
 File path: gateway-service-jkg/src/main/java/org/apache/knox/gateway/jkg/JkgDispatch.java
 ##########
 @@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.knox.gateway.jkg;
+
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.knox.gateway.dispatch.DefaultDispatch;
+import org.apache.knox.gateway.filter.rewrite.impl.UrlRewriteRequestStream;
+import org.apache.knox.gateway.security.SubjectUtils;
+
+
+import javax.servlet.ServletInputStream;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletRequestWrapper;
+import javax.servlet.http.HttpServletResponse;
+import java.io.BufferedReader;
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+
+
+/**
+ * This specialized dispatch provides jeg specific features to the
+ * default dispatch.
+ */
+public class JkgDispatch extends DefaultDispatch {
+
+  @Override
+  public void doPost(URI url, HttpServletRequest request, HttpServletResponse response)
 
 Review comment:
   Need to worry about `doGet` at all? I don't know the internals of Jupyter Kernel Gateway just seems weird to only handle post.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 219491)
            Time Spent: 10m
    Remaining Estimate: 0h

> Jupyter Enterprise Gateway Dispatch Handler
> -------------------------------------------
>
>                 Key: KNOX-1835
>                 URL: https://issues.apache.org/jira/browse/KNOX-1835
>             Project: Apache Knox
>          Issue Type: New Feature
>            Reporter: Jesus Alvarez
>            Priority: Major
>         Attachments: KNOX-1835.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Jupyter Enterprise Gateway [https://jupyter-enterprise-gateway.readthedocs.io/|https://jupyter-enterprise-gateway.readthedocs.io/en/latest/]
> is built directly on Jupyter Kernel Gateway, for which there are service definitions available from [https://issues.apache.org/jira/browse/KNOX-976]
>  
> In the same manner that Apache Livy uses "proxyUser", JEG / JKG leverage a "KERNEL_USERNAME" [https://jupyter-enterprise-gateway.readthedocs.io/en/latest/getting-started-security.html].
>  
> For requests which are Authenticated via Knox, Knox could take a similar approach to that in https://jira.apache.org/jira/browse/KNOX-1098 , and ensure this is set to the Authenticated user, whether the JEG client request has provided it in the payload or not. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)