You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/02/13 02:08:07 UTC

Review Request 69969: Updated docs related to agent capabilities.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69969/
-----------------------------------------------------------

Review request for mesos and Gastón Kleiman.


Bugs: MESOS-9535
    https://issues.apache.org/jira/browse/MESOS-9535


Repository: mesos


Description
-------

Updated docs related to agent capabilities.


Diffs
-----

  docs/configuration/agent.md a4015c409d00a4c117df6c869d5ba5072bcfe58e 
  include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940 
  include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed 
  src/slave/flags.cpp 066b84f528b4c888dde399e0b5d5fe5531934de6 


Diff: https://reviews.apache.org/r/69969/diff/1/


Testing
-------


Thanks,

Greg Mann


Re: Review Request 69969: Updated docs related to agent capabilities.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69969/#review212784
-----------------------------------------------------------



PASS: Mesos patch 69969 was successfully built and tested.

Reviews applied: `['69958', '69957', '69876', '69964', '69969']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2881/mesos-review-69969

- Mesos Reviewbot Windows


On Feb. 13, 2019, 2:46 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69969/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2019, 2:46 a.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9535
>     https://issues.apache.org/jira/browse/MESOS-9535
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated docs related to agent capabilities.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md a4015c409d00a4c117df6c869d5ba5072bcfe58e 
>   include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940 
>   include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed 
>   src/slave/flags.cpp 066b84f528b4c888dde399e0b5d5fe5531934de6 
> 
> 
> Diff: https://reviews.apache.org/r/69969/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 69969: Updated docs related to agent capabilities.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69969/#review212790
-----------------------------------------------------------



Patch looks great!

Reviews applied: [69958, 69957, 69876, 69964, 69969]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 12, 2019, 6:46 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69969/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2019, 6:46 p.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9535
>     https://issues.apache.org/jira/browse/MESOS-9535
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated docs related to agent capabilities.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md a4015c409d00a4c117df6c869d5ba5072bcfe58e 
>   include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940 
>   include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed 
>   src/slave/flags.cpp 066b84f528b4c888dde399e0b5d5fe5531934de6 
> 
> 
> Diff: https://reviews.apache.org/r/69969/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 69969: Updated docs related to agent capabilities.

Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69969/#review212814
-----------------------------------------------------------


Ship it!




Ship It!

- Gastón Kleiman


On Feb. 12, 2019, 6:46 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69969/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2019, 6:46 p.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9535
>     https://issues.apache.org/jira/browse/MESOS-9535
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated docs related to agent capabilities.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md a4015c409d00a4c117df6c869d5ba5072bcfe58e 
>   include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940 
>   include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed 
>   src/slave/flags.cpp 066b84f528b4c888dde399e0b5d5fe5531934de6 
> 
> 
> Diff: https://reviews.apache.org/r/69969/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 69969: Updated docs related to agent capabilities.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69969/
-----------------------------------------------------------

(Updated Feb. 13, 2019, 2:46 a.m.)


Review request for mesos and Gastón Kleiman.


Bugs: MESOS-9535
    https://issues.apache.org/jira/browse/MESOS-9535


Repository: mesos


Description
-------

Updated docs related to agent capabilities.


Diffs (updated)
-----

  docs/configuration/agent.md a4015c409d00a4c117df6c869d5ba5072bcfe58e 
  include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940 
  include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed 
  src/slave/flags.cpp 066b84f528b4c888dde399e0b5d5fe5531934de6 


Diff: https://reviews.apache.org/r/69969/diff/2/

Changes: https://reviews.apache.org/r/69969/diff/1-2/


Testing
-------


Thanks,

Greg Mann