You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2016/02/26 07:22:06 UTC
[Impala-CR](cdh5-2.5.0_5.7.0) Comment out replica_preference query option
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2323
Change subject: Comment out replica_preference query option
......................................................................
Comment out replica_preference query option
Change-Id: I5a3134b874a53241706d850d186acbfed768f5ee
---
M be/src/scheduling/simple-scheduler-test.cc
M be/src/scheduling/simple-scheduler.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/ImpalaService.thrift
M fe/src/main/java/com/cloudera/impala/analysis/TableRef.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/com/cloudera/impala/analysis/ParserTest.java
M fe/src/test/java/com/cloudera/impala/analysis/ToSqlTest.java
9 files changed, 78 insertions(+), 72 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/23/2323/2
--
To view, visit http://gerrit.cloudera.org:8080/2323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a3134b874a53241706d850d186acbfed768f5ee
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-CR](cdh5-2.5.0_5.7.0) Remove replica_preference query option
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has uploaded a new patch set (#4).
Change subject: Remove replica_preference query option
......................................................................
Remove replica_preference query option
Change-Id: I5a3134b874a53241706d850d186acbfed768f5ee
---
M be/src/scheduling/simple-scheduler-test.cc
M be/src/scheduling/simple-scheduler.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M fe/src/main/java/com/cloudera/impala/analysis/TableRef.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/com/cloudera/impala/analysis/ParserTest.java
M fe/src/test/java/com/cloudera/impala/analysis/ToSqlTest.java
10 files changed, 32 insertions(+), 102 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/23/2323/4
--
To view, visit http://gerrit.cloudera.org:8080/2323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5a3134b874a53241706d850d186acbfed768f5ee
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
[Impala-CR](cdh5-2.5.0_5.7.0) Remove replica_preference query option
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: Remove replica_preference query option
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/2323/3/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:
Line 136: 34: optional bool random_replica = 0
> schedule_random_replica
Done
http://gerrit.cloudera.org:8080/#/c/2323/3/common/thrift/ImpalaService.thrift
File common/thrift/ImpalaService.thrift:
Line 176: RANDOM_REPLICA,
> let's rename to schedule_random_replica
Done
http://gerrit.cloudera.org:8080/#/c/2323/3/fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java
File fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java:
Line 1614: String.format("select * from functional.alltypes %s %srandom_replica%s",
> yes, let's call this schedule_random_replica
Done
--
To view, visit http://gerrit.cloudera.org:8080/2323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a3134b874a53241706d850d186acbfed768f5ee
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-2.5.0_5.7.0) Remove replica_preference query option
Posted by "Silvius Rus (Code Review)" <ge...@cloudera.org>.
Silvius Rus has posted comments on this change.
Change subject: Remove replica_preference query option
......................................................................
Patch Set 4: Code-Review+2
Approved by gatekeeper.
--
To view, visit http://gerrit.cloudera.org:8080/2323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a3134b874a53241706d850d186acbfed768f5ee
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Silvius Rus <sr...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-2.5.0_5.7.0) Remove replica_preference query option
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: Remove replica_preference query option
......................................................................
Remove replica_preference query option
Change-Id: I5a3134b874a53241706d850d186acbfed768f5ee
Reviewed-on: http://gerrit.cloudera.org:8080/2323
Reviewed-by: Marcel Kornacker <ma...@cloudera.com>
Reviewed-by: Silvius Rus <sr...@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/scheduling/simple-scheduler-test.cc
M be/src/scheduling/simple-scheduler.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M fe/src/main/java/com/cloudera/impala/analysis/TableRef.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/com/cloudera/impala/analysis/ParserTest.java
M fe/src/test/java/com/cloudera/impala/analysis/ToSqlTest.java
10 files changed, 32 insertions(+), 102 deletions(-)
Approvals:
Marcel Kornacker: Looks good to me, but someone else must approve
Internal Jenkins: Verified
Silvius Rus: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/2323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a3134b874a53241706d850d186acbfed768f5ee
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Silvius Rus <sr...@cloudera.com>
[Impala-CR](cdh5-2.5.0_5.7.0) Comment out replica_preference query option
Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.
Change subject: Comment out replica_preference query option
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/2323/3/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:
Line 136: 34: optional bool random_replica = 0
schedule_random_replica
http://gerrit.cloudera.org:8080/#/c/2323/3/common/thrift/ImpalaService.thrift
File common/thrift/ImpalaService.thrift:
Line 176: RANDOM_REPLICA,
let's rename to schedule_random_replica
http://gerrit.cloudera.org:8080/#/c/2323/3/fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java
File fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java:
Line 1614: String.format("select * from functional.alltypes %s %srandom_replica%s",
yes, let's call this schedule_random_replica
--
To view, visit http://gerrit.cloudera.org:8080/2323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a3134b874a53241706d850d186acbfed768f5ee
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-2.5.0_5.7.0) Comment out replica_preference query option
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: Comment out replica_preference query option
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/2323/2/fe/src/main/java/com/cloudera/impala/analysis/TableRef.java
File fe/src/main/java/com/cloudera/impala/analysis/TableRef.java:
Line 397: if (hint.equalsIgnoreCase("RANDOM_REPLICA")) {
Marcel, let me know if you'd like me to rename the hint to SCHEDULE_RANDOM_REPLICA in anticipation of future changes.
--
To view, visit http://gerrit.cloudera.org:8080/2323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a3134b874a53241706d850d186acbfed768f5ee
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-2.5.0_5.7.0) Comment out replica_preference query option
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has uploaded a new patch set (#3).
Change subject: Comment out replica_preference query option
......................................................................
Comment out replica_preference query option
Change-Id: I5a3134b874a53241706d850d186acbfed768f5ee
---
M be/src/scheduling/simple-scheduler-test.cc
M be/src/scheduling/simple-scheduler.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M fe/src/main/java/com/cloudera/impala/analysis/TableRef.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/com/cloudera/impala/analysis/ParserTest.java
M fe/src/test/java/com/cloudera/impala/analysis/ToSqlTest.java
10 files changed, 10 insertions(+), 82 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/23/2323/3
--
To view, visit http://gerrit.cloudera.org:8080/2323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5a3134b874a53241706d850d186acbfed768f5ee
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
[Impala-CR](cdh5-2.5.0_5.7.0) Remove replica_preference query option
Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.
Change subject: Remove replica_preference query option
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/2323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a3134b874a53241706d850d186acbfed768f5ee
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No