Re: [PR] fix(postprocessing): preserve NULL grouping index values in pivot() [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #43694:
URL: https://github.com/apache/superset/pull/43694#issuecomment-5545991620

   @Archita-kale nice catch on the root cause, but `_fill_dimension_column` in pivot.py:17-21 adds the `<NULL>` category to every categorical dimension even when there's no null present. Per @sadpandajoe's comment, this creates a fake zero-value group in pivots that never had one. Should be gated on `s.isna().any()` like the datetime branch. 
   
   Also still open: the datetime path stringifies the whole column instead of just the missing values, which per copilot's thread breaks the epoch serializer downstream in charts/data/api.py, and timedelta64 columns aren't caught by that check so they'll still hit fillna() and raise. Those threads are still unresolved, want to take another pass before this is mergeable?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org