You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "zabetak (via GitHub)" <gi...@apache.org> on 2025/10/22 14:53:49 UTC
[PR] [CALCITE-7240] Handle SEARCH in DateRangeRules [calcite]
zabetak opened a new pull request, #4593:
URL: https://github.com/apache/calcite/pull/4593
1. Expand SEARCH in replaceTimeUnits since ExtractShuttle is made to work only with simple operators
2. Correct invalid return datatype in DateRangeRulesTest.Fixture2 function calls by relying on the operator type derivation logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7240] Handle SEARCH in DateRangeRules [calcite]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #4593:
URL: https://github.com/apache/calcite/pull/4593#issuecomment-3441517077
Hey @mihaibudiu , I don't understand what you are suggesting, can you elaborate a bit more. The tests that I added create SEARCH expressions so what extra tests would you like to see?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7240] Handle SEARCH in DateRangeRules [calcite]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak merged PR #4593:
URL: https://github.com/apache/calcite/pull/4593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7240] Handle SEARCH in DateRangeRules [calcite]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #4593:
URL: https://github.com/apache/calcite/pull/4593#issuecomment-3435646883
@mihaibudiu The `RexBuilder#makeBetween` method will create a SEARCH expression; if you remove the expansion that I added all the new tests will fail. I didn't explicitly create a SEARCH expression to showcase that the problem can appears by using built-in APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7240] Handle SEARCH in DateRangeRules [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4593:
URL: https://github.com/apache/calcite/pull/4593#issuecomment-3432972178
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4593) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4593&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4593&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4593&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7240] Handle SEARCH in DateRangeRules [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #4593:
URL: https://github.com/apache/calcite/pull/4593#issuecomment-3438965993
Yes, I understand that, but it would be nice to prove that the problem you set to solve is indeed solved with at least one test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7240] Handle SEARCH in DateRangeRules [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #4593:
URL: https://github.com/apache/calcite/pull/4593#issuecomment-3444102749
The words SEARCH or Sarg do not appear in any of the changes you made.
Maybe you want to change the JIRA title instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7240] Handle SEARCH in DateRangeRules [calcite]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #4593:
URL: https://github.com/apache/calcite/pull/4593#issuecomment-3451098749
I added a call to `RexUtil.expandSearch` inside `DateRangeRules` so "search" appears in the diff/changes. I can't think of a JIRA title that would describe the changes better. Since the discussion here is not about the code itself I will move forward and merge this PR since it is approved. We can revise the JIRA title later if someone has a better idea to describe the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org