You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2023/09/29 12:10:33 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request, #8022: New feature: VNF templates and appliances integration
weizhouapache opened a new pull request, #8022:
URL: https://github.com/apache/cloudstack/pull/8022
### Description
This feature introduce a new type of template in CloudStack: "VNF"
It supports the life cycle of VNF templates:
- register
- update
- list
- delete
It also supports the management of VNF templates and deployment of VNF appliances (from VNF templates) on GUI
Design:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/VNF+Appliance+Integration
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1747664544
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1750409667
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1772451917
<b>[SF] Trillian test result (tid-8024)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 50828 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8024-vmware-67u3.zip
Smoke tests completed. 113 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_trigger_shutdown | `Failure` | 341.67 | test_safe_shutdown.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #8022: New feature: VNF templates and appliances integration
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1740789173
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1757080910
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1780868606
Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 7522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1782795345
<b>[SF] Trillian test result (tid-8114)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 74831 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8114-vmware-67u3.zip
Smoke tests completed. 111 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_balanced_drs_algorithm | `Failure` | 128.97 | test_cluster_drs.py
test_list_system_vms_metrics_history | `Failure` | 0.26 | test_metrics_api.py
test_list_vms_metrics_admin | `Error` | 3607.36 | test_metrics_api.py
test_list_vms_metrics_history | `Error` | 4.67 | test_metrics_api.py
test_list_volumes_metrics_history | `Error` | 3605.47 | test_metrics_api.py
test_01_deploy_vm_on_specific_host | `Error` | 18.72 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 3603.75 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 4.38 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 4.39 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 4.37 | test_vm_deployment_planner.py
test_09_expunge_vm | `Failure` | 424.59 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1760390387
@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1762687737
<b>[LL]Trillian test result (tid-6838)</b>
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 39595 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t6838-kvm-rocky8.zip
Smoke tests completed. 113 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_vm_wrong_checksum | `Error` | 40.65 | test_templates.py
test_09_list_templates_download_details | `Failure` | 0.04 | test_templates.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1757620016
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1773819816
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1780855089
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #8022: New feature: VNF templates and appliances integration
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1740876623
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1742616142
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1742783119
@weizhouapache a [LL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1748480476
<b>[SF] Trillian test result (tid-7850)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42051 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t7850-xenserver-71.zip
Smoke tests completed. 114 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1747665065
@weizhouapache a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1344268840
##########
api/src/main/java/org/apache/cloudstack/api/command/user/template/UpdateVnfTemplateCmd.java:
##########
@@ -0,0 +1,77 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.template;
+
+import com.cloud.network.VNF;
+
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.command.user.UserCmd;
+import org.apache.cloudstack.api.response.TemplateResponse;
+import org.apache.cloudstack.storage.template.VnfTemplateUtils;
+
+import java.util.List;
+import java.util.Map;
+
+@APICommand(name = "updateVnfTemplate", description = "Updates a template to VNF template or attributes of a VNF template.",
+ responseObject = TemplateResponse.class, responseView = ResponseView.Restricted,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+ authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User})
+public class UpdateVnfTemplateCmd extends UpdateTemplateCmd implements UserCmd {
+
+ /////////////////////////////////////////////////////
+ //////////////// API parameters /////////////////////
+ /////////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.VNF_NICS,
+ type = CommandType.MAP,
+ description = "VNF nics in key/value pairs using format details[i].keyname=keyvalue. "
Review Comment:
```suggestion
description = "VNF nics in key/value pairs using format vnfnics[i].keyname=keyvalue. "
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/template/UpdateVnfTemplateCmdByAdmin.java:
##########
@@ -0,0 +1,30 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.template;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.command.admin.AdminCmd;
+import org.apache.cloudstack.api.command.user.template.UpdateVnfTemplateCmd;
+import org.apache.cloudstack.api.response.TemplateResponse;
+
+@APICommand(name = "updateVnfTemplate",
+ description = "Updates a template to VNF template or attributes of a VNF template.",
+ responseObject = TemplateResponse.class, responseView = ResponseView.Full,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
Review Comment:
```suggestion
@APICommand(name = "updateVnfTemplate",
description = "Updates a template to VNF template or attributes of a VNF template.",
responseObject = TemplateResponse.class, responseView = ResponseView.Full,
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
since="4.19.0")
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVnfApplianceCmd.java:
##########
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.vm;
+
+import com.cloud.vm.VirtualMachine;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.command.user.UserCmd;
+import org.apache.cloudstack.api.response.UserVmResponse;
+
+@APICommand(name = "deployVnfAppliance",
+ description = "Creates and automatically starts a VNF appliance based on a service offering, disk offering, and template.",
+ responseObject = UserVmResponse.class,
+ responseView = ResponseObject.ResponseView.Restricted,
+ entityType = {VirtualMachine.class},
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = true,
+ authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User})
Review Comment:
```suggestion
@APICommand(name = "deployVnfAppliance",
description = "Creates and automatically starts a VNF appliance based on a service offering, disk offering, and template.",
responseObject = UserVmResponse.class,
responseView = ResponseObject.ResponseView.Restricted,
entityType = {VirtualMachine.class},
requestHasSensitiveInfo = false, responseHasSensitiveInfo = true,
authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User},
since="4.19.0")
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/template/ListVnfTemplatesCmdByAdmin.java:
##########
@@ -0,0 +1,31 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.template;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.command.admin.AdminCmd;
+import org.apache.cloudstack.api.command.user.template.ListVnfTemplatesCmd;
+import org.apache.cloudstack.api.response.TemplateResponse;
+
+import com.cloud.template.VirtualMachineTemplate;
+
+@APICommand(name = "listVnfTemplates", description = "List all public, private, and privileged VNF templates.",
+ responseObject = TemplateResponse.class, entityType = {VirtualMachineTemplate.class}, responseView = ResponseView.Full,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
Review Comment:
```suggestion
@APICommand(name = "listVnfTemplates", description = "List all public, private, and privileged VNF templates.",
responseObject = TemplateResponse.class, entityType = {VirtualMachineTemplate.class}, responseView = ResponseView.Full,
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
since="4.19.0")
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/template/RegisterVnfTemplateCmdByAdmin.java:
##########
@@ -0,0 +1,30 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.template;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.command.admin.AdminCmd;
+import org.apache.cloudstack.api.command.user.template.RegisterVnfTemplateCmd;
+import org.apache.cloudstack.api.response.TemplateResponse;
+
+@APICommand(name = "registerVnfTemplate",
+ description = "Registers an existing VNF template into the CloudStack cloud. ",
+ responseObject = TemplateResponse.class, responseView = ResponseView.Full,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
Review Comment:
```suggestion
@APICommand(name = "registerVnfTemplate",
description = "Registers an existing VNF template into the CloudStack cloud. ",
responseObject = TemplateResponse.class, responseView = ResponseView.Full,
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
since="4.19.0")
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/template/UpdateVnfTemplateCmd.java:
##########
@@ -0,0 +1,77 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.template;
+
+import com.cloud.network.VNF;
+
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.command.user.UserCmd;
+import org.apache.cloudstack.api.response.TemplateResponse;
+import org.apache.cloudstack.storage.template.VnfTemplateUtils;
+
+import java.util.List;
+import java.util.Map;
+
+@APICommand(name = "updateVnfTemplate", description = "Updates a template to VNF template or attributes of a VNF template.",
+ responseObject = TemplateResponse.class, responseView = ResponseView.Restricted,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+ authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User})
+public class UpdateVnfTemplateCmd extends UpdateTemplateCmd implements UserCmd {
+
+ /////////////////////////////////////////////////////
+ //////////////// API parameters /////////////////////
+ /////////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.VNF_NICS,
+ type = CommandType.MAP,
+ description = "VNF nics in key/value pairs using format details[i].keyname=keyvalue. "
+ + " Example: vnfnics[0].deviceid=0&&vnfnics[0].name=FirstNIC&&vnfnics[0].required=true"
+ + "&&vnfnics[1].deviceid=1&&vnfnics[1].name=SecondNIC")
+ protected Map vnfNics;
+
+ @Parameter(name = ApiConstants.VNF_DETAILS,
+ type = CommandType.MAP,
+ description = "VNF details in key/value pairs using format details[i].keyname=keyvalue. "
+ + "Example: vnfdetails[0].vendor=xxx&&details[0].version=2.0")
Review Comment:
```suggestion
description = "VNF details in key/value pairs using format vnfdetails[i].keyname=keyvalue. "
+ "Example: vnfdetails[0].vendor=xxx&&vnfdetails[0].version=2.0")
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/template/DeleteVnfTemplateCmd.java:
##########
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.template;
+
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.response.SuccessResponse;
+
+import com.cloud.template.VirtualMachineTemplate;
+import com.cloud.user.Account;
+
+@APICommand(name = "deleteVnfTemplate",
+ responseObject = SuccessResponse.class,
+ description = "Deletes a VNF template from the system. All virtual machines using the deleted template will not be affected.",
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+ authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User})
Review Comment:
```suggestion
@APICommand(name = "deleteVnfTemplate",
responseObject = SuccessResponse.class,
description = "Deletes a VNF template from the system. All virtual machines using the deleted template will not be affected.",
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User},
since="4.19.0")
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/template/RegisterVnfTemplateCmd.java:
##########
@@ -0,0 +1,78 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.template;
+
+import java.util.List;
+import java.util.Map;
+
+import com.cloud.network.VNF;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.command.user.UserCmd;
+import org.apache.cloudstack.api.response.TemplateResponse;
+import org.apache.cloudstack.storage.template.VnfTemplateUtils;
+
+@APICommand(name = "registerVnfTemplate",
+ description = "Registers an existing VNF template into the CloudStack cloud. ",
+ responseObject = TemplateResponse.class, responseView = ResponseView.Restricted,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+ authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User})
+public class RegisterVnfTemplateCmd extends RegisterTemplateCmd implements UserCmd {
+
+ /////////////////////////////////////////////////////
+ //////////////// API parameters /////////////////////
+ /////////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.VNF_NICS,
+ type = CommandType.MAP,
+ description = "VNF nics in key/value pairs using format details[i].keyname=keyvalue. "
Review Comment:
```suggestion
description = "VNF nics in key/value pairs using format vnfnics[i].keyname=keyvalue. "
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/template/ListVnfTemplatesCmd.java:
##########
@@ -0,0 +1,32 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.template;
+
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.command.user.UserCmd;
+import org.apache.cloudstack.api.response.TemplateResponse;
+
+import com.cloud.template.VirtualMachineTemplate;
+
+@APICommand(name = "listVnfTemplates", description = "List all public, private, and privileged VNF templates.",
+ responseObject = TemplateResponse.class, entityType = {VirtualMachineTemplate.class}, responseView = ResponseView.Restricted,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+ authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User})
Review Comment:
```suggestion
@APICommand(name = "listVnfTemplates", description = "List all public, private, and privileged VNF templates.",
responseObject = TemplateResponse.class, entityType = {VirtualMachineTemplate.class}, responseView = ResponseView.Restricted,
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User},
since="4.19.0")
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/template/RegisterVnfTemplateCmd.java:
##########
@@ -0,0 +1,78 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.template;
+
+import java.util.List;
+import java.util.Map;
+
+import com.cloud.network.VNF;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.command.user.UserCmd;
+import org.apache.cloudstack.api.response.TemplateResponse;
+import org.apache.cloudstack.storage.template.VnfTemplateUtils;
+
+@APICommand(name = "registerVnfTemplate",
+ description = "Registers an existing VNF template into the CloudStack cloud. ",
+ responseObject = TemplateResponse.class, responseView = ResponseView.Restricted,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+ authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User})
+public class RegisterVnfTemplateCmd extends RegisterTemplateCmd implements UserCmd {
+
+ /////////////////////////////////////////////////////
+ //////////////// API parameters /////////////////////
+ /////////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.VNF_NICS,
+ type = CommandType.MAP,
+ description = "VNF nics in key/value pairs using format details[i].keyname=keyvalue. "
+ + " Example: vnfnics[0].deviceid=0&&vnfnics[0].name=FirstNIC&&vnfnics[0].required=true"
+ + "&&vnfnics[1].deviceid=1&&vnfnics[1].name=SecondNIC")
+ protected Map vnfNics;
+
+ @Parameter(name = ApiConstants.VNF_DETAILS,
+ type = CommandType.MAP,
+ description = "VNF details in key/value pairs using format details[i].keyname=keyvalue. "
+ + "Example: vnfdetails[0].vendor=xxx&&details[0].version=2.0")
Review Comment:
```suggestion
description = "VNF details in key/value pairs using format vnfdetails[i].keyname=keyvalue. "
+ "Example: vnfdetails[0].vendor=xxx&&vnfdetails[0].version=2.0")
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/template/UpdateTemplateCmd.java:
##########
@@ -41,7 +42,8 @@ public class UpdateTemplateCmd extends BaseUpdateTemplateOrIsoCmd implements Use
//////////////// API parameters /////////////////////
/////////////////////////////////////////////////////
- @Parameter(name = "templatetype", type = CommandType.STRING, description = "the type of the template")
+ @Parameter(name = ApiConstants.TEMPLATE_TYPE, type = CommandType.STRING,
+ description = "the type of the template. Valid options are: USER/VNF (for all users) and SYSTEM/ROUTING/BUILTIN (for admins only).")
Review Comment:
```suggestion
@Parameter(name = ApiConstants.TEMPLATE_TYPE, type = CommandType.STRING,
description = "the type of the template. Valid options are: USER/VNF (for all users) and SYSTEM/ROUTING/BUILTIN (for admins only).",
since="4.19.0")
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/template/UpdateVnfTemplateCmd.java:
##########
@@ -0,0 +1,77 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.template;
+
+import com.cloud.network.VNF;
+
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.command.user.UserCmd;
+import org.apache.cloudstack.api.response.TemplateResponse;
+import org.apache.cloudstack.storage.template.VnfTemplateUtils;
+
+import java.util.List;
+import java.util.Map;
+
+@APICommand(name = "updateVnfTemplate", description = "Updates a template to VNF template or attributes of a VNF template.",
+ responseObject = TemplateResponse.class, responseView = ResponseView.Restricted,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+ authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User})
Review Comment:
```suggestion
@APICommand(name = "updateVnfTemplate", description = "Updates a template to VNF template or attributes of a VNF template.",
responseObject = TemplateResponse.class, responseView = ResponseView.Restricted,
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User},
since="4.19.0")
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/template/RegisterVnfTemplateCmd.java:
##########
@@ -0,0 +1,78 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.template;
+
+import java.util.List;
+import java.util.Map;
+
+import com.cloud.network.VNF;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.command.user.UserCmd;
+import org.apache.cloudstack.api.response.TemplateResponse;
+import org.apache.cloudstack.storage.template.VnfTemplateUtils;
+
+@APICommand(name = "registerVnfTemplate",
+ description = "Registers an existing VNF template into the CloudStack cloud. ",
+ responseObject = TemplateResponse.class, responseView = ResponseView.Restricted,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+ authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User})
Review Comment:
```suggestion
@APICommand(name = "registerVnfTemplate",
description = "Registers an existing VNF template into the CloudStack cloud. ",
responseObject = TemplateResponse.class, responseView = ResponseView.Restricted,
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User},
since="4.19.0")
```
##########
test/integration/smoke/test_vnf_templates.py:
##########
@@ -0,0 +1,338 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Smoke tests for VNF templates/appliances
+"""
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.base import (Account,
+ Domain,
+ Configurations,
+ ServiceOffering,
+ VirtualMachine,
+ Network,
+ NetworkOffering,
+ VnfTemplate,
+ Zone)
+from marvin.lib.common import get_zone, get_template
+from nose.plugins.attrib import attr
+
+import time
+
+VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"}]
+NEW_VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"},
+ {"deviceid": "2", "name": "LAN-2", "required": "false", "description": "Private LAN-2"}]
+VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root"}]
+NEW_VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root", "password": "cloudstack"}]
+
+class TestVnfTemplates(cloudstackTestCase):
+
+ @classmethod
+ def setUpClass(cls):
+
+ testClient = super(TestVnfTemplates, cls).getClsTestClient()
+ cls.apiclient = testClient.getApiClient()
+ cls._cleanup = []
+ cls.services = testClient.getParsedTestDataConfig()
+
+ # Get Zone, Domain and templates
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+ zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
+ cls.zone = Zone(zone.__dict__)
+ cls.template = get_template(cls.apiclient, cls.zone.id)
+
+ cls.domain = Domain.create(
+ cls.apiclient,
+ cls.services["domain"]
+ )
+ cls.account = Account.create(
+ cls.apiclient,
+ cls.services["account"],
+ admin=True,
+ domainid=cls.domain.id
+ )
+ cls.user = cls.account.user[0]
+ cls.user_apiclient = cls.testClient.getUserApiClient(
+ cls.user.username, cls.domain.name
+ )
+
+ cls.service_offering = ServiceOffering.create(
+ cls.apiclient,
+ cls.services["service_offerings"]["big"]
+ )
+
+ cls._cleanup = [
+ cls.service_offering,
+ cls.domain,
+ cls.account
+ ]
+
+ cls.vnf_template_config = {
+ "name": "pfsense",
+ "displaytext": "pfsense",
+ "format": "QCOW2",
+ "url": cls.template.url,
+ "requireshvm": "True",
+ "ispublic": "True",
+ "isextractable": "True",
+ "hypervisor": cls.hypervisor,
+ "zoneid": cls.zone.id,
+ "ostype": "FreeBSD 12 (64-bit)",
+ "directdownload": False
+ }
+
+ cls.initial_setting = Configurations.list(
+ cls.apiclient,
+ name="vnf.template.appliance.enabled")[0].value
+
+ Configurations.update(cls.apiclient, "vnf.template.appliance.enabled", "true")
+
+ cls.vnf_templates = []
+
+ @classmethod
+ def tearDownClass(cls):
+ Configurations.update(cls.apiclient, "vnf.template.appliance.enabled", cls.initial_setting)
+ super(TestVnfTemplates, cls).tearDownClass()
+
+ def setUp(self):
+ self.apiclient = self.testClient.getApiClient()
+ self.dbclient = self.testClient.getDbConnection()
+ self.cleanup = []
+
+ def tearDown(self):
+ super(TestVnfTemplates, self).tearDown()
+
+ @attr(tags=["advanced"], required_hardware="false")
+ def test_01_register_vnf_template(self):
+ """Test register VNF template
+ """
+ self.vnf_template = VnfTemplate.register(self.user_apiclient,
+ self.vnf_template_config,
+ zoneid=self.zone.id,
+ hypervisor=self.hypervisor,
+ vnfnics=VNF_NICS,
+ vnfdetails=VNF_DETAILS)
Review Comment:
I think these (tests 1 and 5) should be part of setup and teardown. In this way the order of the tests matters, which can lead to issues of intermittend failures. Tests, even integration tests should be atomic.
##########
ui/src/views/image/RegisterOrUploadTemplate.vue:
##########
@@ -1,3 +1,4 @@
+
Review Comment:
```suggestion
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/vm/DeployVnfApplianceCmdByAdmin.java:
##########
@@ -0,0 +1,33 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.vm;
+
+import com.cloud.vm.VirtualMachine;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.command.admin.AdminCmd;
+import org.apache.cloudstack.api.command.user.vm.DeployVnfApplianceCmd;
+import org.apache.cloudstack.api.response.UserVmResponse;
+
+@APICommand(name = "deployVnfAppliance",
+ description = "Creates and automatically starts a VNF appliance based on a service offering, disk offering, and template.",
+ responseObject = UserVmResponse.class,
+ responseView = ResponseObject.ResponseView.Full,
+ entityType = {VirtualMachine.class},
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = true)
Review Comment:
```suggestion
@APICommand(name = "deployVnfAppliance",
description = "Creates and automatically starts a VNF appliance based on a service offering, disk offering, and template.",
responseObject = UserVmResponse.class,
responseView = ResponseObject.ResponseView.Full,
entityType = {VirtualMachine.class},
requestHasSensitiveInfo = false, responseHasSensitiveInfo = true,
since="4.19.0")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1744299528
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1745128367
@weizhouapache a [LL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #8022: New feature: VNF templates and appliances integration
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1342294948
##########
test/integration/smoke/test_vnf_templates.py:
##########
@@ -0,0 +1,338 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Smoke tests for VNF templates/appliances
+"""
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.base import (Account,
+ Domain,
+ Configurations,
+ ServiceOffering,
+ VirtualMachine,
+ Network,
+ NetworkOffering,
+ VnfTemplate,
+ Zone)
+from marvin.lib.common import get_zone, get_template
+from nose.plugins.attrib import attr
+
+import time
+
+VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"}]
+NEW_VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"},
+ {"deviceid": "2", "name": "LAN-2", "required": "false", "description": "Private LAN-2"}]
+VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root"}]
+NEW_VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root", "password": "cloudstack"}]
+
+class TestVnfTemplates(cloudstackTestCase):
+
+ @classmethod
+ def setUpClass(cls):
+
+ testClient = super(TestVnfTemplates, cls).getClsTestClient()
+ cls.apiclient = testClient.getApiClient()
+ cls._cleanup = []
+ cls.services = testClient.getParsedTestDataConfig()
+
+ # Get Zone, Domain and templates
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+ zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
+ cls.zone = Zone(zone.__dict__)
+ cls.template = get_template(cls.apiclient, cls.zone.id)
+
+ cls.domain = Domain.create(
+ cls.apiclient,
+ cls.services["domain"]
+ )
Review Comment:
```suggestion
cls.domain = Domain.create(
cls.apiclient,
cls.services["domain"]
)
cls._cleanup.append(cls.domain)
```
##########
test/integration/smoke/test_vnf_templates.py:
##########
@@ -0,0 +1,338 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Smoke tests for VNF templates/appliances
+"""
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.base import (Account,
+ Domain,
+ Configurations,
+ ServiceOffering,
+ VirtualMachine,
+ Network,
+ NetworkOffering,
+ VnfTemplate,
+ Zone)
+from marvin.lib.common import get_zone, get_template
+from nose.plugins.attrib import attr
+
+import time
+
+VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"}]
+NEW_VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"},
+ {"deviceid": "2", "name": "LAN-2", "required": "false", "description": "Private LAN-2"}]
+VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root"}]
+NEW_VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root", "password": "cloudstack"}]
+
+class TestVnfTemplates(cloudstackTestCase):
+
+ @classmethod
+ def setUpClass(cls):
+
+ testClient = super(TestVnfTemplates, cls).getClsTestClient()
+ cls.apiclient = testClient.getApiClient()
+ cls._cleanup = []
+ cls.services = testClient.getParsedTestDataConfig()
+
+ # Get Zone, Domain and templates
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+ zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
+ cls.zone = Zone(zone.__dict__)
+ cls.template = get_template(cls.apiclient, cls.zone.id)
+
+ cls.domain = Domain.create(
+ cls.apiclient,
+ cls.services["domain"]
+ )
+ cls.account = Account.create(
+ cls.apiclient,
+ cls.services["account"],
+ admin=True,
+ domainid=cls.domain.id
+ )
+ cls.user = cls.account.user[0]
+ cls.user_apiclient = cls.testClient.getUserApiClient(
+ cls.user.username, cls.domain.name
+ )
+
+ cls.service_offering = ServiceOffering.create(
+ cls.apiclient,
+ cls.services["service_offerings"]["big"]
+ )
+
+ cls._cleanup = [
+ cls.service_offering,
+ cls.domain,
+ cls.account
+ ]
Review Comment:
```suggestion
```
##########
test/integration/smoke/test_vnf_templates.py:
##########
@@ -0,0 +1,338 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Smoke tests for VNF templates/appliances
+"""
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.base import (Account,
+ Domain,
+ Configurations,
+ ServiceOffering,
+ VirtualMachine,
+ Network,
+ NetworkOffering,
+ VnfTemplate,
+ Zone)
+from marvin.lib.common import get_zone, get_template
+from nose.plugins.attrib import attr
+
+import time
+
+VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"}]
+NEW_VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"},
+ {"deviceid": "2", "name": "LAN-2", "required": "false", "description": "Private LAN-2"}]
+VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root"}]
+NEW_VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root", "password": "cloudstack"}]
+
+class TestVnfTemplates(cloudstackTestCase):
+
+ @classmethod
+ def setUpClass(cls):
+
+ testClient = super(TestVnfTemplates, cls).getClsTestClient()
+ cls.apiclient = testClient.getApiClient()
+ cls._cleanup = []
+ cls.services = testClient.getParsedTestDataConfig()
+
+ # Get Zone, Domain and templates
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+ zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
+ cls.zone = Zone(zone.__dict__)
+ cls.template = get_template(cls.apiclient, cls.zone.id)
+
+ cls.domain = Domain.create(
+ cls.apiclient,
+ cls.services["domain"]
+ )
+ cls.account = Account.create(
+ cls.apiclient,
+ cls.services["account"],
+ admin=True,
+ domainid=cls.domain.id
+ )
Review Comment:
```suggestion
cls.account = Account.create(
cls.apiclient,
cls.services["account"],
admin=True,
domainid=cls.domain.id
)
cls._cleanup.append(cls.account)
```
##########
server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java:
##########
@@ -418,6 +430,18 @@ public UserVmResponse newUserVmResponse(ResponseView view, String objectName, Us
addVmRxTxDataToResponse(userVm, userVmResponse);
+ if (TemplateType.VNF.equals(userVm.getTemplateType()) && (details.contains(VMDetails.all) || details.contains(VMDetails.vnfnics))) {
+ List<VnfTemplateNicVO> vnfNics = vnfTemplateNicDao.listByTemplateId(userVm.getTemplateId());
+ for (VnfTemplateNicVO nic : vnfNics) {
+ userVmResponse.addVnfNic(new VnfNicResponse(nic.getDeviceId(), nic.getDeviceName(), nic.getRequired(), nic.getDescription()));
+ }
+ List<VnfTemplateDetailVO> vnfDetails = vnfTemplateDetailsDao.listDetails(userVm.getTemplateId());
+ Collections.sort(vnfDetails, (v1, v2) -> v1.getName().compareToIgnoreCase(v2.getName()));
+ for (VnfTemplateDetailVO detail : vnfDetails) {
+ userVmResponse.addVnfDetail(detail.getName(), detail.getValue());
+ }
+ }
Review Comment:
can we extract this?
##########
test/integration/smoke/test_vnf_templates.py:
##########
@@ -0,0 +1,338 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Smoke tests for VNF templates/appliances
+"""
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.base import (Account,
+ Domain,
+ Configurations,
+ ServiceOffering,
+ VirtualMachine,
+ Network,
+ NetworkOffering,
+ VnfTemplate,
+ Zone)
+from marvin.lib.common import get_zone, get_template
+from nose.plugins.attrib import attr
+
+import time
+
+VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"}]
+NEW_VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"},
+ {"deviceid": "2", "name": "LAN-2", "required": "false", "description": "Private LAN-2"}]
+VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root"}]
+NEW_VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root", "password": "cloudstack"}]
+
+class TestVnfTemplates(cloudstackTestCase):
+
+ @classmethod
+ def setUpClass(cls):
+
+ testClient = super(TestVnfTemplates, cls).getClsTestClient()
+ cls.apiclient = testClient.getApiClient()
+ cls._cleanup = []
+ cls.services = testClient.getParsedTestDataConfig()
+
+ # Get Zone, Domain and templates
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+ zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
+ cls.zone = Zone(zone.__dict__)
+ cls.template = get_template(cls.apiclient, cls.zone.id)
+
+ cls.domain = Domain.create(
+ cls.apiclient,
+ cls.services["domain"]
+ )
+ cls.account = Account.create(
+ cls.apiclient,
+ cls.services["account"],
+ admin=True,
+ domainid=cls.domain.id
+ )
+ cls.user = cls.account.user[0]
+ cls.user_apiclient = cls.testClient.getUserApiClient(
+ cls.user.username, cls.domain.name
+ )
+
+ cls.service_offering = ServiceOffering.create(
+ cls.apiclient,
+ cls.services["service_offerings"]["big"]
+ )
+
+ cls._cleanup = [
+ cls.service_offering,
+ cls.domain,
+ cls.account
+ ]
+
+ cls.vnf_template_config = {
+ "name": "pfsense",
+ "displaytext": "pfsense",
+ "format": "QCOW2",
+ "url": cls.template.url,
+ "requireshvm": "True",
+ "ispublic": "True",
+ "isextractable": "True",
+ "hypervisor": cls.hypervisor,
+ "zoneid": cls.zone.id,
+ "ostype": "FreeBSD 12 (64-bit)",
+ "directdownload": False
+ }
+
+ cls.initial_setting = Configurations.list(
+ cls.apiclient,
+ name="vnf.template.appliance.enabled")[0].value
+
+ Configurations.update(cls.apiclient, "vnf.template.appliance.enabled", "true")
+
+ cls.vnf_templates = []
+
+ @classmethod
+ def tearDownClass(cls):
+ Configurations.update(cls.apiclient, "vnf.template.appliance.enabled", cls.initial_setting)
+ super(TestVnfTemplates, cls).tearDownClass()
+
+ def setUp(self):
+ self.apiclient = self.testClient.getApiClient()
+ self.dbclient = self.testClient.getDbConnection()
+ self.cleanup = []
+
+ def tearDown(self):
+ super(TestVnfTemplates, self).tearDown()
+
+ @attr(tags=["advanced"], required_hardware="false")
+ def test_01_register_vnf_template(self):
+ """Test register VNF template
+ """
+ self.vnf_template = VnfTemplate.register(self.user_apiclient,
+ self.vnf_template_config,
+ zoneid=self.zone.id,
+ hypervisor=self.hypervisor,
+ vnfnics=VNF_NICS,
+ vnfdetails=VNF_DETAILS)
Review Comment:
should this be unregistered after the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1742606957
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1745024647
@blueorangutan LLpackage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1742534940
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1742525376
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1742532599
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1757491405
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1762116179
@weizhouapache a [LL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1768386840
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1770983723
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1759033484
@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1774559336
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1774779612
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1345564830
##########
ui/src/views/image/RegisterOrUploadTemplate.vue:
##########
@@ -1,3 +1,4 @@
+
Review Comment:
@DaanHoogland
I just checked two other tests: test_vm_life_cycle and test_kubernetes_clusters, it looks they both use the same vm or k8s cluster in all tests. I understand it will save lots of time creating new vms/clusters for each test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1757493952
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1757527049
@blueorangutan LLpackage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1742660906
@blueorangutan LLtest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1742781237
@blueorangutan LLtest rocky8 kvm-rocky8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1761007335
@blueorangutan LLpackage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1761842796
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1765987476
@blueorangutan LLpackage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1744511994
@blueorangutan LLpackage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1746957676
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1771507060
<b>[SF] Trillian test result (tid-8006)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40905 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8006-kvm-centos7.zip
Smoke tests completed. 113 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_vm_wrong_checksum | `Error` | 39.55 | test_templates.py
test_09_list_templates_download_details | `Failure` | 0.04 | test_templates.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1774683684
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1773841417
@weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1746583361
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1742616134
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1742522999
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1745124388
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "alexandremattioli (via GitHub)" <gi...@apache.org>.
alexandremattioli commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1779904365
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1780925280
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1759029775
@blueorangutan LLpackage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1759052735
@blueorangutan LLpackage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1761065648
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1770745132
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1770742706
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1772633389
@weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1773985610
<b>[SF] Trillian test result (tid-8049)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40713 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8049-kvm-centos7.zip
Smoke tests completed. 114 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1772229988
<b>[SF] Trillian test result (tid-8023)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45157 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8023-xenserver-71.zip
Smoke tests completed. 112 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_volume_usage | `Error` | 84.11 | test_usage.py
test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 308.22 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1772473769
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1774950512
@weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1773586938
<b>[SF] Trillian test result (tid-8035)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46086 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8035-xenserver-71.zip
Smoke tests completed. 113 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 307.75 | test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1179.24 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1773566994
<b>[SF] Trillian test result (tid-8037)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43557 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8037-kvm-centos7.zip
Smoke tests completed. 114 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1750436632
@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1744297260
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1746673317
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1343723344
##########
server/src/test/java/com/cloud/api/query/dao/TemplateJoinDaoImplTest.java:
##########
@@ -111,5 +127,28 @@ private void populateTemplateJoinVO() {
ReflectionTestUtils.setField(template, "domainName", domainName);
ReflectionTestUtils.setField(template, "detailName", detailName);
ReflectionTestUtils.setField(template, "detailValue", detailValue);
+ ReflectionTestUtils.setField(template, "templateType", templateType);
+ }
+
+ @Test
+ public void testNewUpdateResponseForVnf() {
+ ReflectionTestUtils.setField(template, "id", templateId);
+ ReflectionTestUtils.setField(template, "templateType", templateType);
+
+ VnfTemplateNicVO vnfNic1 = new VnfTemplateNicVO(templateId, 0L, "eth0", true, true, "first");
+ VnfTemplateNicVO vnfNic2 = new VnfTemplateNicVO(templateId, 1L, "eth1", true, true, "second");
+ Mockito.doReturn(Arrays.asList(vnfNic1, vnfNic2)).when(vnfTemplateNicDao).listByTemplateId(templateId);
+
+ VnfTemplateDetailVO detail1 = new VnfTemplateDetailVO(templateId, "name1", "value1", true);
+ VnfTemplateDetailVO detail2 = new VnfTemplateDetailVO(templateId, "name2", "value2", true);
+ VnfTemplateDetailVO detail3 = new VnfTemplateDetailVO(templateId, "name3", "value3", true);
+ Mockito.doReturn(Arrays.asList(detail1, detail2, detail3)).when(vnfTemplateDetailsDao).listDetails(templateId);
+
+ final TemplateResponse response = _templateJoinDaoImpl.newUpdateResponse(template);
+ Assert.assertTrue(response instanceof VnfTemplateResponse);
+ Assert.assertEquals(2, ((VnfTemplateResponse)response).getVnfNics().size());
+ Assert.assertEquals(3, ((VnfTemplateResponse)response).getVnfDetails().size());
+
}
}
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1776190090
<b>[SF] Trillian test result (tid-8054)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43094 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8054-xenserver-71.zip
Smoke tests completed. 114 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1776171722
<b>[SF] Trillian test result (tid-8056)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42389 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8056-kvm-centos7.zip
Smoke tests completed. 113 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_upgrade_kubernetes_cluster | `Failure` | 587.97 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1780923524
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1772559007
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1756998385
@blueorangutan LLpackage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1761008544
@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1761238986
@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1745990742
<b>[LL]Trillian test result (tid-6771)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37602 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t6771-kvm-centos7.zip
Smoke tests completed. 113 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_vmschedule_test_e2e | `Failure` | 270.78 | test_vm_schedule.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1346180268
##########
ui/src/views/image/RegisterOrUploadTemplate.vue:
##########
@@ -1,3 +1,4 @@
+
Review Comment:
I have refactored the tests.
In each test, the first step is to check if vnf template is registered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1768388595
@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1759053554
@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1759119351
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1770158850
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1770987270
@weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1773745138
<b>[SF] Trillian test result (tid-8036)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 78252 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8036-vmware-67u3.zip
Smoke tests completed. 111 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_list_vms_metrics_admin | `Error` | 3625.74 | test_metrics_api.py
test_list_vms_metrics_history | `Error` | 7.76 | test_metrics_api.py
test_list_volumes_metrics_history | `Error` | 3619.86 | test_metrics_api.py
test_01_deploy_vm_on_specific_host | `Error` | 18.73 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 3604.66 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 4.39 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 2.33 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.31 | test_vm_deployment_planner.py
test_09_expunge_vm | `Failure` | 424.70 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1770214123
<b>[SF] Trillian Build Failed (tid-8004)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1773840959
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1773818905
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1750514048
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #8022: New feature: VNF templates and appliances integration
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1341466681
##########
engine/components-api/src/main/java/com/cloud/template/TemplateManager.java:
##########
@@ -133,5 +135,9 @@ public interface TemplateManager {
public static final String MESSAGE_REGISTER_PUBLIC_TEMPLATE_EVENT = "Message.RegisterPublicTemplate.Event";
public static final String MESSAGE_RESET_TEMPLATE_PERMISSION_EVENT = "Message.ResetTemplatePermission.Event";
+ TemplateType validateTemplateType(BaseCmd cmd, boolean isAdmin, boolean isCrossZones);
+
List<DatadiskTO> getTemplateDisksOnImageStore(Long templateId, DataStoreRole role, String configurationId);
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1744599704
Packaging result [LL]: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 6192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1742668183
<b>[LL] Trillian Build Failed (tid-6758)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1748945333
<b>[SF] Trillian test result (tid-7851)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 57649 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t7851-vmware-67u3.zip
Smoke tests completed. 113 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 797.00 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1746834497
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1345816847
##########
ui/src/views/image/RegisterOrUploadTemplate.vue:
##########
@@ -1,3 +1,4 @@
+
Review Comment:
I understand but what I am saying is that if we do it should be created in setupClass, not in a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1782549905
<b>[LL] Trillian Build Failed (tid-6868)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1780482605
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #8022: New feature: VNF templates and appliances integration
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1341450487
##########
tools/marvin/marvin/lib/base.py:
##########
@@ -6700,3 +6700,121 @@ def delete(self, apiclient):
cmd.id = self.id
cmd.virtualmachineid = self.virtualmachineid
return (apiclient.deleteVMSchedule(cmd))
+
+class VnfTemplate:
+ """Manage VNF template life cycle"""
+
+ def __init__(self, items):
+ self.__dict__.update(items)
+
+ @classmethod
+ def register(cls, apiclient, services, zoneid=None,
+ account=None, domainid=None, hypervisor=None,
+ projectid=None, details=None, randomize_name=True,
+ vnfnics=None, vnfdetails=None):
+ """Create VNF template from URL"""
+
+ # Create template from Virtual machine and Volume ID
+ cmd = registerVnfTemplate.registerVnfTemplateCmd()
+ cmd.displaytext = services["displaytext"]
+ if randomize_name:
+ cmd.name = "-".join([services["name"], random_gen()])
+ else:
+ cmd.name = services["name"]
+ cmd.format = services["format"]
+ if hypervisor:
+ cmd.hypervisor = hypervisor
+ elif "hypervisor" in services:
+ cmd.hypervisor = services["hypervisor"]
+
+ if "ostypeid" in services:
+ cmd.ostypeid = services["ostypeid"]
+ elif "ostype" in services:
+ # Find OSTypeId from Os type
+ sub_cmd = listOsTypes.listOsTypesCmd()
+ sub_cmd.description = services["ostype"]
+ ostypes = apiclient.listOsTypes(sub_cmd)
+
+ if not isinstance(ostypes, list):
+ raise Exception(
+ "Unable to find Ostype id with desc: %s" %
+ services["ostype"])
+ cmd.ostypeid = ostypes[0].id
+ else:
+ raise Exception(
+ "Unable to find Ostype is required for registering template")
+
+ cmd.url = services["url"]
+
+ if zoneid:
+ cmd.zoneid = zoneid
+ else:
+ cmd.zoneid = services["zoneid"]
+
+ cmd.isfeatured = services[
+ "isfeatured"] if "isfeatured" in services else False
+ cmd.ispublic = services[
+ "ispublic"] if "ispublic" in services else False
+ cmd.isextractable = services[
+ "isextractable"] if "isextractable" in services else False
+ cmd.isdynamicallyscalable = services["isdynamicallyscalable"] if "isdynamicallyscalable" in services else False
+ cmd.passwordenabled = services[
+ "passwordenabled"] if "passwordenabled" in services else False
+ cmd.deployasis = services["deployasis"] if "deployasis" in services else False
+
+ if account:
+ cmd.account = account
+
+ if domainid:
+ cmd.domainid = domainid
+
+ if projectid:
+ cmd.projectid = projectid
+ elif "projectid" in services:
+ cmd.projectid = services["projectid"]
+
+ if details:
+ cmd.details = details
+
+ if "directdownload" in services:
+ cmd.directdownload = services["directdownload"]
+
+ if vnfnics:
+ cmd.vnfnics = vnfnics
+
+ if vnfdetails:
+ cmd.vnfdetails = vnfdetails
+
+ # Register Template
+ template = apiclient.registerVnfTemplate(cmd)
+
+ if isinstance(template, list):
+ return VnfTemplate(template[0].__dict__)
+
+ def delete(self, apiclient, zoneid=None):
+ """Delete VNF Template"""
+
+ cmd = deleteVnfTemplate.deleteVnfTemplateCmd()
+ cmd.id = self.id
+ if zoneid:
+ cmd.zoneid = zoneid
+ apiclient.deleteVnfTemplate(cmd)
+
+ def update(self, apiclient, **kwargs):
+ """Updates the template details"""
+
+ cmd = updateVnfTemplate.updateVnfTemplateCmd()
+ cmd.id = self.id
+ [setattr(cmd, k, v) for k, v in list(kwargs.items())]
+ return (apiclient.updateVnfTemplate(cmd))
+
+ @classmethod
+ def list(cls, apiclient, **kwargs):
+ """List all templates matching criteria"""
+
+ cmd = listVnfTemplates.listVnfTemplatesCmd()
+ [setattr(cmd, k, v) for k, v in list(kwargs.items())]
+ if 'account' in list(kwargs.keys()) and 'domainid' in list(kwargs.keys()):
+ cmd.listall = True
+ return (apiclient.listVnfTemplates(cmd))
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1744514083
@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1745126227
@blueorangutan LLtest matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1342360933
##########
tools/marvin/marvin/lib/base.py:
##########
@@ -6700,3 +6700,121 @@ def delete(self, apiclient):
cmd.id = self.id
cmd.virtualmachineid = self.virtualmachineid
return (apiclient.deleteVMSchedule(cmd))
+
+class VnfTemplate:
+ """Manage VNF template life cycle"""
+
+ def __init__(self, items):
+ self.__dict__.update(items)
+
+ @classmethod
+ def register(cls, apiclient, services, zoneid=None,
+ account=None, domainid=None, hypervisor=None,
+ projectid=None, details=None, randomize_name=True,
+ vnfnics=None, vnfdetails=None):
+ """Create VNF template from URL"""
+
+ # Create template from Virtual machine and Volume ID
+ cmd = registerVnfTemplate.registerVnfTemplateCmd()
+ cmd.displaytext = services["displaytext"]
+ if randomize_name:
+ cmd.name = "-".join([services["name"], random_gen()])
+ else:
+ cmd.name = services["name"]
+ cmd.format = services["format"]
+ if hypervisor:
+ cmd.hypervisor = hypervisor
+ elif "hypervisor" in services:
+ cmd.hypervisor = services["hypervisor"]
+
+ if "ostypeid" in services:
+ cmd.ostypeid = services["ostypeid"]
+ elif "ostype" in services:
+ # Find OSTypeId from Os type
+ sub_cmd = listOsTypes.listOsTypesCmd()
+ sub_cmd.description = services["ostype"]
+ ostypes = apiclient.listOsTypes(sub_cmd)
+
+ if not isinstance(ostypes, list):
+ raise Exception(
+ "Unable to find Ostype id with desc: %s" %
+ services["ostype"])
+ cmd.ostypeid = ostypes[0].id
+ else:
+ raise Exception(
+ "Unable to find Ostype is required for registering template")
+
+ cmd.url = services["url"]
+
+ if zoneid:
+ cmd.zoneid = zoneid
+ else:
+ cmd.zoneid = services["zoneid"]
+
+ cmd.isfeatured = services[
+ "isfeatured"] if "isfeatured" in services else False
+ cmd.ispublic = services[
+ "ispublic"] if "ispublic" in services else False
+ cmd.isextractable = services[
+ "isextractable"] if "isextractable" in services else False
+ cmd.isdynamicallyscalable = services["isdynamicallyscalable"] if "isdynamicallyscalable" in services else False
+ cmd.passwordenabled = services[
+ "passwordenabled"] if "passwordenabled" in services else False
+ cmd.deployasis = services["deployasis"] if "deployasis" in services else False
+
+ if account:
+ cmd.account = account
+
+ if domainid:
+ cmd.domainid = domainid
+
+ if projectid:
+ cmd.projectid = projectid
+ elif "projectid" in services:
+ cmd.projectid = services["projectid"]
+
+ if details:
+ cmd.details = details
+
+ if "directdownload" in services:
+ cmd.directdownload = services["directdownload"]
+
+ if vnfnics:
+ cmd.vnfnics = vnfnics
+
+ if vnfdetails:
+ cmd.vnfdetails = vnfdetails
+
+ # Register Template
+ template = apiclient.registerVnfTemplate(cmd)
+
+ if isinstance(template, list):
+ return VnfTemplate(template[0].__dict__)
+
+ def delete(self, apiclient, zoneid=None):
+ """Delete VNF Template"""
+
+ cmd = deleteVnfTemplate.deleteVnfTemplateCmd()
+ cmd.id = self.id
+ if zoneid:
+ cmd.zoneid = zoneid
+ apiclient.deleteVnfTemplate(cmd)
+
+ def update(self, apiclient, **kwargs):
+ """Updates the template details"""
+
+ cmd = updateVnfTemplate.updateVnfTemplateCmd()
+ cmd.id = self.id
+ [setattr(cmd, k, v) for k, v in list(kwargs.items())]
+ return (apiclient.updateVnfTemplate(cmd))
+
+ @classmethod
+ def list(cls, apiclient, **kwargs):
+ """List all templates matching criteria"""
+
+ cmd = listVnfTemplates.listVnfTemplatesCmd()
+ [setattr(cmd, k, v) for k, v in list(kwargs.items())]
+ if 'account' in list(kwargs.keys()) and 'domainid' in list(kwargs.keys()):
+ cmd.listall = True
+ return (apiclient.listVnfTemplates(cmd))
+
Review Comment:
done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1744007343
<b>[LL]Trillian test result (tid-6759)</b>
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 50769 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t6759-kvm-rocky8.zip
Smoke tests completed. 60 look OK, 21 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_deploy_vm_start_failure | `Error` | 67.39 | test_deploy_vm.py
test_deploy_vm_volume_creation_failure | `Error` | 70.98 | test_deploy_vm.py
test_vm_ha | `Error` | 63.26 | test_vm_ha.py
test_vm_sync | `Error` | 132.78 | test_vm_sync.py
test_07_project_resources_account_delete | `Error` | 5.60 | test_projects.py
test_08_cleanup_after_project_delete | `Error` | 6.80 | test_projects.py
ContextSuite context=TestProjectResources>:teardown | `Error` | 8.93 | test_projects.py
ContextSuite context=TestProjectSuspendActivate>:teardown | `Error` | 67.24 | test_projects.py
ContextSuite context=TestDeployVmWithAffinityGroup>:teardown | `Error` | 99.92 | test_affinity_groups_projects.py
test_UpdateConfigParamWithScope | `Error` | 0.56 | test_global_settings.py
test_03_deploy_vm_wrong_checksum | `Error` | 46.72 | test_templates.py
test_dedicatePublicIpRange | `Error` | 0.03 | test_public_ip_range.py
test_create_pvlan_network | `Error` | 0.04 | test_pvlan.py
test_03_user_role_dont_see_annotations | `Failure` | 2.44 | test_host_annotations.py
test_03_RVR_Network_check_router_state | `Failure` | 100.57 | test_routers_network_ops.py
test_02_deploy_vm_root_resize | `Failure` | 0.08 | test_deploy_vm_root_resize.py
test_02_vpc_privategw_static_routes | `Failure` | 140.42 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 136.53 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 207.98 | test_privategw_acl.py
test_02_unsecure_vm_migration | `Error` | 124.09 | test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 79.97 | test_vm_life_cycle.py
test_03_download_attached_volume | `Error` | 19.54 | test_volumes.py
test_04_delete_attached_volume | `Error` | 0.06 | test_volumes.py
test_05_detach_volume | `Error` | 1.05 | test_volumes.py
test_06_download_detached_volume | `Error` | 1.06 | test_volumes.py
test_07_resize_fail | `Error` | 2.17 | test_volumes.py
test_08_resize_volume | `Error` | 0.04 | test_volumes.py
test_09_delete_detached_volume | `Error` | 19.59 | test_volumes.py
test_11_attach_volume_with_unstarted_vm | `Error` | 2.24 | test_volumes.py
ContextSuite context=TestVolumes>:teardown | `Error` | 262.06 | test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 230.88 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | `Failure` | 227.74 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 142.74 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 107.50 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 202.97 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 230.89 | test_vpc_redundant.py
test_oobm_background_powerstate_sync | `Failure` | 21.55 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | `Error` | 27.40 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | `Error` | 19.59 | test_outofbandmanagement.py
test_oobm_issue_power_off | `Error` | 18.57 | test_outofbandmanagement.py
test_oobm_issue_power_on | `Error` | 19.63 | test_outofbandmanagement.py
test_oobm_issue_power_reset | `Error` | 19.56 | test_outofbandmanagement.py
test_oobm_issue_power_soft | `Error` | 19.61 | test_outofbandmanagement.py
test_oobm_issue_power_status | `Error` | 19.59 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | `Failure` | 27.66 | test_outofbandmanagement.py
test_oobm_zchange_password | `Error` | 7.27 | test_outofbandmanagement.py
test_createPortablePublicIPAcquire | `Error` | 0.02 | test_portable_publicip.py
test_createPortablePublicIPRange | `Error` | 0.02 | test_portable_publicip.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 459.17 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Error` | 1119.98 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Error` | 406.77 | test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobs | `Failure` | 172.68 | test_host_maintenance.py
test_hostha_kvm_host_degraded | `Error` | 7.60 | test_hostha_kvm.py
test_hostha_kvm_host_fencing | `Error` | 8.57 | test_hostha_kvm.py
test_hostha_kvm_host_recovering | `Error` | 6.55 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1750416567
@blueorangutan LLpackage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1748486504
<b>[SF] Trillian test result (tid-7852)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42134 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t7852-kvm-centos7.zip
Smoke tests completed. 114 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1757000873
@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1760381229
@blueorangutan LLpackage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1765755366
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1757529907
@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1782215784
<b>[SF] Trillian test result (tid-8113)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42707 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8113-xenserver-71.zip
Smoke tests completed. 115 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1770160559
@weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1772410247
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1772050554
<b>[SF] Trillian test result (tid-8005)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 76040 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8005-vmware-67u3.zip
Smoke tests completed. 109 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py
test_list_vms_metrics_admin | `Error` | 3621.05 | test_metrics_api.py
test_list_vms_metrics_history | `Error` | 7.64 | test_metrics_api.py
test_list_volumes_metrics_history | `Error` | 3624.42 | test_metrics_api.py
test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 134.91 | test_routers_network_ops.py
test_01_deploy_vm_on_specific_host | `Error` | 12.55 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 3604.34 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 4.46 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 4.37 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.30 | test_vm_deployment_planner.py
test_09_expunge_vm | `Failure` | 424.62 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1773994199
<b>[SF] Trillian test result (tid-8048)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 44494 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8048-vmware-67u3.zip
Smoke tests completed. 114 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1776395626
<b>[SF] Trillian test result (tid-8055)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 53599 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8055-vmware-67u3.zip
Smoke tests completed. 113 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_trigger_shutdown | `Failure` | 336.57 | test_safe_shutdown.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1780854278
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1781284220
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1768494106
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1772474445
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1774949644
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1773837871
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1781285677
@weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1746585534
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1746837981
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1750409096
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #8022: New feature: VNF templates and appliances integration
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1740790653
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1342360405
##########
server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java:
##########
@@ -418,6 +430,18 @@ public UserVmResponse newUserVmResponse(ResponseView view, String objectName, Us
addVmRxTxDataToResponse(userVm, userVmResponse);
+ if (TemplateType.VNF.equals(userVm.getTemplateType()) && (details.contains(VMDetails.all) || details.contains(VMDetails.vnfnics))) {
+ List<VnfTemplateNicVO> vnfNics = vnfTemplateNicDao.listByTemplateId(userVm.getTemplateId());
+ for (VnfTemplateNicVO nic : vnfNics) {
+ userVmResponse.addVnfNic(new VnfNicResponse(nic.getDeviceId(), nic.getDeviceName(), nic.getRequired(), nic.getDescription()));
+ }
+ List<VnfTemplateDetailVO> vnfDetails = vnfTemplateDetailsDao.listDetails(userVm.getTemplateId());
+ Collections.sort(vnfDetails, (v1, v2) -> v1.getName().compareToIgnoreCase(v2.getName()));
+ for (VnfTemplateDetailVO detail : vnfDetails) {
+ userVmResponse.addVnfDetail(detail.getName(), detail.getValue());
+ }
+ }
Review Comment:
done, thanks
##########
test/integration/smoke/test_vnf_templates.py:
##########
@@ -0,0 +1,338 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Smoke tests for VNF templates/appliances
+"""
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.base import (Account,
+ Domain,
+ Configurations,
+ ServiceOffering,
+ VirtualMachine,
+ Network,
+ NetworkOffering,
+ VnfTemplate,
+ Zone)
+from marvin.lib.common import get_zone, get_template
+from nose.plugins.attrib import attr
+
+import time
+
+VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"}]
+NEW_VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"},
+ {"deviceid": "2", "name": "LAN-2", "required": "false", "description": "Private LAN-2"}]
+VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root"}]
+NEW_VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root", "password": "cloudstack"}]
+
+class TestVnfTemplates(cloudstackTestCase):
+
+ @classmethod
+ def setUpClass(cls):
+
+ testClient = super(TestVnfTemplates, cls).getClsTestClient()
+ cls.apiclient = testClient.getApiClient()
+ cls._cleanup = []
+ cls.services = testClient.getParsedTestDataConfig()
+
+ # Get Zone, Domain and templates
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+ zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
+ cls.zone = Zone(zone.__dict__)
+ cls.template = get_template(cls.apiclient, cls.zone.id)
+
+ cls.domain = Domain.create(
+ cls.apiclient,
+ cls.services["domain"]
+ )
+ cls.account = Account.create(
+ cls.apiclient,
+ cls.services["account"],
+ admin=True,
+ domainid=cls.domain.id
+ )
Review Comment:
done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #8022: New feature: VNF templates and appliances integration
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1740804844
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8022?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#8022](https://app.codecov.io/gh/apache/cloudstack/pull/8022?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (97bd2f3) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/a2566048fe3c8b64dce10e85cf7f82390b5a2c85?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a256604) will **decrease** coverage by `23.66%`.
> The diff coverage is `1.02%`.
```diff
@@ Coverage Diff @@
## main #8022 +/- ##
============================================
- Coverage 28.30% 4.65% -23.66%
============================================
Files 5100 345 -4755
Lines 358547 26884 -331663
Branches 52322 4726 -47596
============================================
- Hits 101490 1251 -100239
+ Misses 243113 25498 -217615
+ Partials 13944 135 -13809
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8022/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.65% <1.02%> (-0.22%)` | :arrow_down: |
| [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8022/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [ui/src/components/view/ListView.vue](https://app.codecov.io/gh/apache/cloudstack/pull/8022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL2NvbXBvbmVudHMvdmlldy9MaXN0Vmlldy52dWU=) | `16.75% <ø> (ø)` | |
| [ui/src/views/compute/DeployVnfAppliance.vue](https://app.codecov.io/gh/apache/cloudstack/pull/8022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL3ZpZXdzL2NvbXB1dGUvRGVwbG95Vm5mQXBwbGlhbmNlLnZ1ZQ==) | `0.00% <ø> (ø)` | |
| [ui/src/views/image/UpdateTemplate.vue](https://app.codecov.io/gh/apache/cloudstack/pull/8022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL3ZpZXdzL2ltYWdlL1VwZGF0ZVRlbXBsYXRlLnZ1ZQ==) | `0.00% <ø> (ø)` | |
| [ui/src/views/AutogenView.vue](https://app.codecov.io/gh/apache/cloudstack/pull/8022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL3ZpZXdzL0F1dG9nZW5WaWV3LnZ1ZQ==) | `57.95% <66.66%> (ø)` | |
| [ui/src/views/compute/DeployVM.vue](https://app.codecov.io/gh/apache/cloudstack/pull/8022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL3ZpZXdzL2NvbXB1dGUvRGVwbG95Vk0udnVl) | `0.00% <0.00%> (ø)` | |
| [.../src/views/compute/wizard/NetworkConfiguration.vue](https://app.codecov.io/gh/apache/cloudstack/pull/8022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL3ZpZXdzL2NvbXB1dGUvd2l6YXJkL05ldHdvcmtDb25maWd1cmF0aW9uLnZ1ZQ==) | `0.00% <0.00%> (ø)` | |
| [ui/src/config/section/image.js](https://app.codecov.io/gh/apache/cloudstack/pull/8022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL2NvbmZpZy9zZWN0aW9uL2ltYWdlLmpz) | `0.00% <0.00%> (ø)` | |
| [ui/src/views/image/RegisterOrUploadTemplate.vue](https://app.codecov.io/gh/apache/cloudstack/pull/8022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL3ZpZXdzL2ltYWdlL1JlZ2lzdGVyT3JVcGxvYWRUZW1wbGF0ZS52dWU=) | `0.00% <0.00%> (ø)` | |
| [ui/src/views/compute/wizard/VnfNicsSelection.vue](https://app.codecov.io/gh/apache/cloudstack/pull/8022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL3ZpZXdzL2NvbXB1dGUvd2l6YXJkL1ZuZk5pY3NTZWxlY3Rpb24udnVl) | `0.00% <0.00%> (ø)` | |
| [ui/src/config/section/network.js](https://app.codecov.io/gh/apache/cloudstack/pull/8022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL2NvbmZpZy9zZWN0aW9uL25ldHdvcmsuanM=) | `0.00% <0.00%> (ø)` | |
| ... and [2 more](https://app.codecov.io/gh/apache/cloudstack/pull/8022?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [4756 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/8022/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1759131691
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1761236999
@blueorangutan LLpackage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1762114991
@blueorangutan LLtest rocky8 kvm-rocky8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1765988229
@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1342360702
##########
test/integration/smoke/test_vnf_templates.py:
##########
@@ -0,0 +1,338 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Smoke tests for VNF templates/appliances
+"""
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.base import (Account,
+ Domain,
+ Configurations,
+ ServiceOffering,
+ VirtualMachine,
+ Network,
+ NetworkOffering,
+ VnfTemplate,
+ Zone)
+from marvin.lib.common import get_zone, get_template
+from nose.plugins.attrib import attr
+
+import time
+
+VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"}]
+NEW_VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"},
+ {"deviceid": "2", "name": "LAN-2", "required": "false", "description": "Private LAN-2"}]
+VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root"}]
+NEW_VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root", "password": "cloudstack"}]
+
+class TestVnfTemplates(cloudstackTestCase):
+
+ @classmethod
+ def setUpClass(cls):
+
+ testClient = super(TestVnfTemplates, cls).getClsTestClient()
+ cls.apiclient = testClient.getApiClient()
+ cls._cleanup = []
+ cls.services = testClient.getParsedTestDataConfig()
+
+ # Get Zone, Domain and templates
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+ zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
+ cls.zone = Zone(zone.__dict__)
+ cls.template = get_template(cls.apiclient, cls.zone.id)
+
+ cls.domain = Domain.create(
+ cls.apiclient,
+ cls.services["domain"]
+ )
+ cls.account = Account.create(
+ cls.apiclient,
+ cls.services["account"],
+ admin=True,
+ domainid=cls.domain.id
+ )
+ cls.user = cls.account.user[0]
+ cls.user_apiclient = cls.testClient.getUserApiClient(
+ cls.user.username, cls.domain.name
+ )
+
+ cls.service_offering = ServiceOffering.create(
+ cls.apiclient,
+ cls.services["service_offerings"]["big"]
+ )
+
+ cls._cleanup = [
+ cls.service_offering,
+ cls.domain,
+ cls.account
+ ]
+
+ cls.vnf_template_config = {
+ "name": "pfsense",
+ "displaytext": "pfsense",
+ "format": "QCOW2",
+ "url": cls.template.url,
+ "requireshvm": "True",
+ "ispublic": "True",
+ "isextractable": "True",
+ "hypervisor": cls.hypervisor,
+ "zoneid": cls.zone.id,
+ "ostype": "FreeBSD 12 (64-bit)",
+ "directdownload": False
+ }
+
+ cls.initial_setting = Configurations.list(
+ cls.apiclient,
+ name="vnf.template.appliance.enabled")[0].value
+
+ Configurations.update(cls.apiclient, "vnf.template.appliance.enabled", "true")
+
+ cls.vnf_templates = []
+
+ @classmethod
+ def tearDownClass(cls):
+ Configurations.update(cls.apiclient, "vnf.template.appliance.enabled", cls.initial_setting)
+ super(TestVnfTemplates, cls).tearDownClass()
+
+ def setUp(self):
+ self.apiclient = self.testClient.getApiClient()
+ self.dbclient = self.testClient.getDbConnection()
+ self.cleanup = []
+
+ def tearDown(self):
+ super(TestVnfTemplates, self).tearDown()
+
+ @attr(tags=["advanced"], required_hardware="false")
+ def test_01_register_vnf_template(self):
+ """Test register VNF template
+ """
+ self.vnf_template = VnfTemplate.register(self.user_apiclient,
+ self.vnf_template_config,
+ zoneid=self.zone.id,
+ hypervisor=self.hypervisor,
+ vnfnics=VNF_NICS,
+ vnfdetails=VNF_DETAILS)
Review Comment:
template will be removed in `test_05_delete_vnf_template`
##########
test/integration/smoke/test_vnf_templates.py:
##########
@@ -0,0 +1,338 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Smoke tests for VNF templates/appliances
+"""
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.base import (Account,
+ Domain,
+ Configurations,
+ ServiceOffering,
+ VirtualMachine,
+ Network,
+ NetworkOffering,
+ VnfTemplate,
+ Zone)
+from marvin.lib.common import get_zone, get_template
+from nose.plugins.attrib import attr
+
+import time
+
+VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"}]
+NEW_VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"},
+ {"deviceid": "2", "name": "LAN-2", "required": "false", "description": "Private LAN-2"}]
+VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root"}]
+NEW_VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root", "password": "cloudstack"}]
+
+class TestVnfTemplates(cloudstackTestCase):
+
+ @classmethod
+ def setUpClass(cls):
+
+ testClient = super(TestVnfTemplates, cls).getClsTestClient()
+ cls.apiclient = testClient.getApiClient()
+ cls._cleanup = []
+ cls.services = testClient.getParsedTestDataConfig()
+
+ # Get Zone, Domain and templates
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+ zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
+ cls.zone = Zone(zone.__dict__)
+ cls.template = get_template(cls.apiclient, cls.zone.id)
+
+ cls.domain = Domain.create(
+ cls.apiclient,
+ cls.services["domain"]
+ )
+ cls.account = Account.create(
+ cls.apiclient,
+ cls.services["account"],
+ admin=True,
+ domainid=cls.domain.id
+ )
+ cls.user = cls.account.user[0]
+ cls.user_apiclient = cls.testClient.getUserApiClient(
+ cls.user.username, cls.domain.name
+ )
+
+ cls.service_offering = ServiceOffering.create(
+ cls.apiclient,
+ cls.services["service_offerings"]["big"]
+ )
+
+ cls._cleanup = [
+ cls.service_offering,
+ cls.domain,
+ cls.account
+ ]
Review Comment:
done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1342360199
##########
engine/components-api/src/main/java/com/cloud/template/TemplateManager.java:
##########
@@ -133,5 +135,9 @@ public interface TemplateManager {
public static final String MESSAGE_REGISTER_PUBLIC_TEMPLATE_EVENT = "Message.RegisterPublicTemplate.Event";
public static final String MESSAGE_RESET_TEMPLATE_PERMISSION_EVENT = "Message.ResetTemplatePermission.Event";
+ TemplateType validateTemplateType(BaseCmd cmd, boolean isAdmin, boolean isCrossZones);
+
List<DatadiskTO> getTemplateDisksOnImageStore(Long templateId, DataStoreRole role, String configurationId);
+
Review Comment:
done, thanks
##########
test/integration/smoke/test_vnf_templates.py:
##########
@@ -0,0 +1,338 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Smoke tests for VNF templates/appliances
+"""
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.base import (Account,
+ Domain,
+ Configurations,
+ ServiceOffering,
+ VirtualMachine,
+ Network,
+ NetworkOffering,
+ VnfTemplate,
+ Zone)
+from marvin.lib.common import get_zone, get_template
+from nose.plugins.attrib import attr
+
+import time
+
+VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"}]
+NEW_VNF_NICS = [{"deviceid": "0", "name": "WAN", "required": "true", "description": "Public WAN"},
+ {"deviceid": "1", "name": "LAN-1", "required": "true", "description": "Private LAN-1"},
+ {"deviceid": "2", "name": "LAN-2", "required": "false", "description": "Private LAN-2"}]
+VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root"}]
+NEW_VNF_DETAILS = [{"access_methods": "console,https,http", "username": "root", "password": "cloudstack"}]
+
+class TestVnfTemplates(cloudstackTestCase):
+
+ @classmethod
+ def setUpClass(cls):
+
+ testClient = super(TestVnfTemplates, cls).getClsTestClient()
+ cls.apiclient = testClient.getApiClient()
+ cls._cleanup = []
+ cls.services = testClient.getParsedTestDataConfig()
+
+ # Get Zone, Domain and templates
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+ zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
+ cls.zone = Zone(zone.__dict__)
+ cls.template = get_template(cls.apiclient, cls.zone.id)
+
+ cls.domain = Domain.create(
+ cls.apiclient,
+ cls.services["domain"]
+ )
Review Comment:
done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1742661300
@weizhouapache a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1742545214
@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1742544275
@blueorangutan LLpackage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1745025319
@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1746102149
<b>[LL]Trillian test result (tid-6770)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 46994 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t6770-vmware-67u3.zip
Smoke tests completed. 112 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_upgrade_kubernetes_cluster | `Failure` | 602.74 | test_kubernetes_clusters.py
test_01_register_vnf_template | `Error` | 0.06 | test_vnf_templates.py
test_02_list_vnf_template | `Failure` | 0.00 | test_vnf_templates.py
test_03_edit_vnf_template | `Failure` | 0.00 | test_vnf_templates.py
test_04_deploy_vnf_appliance | `Failure` | 0.00 | test_vnf_templates.py
test_05_delete_vnf_template | `Failure` | 0.00 | test_vnf_templates.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1345539957
##########
ui/src/views/image/RegisterOrUploadTemplate.vue:
##########
@@ -1,3 +1,4 @@
+
Review Comment:
(1) is a no go i think , not from a test perspective at least
(2) would have my preference
(3) is not ideal but could work if the execution order of the tests is guaranteed.
as seen in https://github.com/apache/cloudstack/pull/8022#issuecomment-1746102149, if test 1 fails, all do. even while test 1 failure is environmental.
any comment @borisstoyanov ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1345530755
##########
ui/src/views/image/RegisterOrUploadTemplate.vue:
##########
@@ -1,3 +1,4 @@
+
Review Comment:
@DaanHoogland
I have committed most of the suggestions, thanks.
regarding the smoke test, currently in each test, there is a check if the vnf template is ready, so there is no intermitt failures.
I can
(1) merge all tests into 1 test
(2) or, register vnf template at each test and delete after test.
(3) keep current code
which one do you prefer ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1766073134
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1757593301
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1761839132
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1761309266
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1761963570
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1772273474
<b>[SF] Trillian test result (tid-8025)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41898 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8025-kvm-centos7.zip
Smoke tests completed. 113 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_vm_wrong_checksum | `Error` | 40.63 | test_templates.py
test_09_list_templates_download_details | `Failure` | 0.05 | test_templates.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1772632126
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1773983877
<b>[SF] Trillian test result (tid-8047)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39957 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8047-xenserver-71.zip
Smoke tests completed. 113 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_trigger_shutdown | `Failure` | 336.70 | test_safe_shutdown.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1774681197
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New feature: VNF templates and appliances integration [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#issuecomment-1782209434
<b>[SF] Trillian test result (tid-8115)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42089 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8022-t8115-kvm-centos7.zip
Smoke tests completed. 115 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org