You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/04/30 16:31:07 UTC
[GitHub] [geode] jdeppe-pivotal opened a new pull request #6409: GEODE-9220: Switch hash integration tests to use JedisCluster
jdeppe-pivotal opened a new pull request #6409:
URL: https://github.com/apache/geode/pull/6409
- This also renames RedisPortSupplier to RedisIntegrationTest. This
interface now includes a flushAll() method to be implemented by tests
that use NativeRedisClusterTestRule.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #6409: GEODE-9220: Switch hash integration tests to use JedisCluster
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #6409:
URL: https://github.com/apache/geode/pull/6409#discussion_r626571986
##########
File path: geode-apis-compatible-with-redis/src/commonTest/java/org/apache/geode/redis/internal/proxy/RedisProxy.java
##########
@@ -49,7 +50,7 @@
public RedisProxy(int targetPort) {
bossGroup = new NioEventLoopGroup(1);
- workerGroup = new NioEventLoopGroup(1);
+ workerGroup = new NioEventLoopGroup(4, new DefaultThreadFactory("RedisProxy"));
Review comment:
Good call. At some point I had changed this because I thought it was improving performance, but I think I was mistaken. I'm setting it back to `1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal merged pull request #6409: GEODE-9220: Switch hash integration tests to use JedisCluster
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal merged pull request #6409:
URL: https://github.com/apache/geode/pull/6409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbey37 commented on a change in pull request #6409: GEODE-9220: Switch hash integration tests to use JedisCluster
Posted by GitBox <gi...@apache.org>.
sabbey37 commented on a change in pull request #6409:
URL: https://github.com/apache/geode/pull/6409#discussion_r626027261
##########
File path: geode-apis-compatible-with-redis/src/commonTest/java/org/apache/geode/redis/internal/proxy/RedisProxy.java
##########
@@ -49,7 +50,7 @@
public RedisProxy(int targetPort) {
bossGroup = new NioEventLoopGroup(1);
- workerGroup = new NioEventLoopGroup(1);
+ workerGroup = new NioEventLoopGroup(4, new DefaultThreadFactory("RedisProxy"));
Review comment:
I apologize if this is obvious, but what's the reason for the additional workerGroup threads?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #6409: GEODE-9220: Switch hash integration tests to use JedisCluster
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on pull request #6409:
URL: https://github.com/apache/geode/pull/6409#issuecomment-830227707
For anyone reviewing this - the first commit is the main one...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #6409: GEODE-9220: Switch hash integration tests to use JedisCluster
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #6409:
URL: https://github.com/apache/geode/pull/6409#discussion_r626639856
##########
File path: geode-apis-compatible-with-redis/src/commonTest/java/org/apache/geode/redis/internal/proxy/RedisProxy.java
##########
@@ -49,7 +50,7 @@
public RedisProxy(int targetPort) {
bossGroup = new NioEventLoopGroup(1);
- workerGroup = new NioEventLoopGroup(1);
+ workerGroup = new NioEventLoopGroup(4, new DefaultThreadFactory("RedisProxy"));
Review comment:
Switching to `2` because it does seem to make some tests run faster, but I don't quite understand why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org