You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mjsax (via GitHub)" <gi...@apache.org> on 2025/01/16 03:51:16 UTC
[PR] KAFKA-17162: join() started thread in DefaultTaskManagerTest [kafka]
mjsax opened a new pull request, #18570:
URL: https://github.com/apache/kafka/pull/18570
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17162: join() started thread in DefaultTaskManagerTest [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #18570:
URL: https://github.com/apache/kafka/pull/18570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17162: join() started thread in DefaultTaskManagerTest [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #18570:
URL: https://github.com/apache/kafka/pull/18570#discussion_r1920952304
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskManagerTest.java:
##########
@@ -137,6 +137,8 @@ public void shouldBlockOnAwait() throws InterruptedException {
assertFalse(awaitingRunnable.awaitDone.await(100, TimeUnit.MILLISECONDS));
awaitingRunnable.shutdown();
+ awaitingThread.join();
+ assertFalse(awaitingThread.isAlive());
Review Comment:
Not sure if we need to add this check, as `join()` would block forever anyway (so it seems we either timeout, or know it will return `true` and the check is redundant).
Or as an alternative, keep this check, but add a max wait time to `join()`.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17162: join() started thread in DefaultTaskManagerTest [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #18570:
URL: https://github.com/apache/kafka/pull/18570#issuecomment-2599487481
Java 17
```
Found 1 test failures:
FAILED ❌ MetricsDuringTopicCreationDeletionTest > "testMetricsDuringTopicCreateDelete(String).quorum=kraft"
Found 2 flaky test failures:
FLAKY ⚠️ ConfigCommandIntegrationTest > testNullStatusOnKraftCommandAlterUserQuota [1] Type=Raft-Isolated, MetadataVersion=4.0-IV3,BrokerSecurityProtocol=PLAINTEXT,BrokerListenerName=ListenerName(EXTERNAL),ControllerSecurityProtocol=PLAINTEXT,ControllerListenerName=ListenerName(CONTROLLER)
FLAKY ⚠️ AbstractCoordinatorTest > testWakeupAfterSyncGroupReceivedExternalCompletion()
```
Java 23 passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17162: join() started thread in DefaultTaskManagerTest [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on code in PR #18570:
URL: https://github.com/apache/kafka/pull/18570#discussion_r1930176709
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskManagerTest.java:
##########
@@ -137,6 +137,8 @@ public void shouldBlockOnAwait() throws InterruptedException {
assertFalse(awaitingRunnable.awaitDone.await(100, TimeUnit.MILLISECONDS));
awaitingRunnable.shutdown();
+ awaitingThread.join();
+ assertFalse(awaitingThread.isAlive());
Review Comment:
Yeah, I think I'd just `join` the thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17162: join() started thread in DefaultTaskManagerTest [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #18570:
URL: https://github.com/apache/kafka/pull/18570#issuecomment-2596377950
Test passed. Will re-trigger build to see if we can still reproduce the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org