You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "ransom.hezhiqiang (JIRA)" <ji...@apache.org> on 2012/06/07 13:13:22 UTC
[jira] [Created] (HIVE-3101) dropTable will all ways excute
hook.rollbackDropTable whether drop table success or faild.
ransom.hezhiqiang created HIVE-3101:
---------------------------------------
Summary: dropTable will all ways excute hook.rollbackDropTable whether drop table success or faild.
Key: HIVE-3101
URL: https://issues.apache.org/jira/browse/HIVE-3101
Project: Hive
Issue Type: Bug
Components: Metastore
Reporter: ransom.hezhiqiang
see the codes:
boolean success = false;
try {
client.drop_table(dbname, name, deleteData);
if (hook != null) {
hook.commitDropTable(tbl, deleteData);
}
} catch (NoSuchObjectException e) {
if (!ignoreUknownTab) {
throw e;
}
} finally {
if (!success && (hook != null)) {
hook.rollbackDropTable(tbl);
}
}
success will always false, whether the drop was success or faild.
so it's a bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-3101) dropTable will all ways excute
hook.rollbackDropTable whether drop table success or faild.
Posted by "ransom.hezhiqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ransom.hezhiqiang reassigned HIVE-3101:
---------------------------------------
Assignee: ransom.hezhiqiang
> dropTable will all ways excute hook.rollbackDropTable whether drop table success or faild.
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-3101
> URL: https://issues.apache.org/jira/browse/HIVE-3101
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: ransom.hezhiqiang
> Assignee: ransom.hezhiqiang
> Attachments: HIVE-3101.1.patch
>
>
> see the codes:
> boolean success = false;
> try {
> client.drop_table(dbname, name, deleteData);
> if (hook != null) {
> hook.commitDropTable(tbl, deleteData);
> }
> } catch (NoSuchObjectException e) {
> if (!ignoreUknownTab) {
> throw e;
> }
> } finally {
> if (!success && (hook != null)) {
> hook.rollbackDropTable(tbl);
> }
> }
> success will always false, whether the drop was success or faild.
> so it's a bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3101) dropTable will all ways excute
hook.rollbackDropTable whether drop table success or faild.
Posted by "ransom.hezhiqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ransom.hezhiqiang updated HIVE-3101:
------------------------------------
Attachment: HIVE-3101.1.patch
add success=true in the codes.
> dropTable will all ways excute hook.rollbackDropTable whether drop table success or faild.
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-3101
> URL: https://issues.apache.org/jira/browse/HIVE-3101
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: ransom.hezhiqiang
> Attachments: HIVE-3101.1.patch
>
>
> see the codes:
> boolean success = false;
> try {
> client.drop_table(dbname, name, deleteData);
> if (hook != null) {
> hook.commitDropTable(tbl, deleteData);
> }
> } catch (NoSuchObjectException e) {
> if (!ignoreUknownTab) {
> throw e;
> }
> } finally {
> if (!success && (hook != null)) {
> hook.rollbackDropTable(tbl);
> }
> }
> success will always false, whether the drop was success or faild.
> so it's a bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3101) dropTable will all ways excute
hook.rollbackDropTable whether drop table success or faild.
Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292460#comment-13292460 ]
Edward Capriolo commented on HIVE-3101:
---------------------------------------
+1 will commit.
> dropTable will all ways excute hook.rollbackDropTable whether drop table success or faild.
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-3101
> URL: https://issues.apache.org/jira/browse/HIVE-3101
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: ransom.hezhiqiang
> Assignee: ransom.hezhiqiang
> Attachments: HIVE-3101.1.patch
>
>
> see the codes:
> boolean success = false;
> try {
> client.drop_table(dbname, name, deleteData);
> if (hook != null) {
> hook.commitDropTable(tbl, deleteData);
> }
> } catch (NoSuchObjectException e) {
> if (!ignoreUknownTab) {
> throw e;
> }
> } finally {
> if (!success && (hook != null)) {
> hook.rollbackDropTable(tbl);
> }
> }
> success will always false, whether the drop was success or faild.
> so it's a bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3101) dropTable will all ways excute
hook.rollbackDropTable whether drop table success or faild.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292485#comment-13292485 ]
Hudson commented on HIVE-3101:
------------------------------
Integrated in Hive-trunk-h0.21 #1477 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1477/])
HIVE-3101. Drop table rollback hook always called. (Ransom Hezhiqiang via egc) (Revision 1348523)
Result = FAILURE
ecapriolo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1348523
Files :
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> dropTable will all ways excute hook.rollbackDropTable whether drop table success or faild.
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-3101
> URL: https://issues.apache.org/jira/browse/HIVE-3101
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: ransom.hezhiqiang
> Assignee: ransom.hezhiqiang
> Fix For: 0.10.0
>
> Attachments: HIVE-3101.1.patch
>
>
> see the codes:
> boolean success = false;
> try {
> client.drop_table(dbname, name, deleteData);
> if (hook != null) {
> hook.commitDropTable(tbl, deleteData);
> }
> } catch (NoSuchObjectException e) {
> if (!ignoreUknownTab) {
> throw e;
> }
> } finally {
> if (!success && (hook != null)) {
> hook.rollbackDropTable(tbl);
> }
> }
> success will always false, whether the drop was success or faild.
> so it's a bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3101) dropTable will all ways excute
hook.rollbackDropTable whether drop table success or faild.
Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291814#comment-13291814 ]
Edward Capriolo commented on HIVE-3101:
---------------------------------------
I will review.
> dropTable will all ways excute hook.rollbackDropTable whether drop table success or faild.
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-3101
> URL: https://issues.apache.org/jira/browse/HIVE-3101
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: ransom.hezhiqiang
> Assignee: ransom.hezhiqiang
> Attachments: HIVE-3101.1.patch
>
>
> see the codes:
> boolean success = false;
> try {
> client.drop_table(dbname, name, deleteData);
> if (hook != null) {
> hook.commitDropTable(tbl, deleteData);
> }
> } catch (NoSuchObjectException e) {
> if (!ignoreUknownTab) {
> throw e;
> }
> } finally {
> if (!success && (hook != null)) {
> hook.rollbackDropTable(tbl);
> }
> }
> success will always false, whether the drop was success or faild.
> so it's a bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3101) dropTable will all ways excute
hook.rollbackDropTable whether drop table success or faild.
Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward Capriolo updated HIVE-3101:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed. Thanks.
> dropTable will all ways excute hook.rollbackDropTable whether drop table success or faild.
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-3101
> URL: https://issues.apache.org/jira/browse/HIVE-3101
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: ransom.hezhiqiang
> Assignee: ransom.hezhiqiang
> Attachments: HIVE-3101.1.patch
>
>
> see the codes:
> boolean success = false;
> try {
> client.drop_table(dbname, name, deleteData);
> if (hook != null) {
> hook.commitDropTable(tbl, deleteData);
> }
> } catch (NoSuchObjectException e) {
> if (!ignoreUknownTab) {
> throw e;
> }
> } finally {
> if (!success && (hook != null)) {
> hook.rollbackDropTable(tbl);
> }
> }
> success will always false, whether the drop was success or faild.
> so it's a bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3101) dropTable will all ways excute
hook.rollbackDropTable whether drop table success or faild.
Posted by "ransom.hezhiqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ransom.hezhiqiang updated HIVE-3101:
------------------------------------
Status: Patch Available (was: Open)
> dropTable will all ways excute hook.rollbackDropTable whether drop table success or faild.
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-3101
> URL: https://issues.apache.org/jira/browse/HIVE-3101
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: ransom.hezhiqiang
> Attachments: HIVE-3101.1.patch
>
>
> see the codes:
> boolean success = false;
> try {
> client.drop_table(dbname, name, deleteData);
> if (hook != null) {
> hook.commitDropTable(tbl, deleteData);
> }
> } catch (NoSuchObjectException e) {
> if (!ignoreUknownTab) {
> throw e;
> }
> } finally {
> if (!success && (hook != null)) {
> hook.rollbackDropTable(tbl);
> }
> }
> success will always false, whether the drop was success or faild.
> so it's a bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3101) dropTable will all ways excute
hook.rollbackDropTable whether drop table success or faild.
Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291809#comment-13291809 ]
Edward Capriolo commented on HIVE-3101:
---------------------------------------
Can we create a unit test around this? Hooks should print during testing and then we have some coverage here.
> dropTable will all ways excute hook.rollbackDropTable whether drop table success or faild.
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-3101
> URL: https://issues.apache.org/jira/browse/HIVE-3101
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: ransom.hezhiqiang
> Assignee: ransom.hezhiqiang
> Attachments: HIVE-3101.1.patch
>
>
> see the codes:
> boolean success = false;
> try {
> client.drop_table(dbname, name, deleteData);
> if (hook != null) {
> hook.commitDropTable(tbl, deleteData);
> }
> } catch (NoSuchObjectException e) {
> if (!ignoreUknownTab) {
> throw e;
> }
> } finally {
> if (!success && (hook != null)) {
> hook.rollbackDropTable(tbl);
> }
> }
> success will always false, whether the drop was success or faild.
> so it's a bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3101) dropTable will all ways excute
hook.rollbackDropTable whether drop table success or faild.
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-3101:
-----------------------------------
Fix Version/s: 0.10.0
> dropTable will all ways excute hook.rollbackDropTable whether drop table success or faild.
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-3101
> URL: https://issues.apache.org/jira/browse/HIVE-3101
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: ransom.hezhiqiang
> Assignee: ransom.hezhiqiang
> Fix For: 0.10.0
>
> Attachments: HIVE-3101.1.patch
>
>
> see the codes:
> boolean success = false;
> try {
> client.drop_table(dbname, name, deleteData);
> if (hook != null) {
> hook.commitDropTable(tbl, deleteData);
> }
> } catch (NoSuchObjectException e) {
> if (!ignoreUknownTab) {
> throw e;
> }
> } finally {
> if (!success && (hook != null)) {
> hook.rollbackDropTable(tbl);
> }
> }
> success will always false, whether the drop was success or faild.
> so it's a bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3101) dropTable will all ways excute
hook.rollbackDropTable whether drop table success or faild.
Posted by "ransom.hezhiqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291812#comment-13291812 ]
ransom.hezhiqiang commented on HIVE-3101:
-----------------------------------------
the default hook is HBaseStorageHandler, it will be cover these codes when create hbase table.
so i think we already have some unit test about hbase table in hive.
it doesn't need to create unit test.
if we need more test case, i will create it.
> dropTable will all ways excute hook.rollbackDropTable whether drop table success or faild.
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-3101
> URL: https://issues.apache.org/jira/browse/HIVE-3101
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: ransom.hezhiqiang
> Assignee: ransom.hezhiqiang
> Attachments: HIVE-3101.1.patch
>
>
> see the codes:
> boolean success = false;
> try {
> client.drop_table(dbname, name, deleteData);
> if (hook != null) {
> hook.commitDropTable(tbl, deleteData);
> }
> } catch (NoSuchObjectException e) {
> if (!ignoreUknownTab) {
> throw e;
> }
> } finally {
> if (!success && (hook != null)) {
> hook.rollbackDropTable(tbl);
> }
> }
> success will always false, whether the drop was success or faild.
> so it's a bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira