You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by dp...@apache.org on 2018/11/21 05:54:59 UTC

[cordova-android] branch master updated: Output current package name if package name can't be validated

This is an automated email from the ASF dual-hosted git repository.

dpogue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git


The following commit(s) were added to refs/heads/master by this push:
     new a014228  Output current package name if package name can't be validated
a014228 is described below

commit a014228f7cb7f4a4583ad6a2b032434f4ce2f4fa
Author: Jan Piotrowski <pi...@gmail.com>
AuthorDate: Wed Nov 21 06:54:55 2018 +0100

    Output current package name if package name can't be validated
    
    We have this of the package name. It only outputs that the current one is bad, not what the current one actually is. Added an output of the current one to the error.
---
 bin/lib/create.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/lib/create.js b/bin/lib/create.js
index af0d298..2b5a65e 100755
--- a/bin/lib/create.js
+++ b/bin/lib/create.js
@@ -194,7 +194,7 @@ function validatePackageName (package_name) {
     var msg = 'Error validating package name. ';
 
     if (!/^[a-zA-Z][a-zA-Z0-9_]+(\.[a-zA-Z][a-zA-Z0-9_]*)+$/.test(package_name)) {
-        return Q.reject(new CordovaError(msg + 'Package name must look like: com.company.Name'));
+        return Q.reject(new CordovaError(msg + 'Must look like: `com.company.Name`. Currently is: `' + package_name + '`'));
     }
 
     // Class is a reserved word


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org