You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/04/26 06:18:26 UTC
[kudu-CR] KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21359
Change subject: KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
......................................................................
KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
This patch addresses data race reported in KUDU-3569, using
the tablet schema defined by the iterator's projection instead of
the schema stored in the tablet metadata file. The latter might
be swapped by concurrently running AlterTable, which is the root
cause of the data race.
This is a follow-up to 936d7edc4e4b69d2e1f1dffc96760cb3fd57a934.
Change-Id: I92daa74cb86a77a4350f42db9ca5dec3a0d4ff75
---
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/21359/1
--
To view, visit http://gerrit.cloudera.org:8080/21359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92daa74cb86a77a4350f42db9ca5dec3a0d4ff75
Gerrit-Change-Number: 21359
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21359
to look at the new patch set (#2).
Change subject: KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
......................................................................
KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
This patch addresses data race reported in KUDU-3569, using
the tablet schema defined by the iterator's projection instead of
the schema stored in the tablet metadata file. The latter might
be swapped by concurrently running AlterTable, which is the root
cause of the data race.
This is a follow-up to 936d7edc4e4b69d2e1f1dffc96760cb3fd57a934.
Change-Id: I92daa74cb86a77a4350f42db9ca5dec3a0d4ff75
---
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
2 files changed, 16 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/21359/2
--
To view, visit http://gerrit.cloudera.org:8080/21359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I92daa74cb86a77a4350f42db9ca5dec3a0d4ff75
Gerrit-Change-Number: 21359
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21359 )
Change subject: KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/49/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92daa74cb86a77a4350f42db9ca5dec3a0d4ff75
Gerrit-Change-Number: 21359
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 26 Apr 2024 22:36:26 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I92daa74cb86a77a4350f42db9ca5dec3a0d4ff75
Gerrit-Change-Number: 21359
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21359 )
Change subject: KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
......................................................................
KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
This patch addresses data race reported in KUDU-3569, using
the tablet schema defined by the iterator's projection instead of
the schema stored in the tablet metadata file. The latter might
be swapped by concurrently running AlterTable, which is the root
cause of the data race.
This is a follow-up to 936d7edc4e4b69d2e1f1dffc96760cb3fd57a934.
Change-Id: I92daa74cb86a77a4350f42db9ca5dec3a0d4ff75
Reviewed-on: http://gerrit.cloudera.org:8080/21359
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
2 files changed, 16 insertions(+), 6 deletions(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/21359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I92daa74cb86a77a4350f42db9ca5dec3a0d4ff75
Gerrit-Change-Number: 21359
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21359 )
Change subject: KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
......................................................................
Patch Set 2: Verified+1
unreleated Java tests (RELEASE) and C++ tests (ASAN) alter_table-randomized-test, rpc-test
--
To view, visit http://gerrit.cloudera.org:8080/21359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92daa74cb86a77a4350f42db9ca5dec3a0d4ff75
Gerrit-Change-Number: 21359
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 26 Apr 2024 22:53:23 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21359 )
Change subject: KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/45/
--
To view, visit http://gerrit.cloudera.org:8080/21359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92daa74cb86a77a4350f42db9ca5dec3a0d4ff75
Gerrit-Change-Number: 21359
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 26 Apr 2024 06:18:34 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21359 )
Change subject: KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/45/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92daa74cb86a77a4350f42db9ca5dec3a0d4ff75
Gerrit-Change-Number: 21359
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 26 Apr 2024 07:29:22 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21359 )
Change subject: KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/49/
--
To view, visit http://gerrit.cloudera.org:8080/21359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92daa74cb86a77a4350f42db9ca5dec3a0d4ff75
Gerrit-Change-Number: 21359
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 26 Apr 2024 21:26:21 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21359 )
Change subject: KUDU-3569 fix race in CFileSet::Iterator::OptimizePKPredicates()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92daa74cb86a77a4350f42db9ca5dec3a0d4ff75
Gerrit-Change-Number: 21359
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 26 Apr 2024 23:18:19 +0000
Gerrit-HasComments: No