You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@excalibur.apache.org by Niclas Hedhman <ni...@hedhman.org> on 2004/10/17 04:41:48 UTC

NoopInstrumentManager has moved incompatibly

Leif,

You have at some point made an incompatible change, by moving the 
NoopInstrumentManager to a different package.

This broke;
http://brutus.apache.org/gump/public/avalon-phoenix/avalon-phoenix/gump_work/build_avalon-phoenix_avalon-phoenix.html

which in turn affect another 13 projects.


import org.apache.excalibur.instrument.manager.NoopInstrumentManager;

vs

[niclas@f2 instrument]$ jar tf 
./api/target/excalibur-instrument-api-1.2-dev.jar | grep Noop.*Manager\.class
org/apache/excalibur/instrument/NoopInstrumentManager.class


I suggest it is put back where it was.


Cheers
Niclas
-- 
   +------//-------------------+
  / http://www.bali.ac        /
 / http://niclas.hedhman.org / 
+------//-------------------+


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
Apache Excalibur Project -- URL: http://excalibur.apache.org/


Re: NoopInstrumentManager has moved incompatibly

Posted by peter royal <pe...@pobox.com>.
On Oct 20, 2004, at 5:33 AM, Niclas Hedhman wrote:
> Question 1; Does James run out-of-the-box on Loom?

it should. my phoenix application does. i don't know of anyone that has 
explicitly tested James though

> Question 2; Can/should we add Loom to the be built from source by Gump?

we can.. loom is a maven build so as long as gump can build maven 
projects without any extra work (ie, deducing it all from the pom)..

but it won't be of much value to projects that "depend" upon loom as 
the client contract is still all wrapped up in Avalon and the 
phoenix-client jar (from the last public release of phoenix)
-pete

Re: NoopInstrumentManager has moved incompatibly

Posted by Peter Donald <pe...@realityforge.org>.
Niclas Hedhman wrote:
> Question 1; Does James run out-of-the-box on Loom?

James should run out of the box *IF* a few extra jars are added to the 
deployment archive.

> Question 2; Can/should we add Loom to the be built from source by Gump?

It is possible but it may not add any value as the only part that james 
would directly depend upon is the phoenix-api jar. Loom uses the last 
release of this from avalon which was probably the release of a few 
years ago. It would be better to archive off phoenix, but maybe keep the 
phoenix-api jar dependency around or something. NFI as I haven't looked 
at the source for ages!



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
Apache Excalibur Project -- URL: http://excalibur.apache.org/


Re: NoopInstrumentManager has moved incompatibly

Posted by Niclas Hedhman <ni...@hedhman.org>.
On Wednesday 20 October 2004 17:07, Peter Donald wrote:
> Niclas Hedhman wrote:
> > On Sunday 17 October 2004 10:41, Niclas Hedhman wrote:
> >>Leif,
> >>You have at some point made an incompatible change, by moving the
> >>NoopInstrumentManager to a different package.
> >
> > Maybe this got buried in too many Gump messages.
>
> If this is the change I think it was then the change was made close to 2
> years ago and given that phoenix was no longer maintained, it ceased to
> compile. I would axe phoenix from gump if possible otherwise you can
> just depend on specific static version of instrument as a jar dependency.

Ok.

Question 1; Does James run out-of-the-box on Loom?
Question 2; Can/should we add Loom to the be built from source by Gump?


Cheers
Niclas
-- 
   +------//-------------------+
  / http://www.bali.ac        /
 / http://niclas.hedhman.org / 
+------//-------------------+


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
Apache Excalibur Project -- URL: http://excalibur.apache.org/


Re: NoopInstrumentManager has moved incompatibly

Posted by Peter Donald <pe...@realityforge.org>.
Niclas Hedhman wrote:
> On Sunday 17 October 2004 10:41, Niclas Hedhman wrote:
> 
> 
>>Leif,
>>You have at some point made an incompatible change, by moving the
>>NoopInstrumentManager to a different package.
> 
> 
> Maybe this got buried in too many Gump messages.

If this is the change I think it was then the change was made close to 2 
years ago and given that phoenix was no longer maintained, it ceased to 
compile. I would axe phoenix from gump if possible otherwise you can 
just depend on specific static version of instrument as a jar dependency.




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
Apache Excalibur Project -- URL: http://excalibur.apache.org/


Re: NoopInstrumentManager has moved incompatibly

Posted by Niclas Hedhman <ni...@hedhman.org>.
On Sunday 17 October 2004 10:41, Niclas Hedhman wrote:

> Leif,
> You have at some point made an incompatible change, by moving the
> NoopInstrumentManager to a different package.

Maybe this got buried in too many Gump messages.


Cheers
Niclas
-- 
   +------//-------------------+
  / http://www.bali.ac        /
 / http://niclas.hedhman.org / 
+------//-------------------+


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
Apache Excalibur Project -- URL: http://excalibur.apache.org/


Re: NoopInstrumentManager has moved incompatibly

Posted by Leif Mortenson <le...@tanukisoftware.com>.
Niclas,
    There have actually been a few incompatible changes to the 
instrument packages
a couple months ago.  They were discussed on the list.  It may cause a 
little little
trouble for container implementations.  But the changes will not affect 
other users
and are good for the long term design of the APIs.
    The old packages had a couple design flaws that needed to be cleaned up
before too may users started using the APIs.

    The best fix here is to update Phoenix source to work with the new 
location.

    Sorry for the hassle.

Cheers,
Leif

Niclas Hedhman wrote:

>Leif,
>
>You have at some point made an incompatible change, by moving the 
>NoopInstrumentManager to a different package.
>
>This broke;
>http://brutus.apache.org/gump/public/avalon-phoenix/avalon-phoenix/gump_work/build_avalon-phoenix_avalon-phoenix.html
>
>which in turn affect another 13 projects.
>
>
>import org.apache.excalibur.instrument.manager.NoopInstrumentManager;
>
>vs
>
>[niclas@f2 instrument]$ jar tf 
>./api/target/excalibur-instrument-api-1.2-dev.jar | grep Noop.*Manager\.class
>org/apache/excalibur/instrument/NoopInstrumentManager.class
>
>
>I suggest it is put back where it was.
>
>
>Cheers
>Niclas
>  
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
Apache Excalibur Project -- URL: http://excalibur.apache.org/