You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "if0ne (via GitHub)" <gi...@apache.org> on 2026/01/30 09:41:03 UTC
[PR] refactor(rust/core): moved adbc traits to sync mod [arrow-adbc]
if0ne opened a new pull request, #3932:
URL: https://github.com/apache/arrow-adbc/pull/3932
A small step toward implementing #3714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(rust/core): moved adbc traits to sync mod [arrow-adbc]
Posted by "if0ne (via GitHub)" <gi...@apache.org>.
if0ne commented on PR #3932:
URL: https://github.com/apache/arrow-adbc/pull/3932#issuecomment-3823078773
Clean up `lib.rs`. I'm re-exporting trais from the sync module
https://github.com/if0ne/arrow-adbc/blob/bf2f871b2b2264dbbb0fcb1fac66c79f1826e431/rust/core/src/lib.rs#L48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(rust/core): moved adbc traits to sync mod [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #3932:
URL: https://github.com/apache/arrow-adbc/pull/3932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(rust/core): moved adbc traits to sync mod [arrow-adbc]
Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on PR #3932:
URL: https://github.com/apache/arrow-adbc/pull/3932#issuecomment-3847168549
There doesn't seem to be any problem with this movement 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(rust/core): moved adbc traits to sync mod [arrow-adbc]
Posted by "if0ne (via GitHub)" <gi...@apache.org>.
if0ne commented on PR #3932:
URL: https://github.com/apache/arrow-adbc/pull/3932#issuecomment-3822803083
СС @lidavidm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(rust/core): moved adbc traits to sync mod [arrow-adbc]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on PR #3932:
URL: https://github.com/apache/arrow-adbc/pull/3932#issuecomment-3848532203
> @felipecrv @eitsupi any concerns?
I would prefer `sync` to be the default (no namespace), but that is a minority take.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(rust/core): moved adbc traits to sync mod [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #3932:
URL: https://github.com/apache/arrow-adbc/pull/3932#issuecomment-3845679421
@felipecrv @eitsupi any concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(rust/core): moved adbc traits to sync mod [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #3932:
URL: https://github.com/apache/arrow-adbc/pull/3932#issuecomment-3823061576
While I'm not opposed to breaking changes, I still feel it would be least disruptive to have the async traits in their own (new) module, rather than the sync traits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(rust/core): moved adbc traits to sync mod [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #3932:
URL: https://github.com/apache/arrow-adbc/pull/3932#issuecomment-3823063389
Or is this just to clean up `lib.rs` while keeping public import paths the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(rust/core): moved adbc traits to sync mod [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #3932:
URL: https://github.com/apache/arrow-adbc/pull/3932#issuecomment-3850431648
> > @felipecrv @eitsupi any concerns?
>
> I would prefer `sync` to be the default (no namespace), but that is a minority take.
Right, this doesn't change anything, since the submodule's contents are re-exported. I do think that even when we add async traits, those should not be at the crate root but should be namespaced (and we can keep sync as the default).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org