You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dstandish (via GitHub)" <gi...@apache.org> on 2024/03/19 19:20:03 UTC
[PR] Implement get_dagrun on TaskInstancePydantic [airflow]
dstandish opened a new pull request, #38295:
URL: https://github.com/apache/airflow/pull/38295
Just what the title says. Bite-size part of AIP-44.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement get_dagrun on TaskInstancePydantic [airflow]
Posted by "mimjahana05-dev (via GitHub)" <gi...@apache.org>.
mimjahana05-dev commented on PR #38295:
URL: https://github.com/apache/airflow/pull/38295#issuecomment-3456445089
Jji
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement get_dagrun on TaskInstancePydantic [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #38295:
URL: https://github.com/apache/airflow/pull/38295#discussion_r1530968165
##########
airflow/models/taskinstance.py:
##########
@@ -2108,6 +2108,14 @@ def ready_for_retry(self) -> bool:
"""Check on whether the task instance is in the right state and timeframe to be retried."""
return self.state == TaskInstanceState.UP_FOR_RETRY and self.next_retry_datetime() < timezone.utcnow()
+ @staticmethod
+ @internal_api_call
+ def _get_dagrun(dag_id, run_id, session):
Review Comment:
nit
```suggestion
def _get_dagrun(dag_id, run_id, session) -> DagRun | DagRunPydantic:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement get_dagrun on TaskInstancePydantic [airflow]
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish merged PR #38295:
URL: https://github.com/apache/airflow/pull/38295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org