You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2024/11/06 16:16:11 UTC
[PR] Camel JBang shell command [camel]
gnodet opened a new pull request, #16182:
URL: https://github.com/apache/camel/pull/16182
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel JBang shell command [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #16182:
URL: https://github.com/apache/camel/pull/16182#discussion_r1835619472
##########
dsl/camel-jbang/camel-jbang-main/dist/CamelJBang.java:
##########
@@ -22,6 +22,7 @@
//DEPS org.apache.camel:camel-bom:${camel.jbang.version:4.8.1}@pom
//DEPS org.apache.camel:camel-jbang-core:${camel.jbang.version:4.8.1}
//DEPS org.apache.camel.kamelets:camel-kamelets:${camel-kamelets.version:4.8.0}
+//DEPS org.jline:jline:${camel-jline.version:3.27.1}
Review Comment:
Can this be in the pom.xml instead so we keep this file as before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel JBang shell command [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #16182:
URL: https://github.com/apache/camel/pull/16182#discussion_r1835328015
##########
dsl/camel-jbang/camel-jbang-core/pom.xml:
##########
@@ -136,6 +141,11 @@
<version>${jansi-version}</version>
</dependency>
+ <dependency>
+ <groupId>org.codehaus.plexus</groupId>
+ <artifactId>plexus-xml</artifactId>
+ </dependency>
Review Comment:
What is this used for ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel JBang shell command [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #16182:
URL: https://github.com/apache/camel/pull/16182#issuecomment-2466142362
> How much other dependencies does jline bring in?
There's no required dependency at all in JLine. They are all either optional or test deps:
https://repo1.maven.org/maven2/org/jline/jline/3.27.1/jline-3.27.1.pom
> I wonder as camel run should ideally be without too much clutter. And maybe we need to find a way for jbang to be able to dynamic select DEPS based on the command. The DEPS is a bit too static for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel JBang shell command [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #16182:
URL: https://github.com/apache/camel/pull/16182#issuecomment-2466111071
Also can you update the jbang docs, as this seems like a great feature for users to learn and play with camel-jbang and its worth to have in the docs. See under docs root folder there is a camel-jbang.adoc file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel JBang shell command [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #16182:
URL: https://github.com/apache/camel/pull/16182#discussion_r1835328279
##########
dsl/camel-jbang/camel-jbang-core/pom.xml:
##########
@@ -136,6 +141,11 @@
<version>${jansi-version}</version>
</dependency>
+ <dependency>
+ <groupId>org.codehaus.plexus</groupId>
+ <artifactId>plexus-xml</artifactId>
+ </dependency>
Review Comment:
This is slightly unrelated. The latest maven 4 builds include a fix in the way transitive dependency management is computed. This dependency is actually included in the dep tree with maven 3, but not with Maven 4, so I just included it at the same time. But this could be splitter into a different PR if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel JBang shell command [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #16182:
URL: https://github.com/apache/camel/pull/16182#discussion_r1835360357
##########
dsl/camel-jbang/camel-jbang-core/pom.xml:
##########
@@ -136,6 +141,11 @@
<version>${jansi-version}</version>
</dependency>
+ <dependency>
+ <groupId>org.codehaus.plexus</groupId>
+ <artifactId>plexus-xml</artifactId>
+ </dependency>
Review Comment:
okay thanks - its fine now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel JBang shell command [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #16182:
URL: https://github.com/apache/camel/pull/16182#issuecomment-2469959764
@gnodet did you get time to look at this - can we avoid DEPS to keep the file as before - there are also some camel jbang code that runs a custom camel version that creates a .java source that would break if this file now have extra deps instead of just in the pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel JBang shell command [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #16182:
URL: https://github.com/apache/camel/pull/16182#issuecomment-2466110861
How much other dependencies does jline bring in?
I wonder as camel run should ideally be without too much clutter. And maybe we need to find a way for jbang to be able to dynamic select DEPS based on the command. The DEPS is a bit too static for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-21443: Camel JBang shell command [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #16182:
URL: https://github.com/apache/camel/pull/16182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel JBang shell command [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #16182:
URL: https://github.com/apache/camel/pull/16182#issuecomment-2469966104
> @gnodet did you get time to look at this - can we avoid DEPS to keep the file as before - there are also some camel jbang code that runs a custom camel version that creates a .java source that would break if this file now have extra deps instead of just in the pom.xml
I'll have a look at it today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org