[jira] [Commented] (MRELEASE-1064) release:branch uses @releaseLabel instead of @branchName in default scm commit

["Alexey Ivanov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MRELEASE-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452201#comment-17452201 ] 

Alexey Ivanov commented on MRELEASE-1064:
-----------------------------------------

It seems it is better to fix code. It will be more clear to use.

[https://github.com/apache/maven-release/blob/814230235034885d1d785f7e124452f12718d402/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractScmCommitPhase.java#L224]

I believe should be

comment = comment.replace( "@\{prefix}", releaseDescriptor.getScmCommentPrefix().trim() );
comment = comment.replace( "@\{groupId}", project.getGroupId() );
comment = comment.replace( "@\{artifactId}", project.getArtifactId() );
comment = comment.replace( "@\{branchName}", releaseDescriptor.getScmReleaseLabel() ); // maybe it is better to add getScmBranchName() here? 
comment = comment.replace( "@\{releaseLabel}", releaseDescriptor.getScmReleaseLabel() );

 

> release:branch uses @releaseLabel instead of @branchName in default scm commit
> ------------------------------------------------------------------------------
>
>                 Key: MRELEASE-1064
>                 URL: https://issues.apache.org/jira/browse/MRELEASE-1064
>             Project: Maven Release Plugin
>          Issue Type: Bug
>          Components: branch
>    Affects Versions: 3.0.0-M4
>            Reporter: Jordan Amar
>            Priority: Major
>
> Calling plugin with this command: 
> {code:java}
> mvn release:branch -B -DbranchName=lol -DupdateBranchVersions=true -DdryRun{code}
>  (dry run or not) will create a commit with the folling comment:
> _[maven-release-plugin] prepare branch @\{releaseLabel}_
> +branchName+ should be used instead +releaseLabel+ in scmBranchCommitComment



--
This message was sent by Atlassian Jira
(v8.20.1#820001)