You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "amorynan (via GitHub)" <gi...@apache.org> on 2023/11/21 03:40:10 UTC
[PR] [FIX](jsonb)fix jsonb is not in predict column [doris]
amorynan opened a new pull request, #27325:
URL: https://github.com/apache/doris/pull/27325
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](jsonb)fix jsonb is not in predict column [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27325:
URL: https://github.com/apache/doris/pull/27325#issuecomment-1820170424
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](jsonb)fix jsonb is not in predict column [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27325:
URL: https://github.com/apache/doris/pull/27325#issuecomment-1820259937
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 72c529df8fd9d25d904396beee70fca97a79dbfc, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4928 4667 4655 4655
q2 356 175 159 159
q3 2059 1961 1879 1879
q4 1390 1276 1256 1256
q5 3988 3974 4027 3974
q6 249 129 131 129
q7 1431 889 896 889
q8 2761 2781 2801 2781
q9 9992 9797 9801 9797
q10 3488 3552 3550 3550
q11 382 250 254 250
q12 447 294 292 292
q13 4602 3788 3820 3788
q14 307 284 288 284
q15 589 545 529 529
q16 661 578 577 577
q17 1135 987 925 925
q18 7836 7243 7374 7243
q19 1674 1683 1687 1683
q20 562 302 287 287
q21 4422 3973 3959 3959
q22 482 363 363 363
Total cold run time: 53741 ms
Total hot run time: 49249 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4613 4599 4594 4594
q2 331 229 251 229
q3 4011 3982 3991 3982
q4 2977 2679 2701 2679
q5 9714 9572 9647 9572
q6 242 127 129 127
q7 3020 2505 2463 2463
q8 4480 4441 4478 4441
q9 13237 13032 13142 13032
q10 4120 4199 4209 4199
q11 790 646 700 646
q12 976 822 819 819
q13 4294 3556 3594 3556
q14 373 336 378 336
q15 570 521 523 521
q16 739 660 674 660
q17 3916 3893 3811 3811
q18 9508 9066 9074 9066
q19 1836 1773 1779 1773
q20 2377 2059 2047 2047
q21 8822 8354 8523 8354
q22 865 802 791 791
Total cold run time: 81811 ms
Total hot run time: 77698 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](jsonb)fix jsonb is not in predict column [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on code in PR #27325:
URL: https://github.com/apache/doris/pull/27325#discussion_r1399998360
##########
be/src/olap/schema.cpp:
##########
@@ -180,6 +180,7 @@ vectorized::IColumn::MutablePtr Schema::get_predicate_column_ptr(const Field& fi
break;
case FieldType::OLAP_FIELD_TYPE_VARCHAR:
case FieldType::OLAP_FIELD_TYPE_STRING:
+ case FieldType::OLAP_FIELD_TYPE_JSONB:
Review Comment:
Is it practical to use dictionary encoding for JSONB?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](jsonb)fix jsonb is not in predict column [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27325:
URL: https://github.com/apache/doris/pull/27325#issuecomment-1820300042
TeamCity be ut coverage result:
Function Coverage: 36.52% (8445/23125)
Line Coverage: 28.86% (68656/237907)
Region Coverage: 27.82% (35508/127623)
Branch Coverage: 24.58% (18105/73672)
Coverage Report: http://coverage.selectdb-in.cc/coverage/72c529df8fd9d25d904396beee70fca97a79dbfc_72c529df8fd9d25d904396beee70fca97a79dbfc/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](jsonb)fix jsonb is not in predict column [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27325:
URL: https://github.com/apache/doris/pull/27325#issuecomment-1820200245
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](jsonb)fix jsonb is not in predict column [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on code in PR #27325:
URL: https://github.com/apache/doris/pull/27325#discussion_r1400000863
##########
be/src/olap/schema.cpp:
##########
@@ -180,6 +180,7 @@ vectorized::IColumn::MutablePtr Schema::get_predicate_column_ptr(const Field& fi
break;
case FieldType::OLAP_FIELD_TYPE_VARCHAR:
case FieldType::OLAP_FIELD_TYPE_STRING:
+ case FieldType::OLAP_FIELD_TYPE_JSONB:
Review Comment:
now it is just string for jsonb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](jsonb)fix jsonb is not in predict column [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27325:
URL: https://github.com/apache/doris/pull/27325#issuecomment-1820299296
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](jsonb)fix jsonb is not in predict column [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27325:
URL: https://github.com/apache/doris/pull/27325#issuecomment-1820170346
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](jsonb)fix jsonb is not in predict column [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27325:
URL: https://github.com/apache/doris/pull/27325#issuecomment-1820169154
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](jsonb)fix jsonb is not in predict column [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #27325:
URL: https://github.com/apache/doris/pull/27325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](jsonb)fix jsonb is not in predict column [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27325:
URL: https://github.com/apache/doris/pull/27325#issuecomment-1820261700
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.65 seconds
stream load tsv: 567 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17098525948 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org