You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2019/07/15 19:40:15 UTC

[GitHub] [libcloud] Kami commented on a change in pull request #1292: [LIBCLOUD-1001] Update Cloudflare DNS driver to API v4

Kami commented on a change in pull request #1292: [LIBCLOUD-1001] Update Cloudflare DNS driver to API v4
URL: https://github.com/apache/libcloud/pull/1292#discussion_r303602221
 
 

 ##########
 File path: libcloud/dns/drivers/cloudflare.py
 ##########
 @@ -141,290 +159,252 @@ class CloudFlareDNSDriver(DNSDriver):
         RecordType.URL: 'LOC'
     }
 
+    PAGE_SIZE = 20
 
 Review comment:
   Does CloudFlare API support larger page size? If so, using something larger (e.g. 100) might be more efficient in some scenarios for accounts with a lot of domains / records.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services