You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/07/02 03:15:27 UTC
[GitHub] [helix] alirezazamani opened a new pull request #1135: Stabilize TestUpdateWorkflow
alirezazamani opened a new pull request #1135:
URL: https://github.com/apache/helix/pull/1135
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR title:
Fixes #1134
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
In this PR, Thread.sleep usages have been removed from TestUpdateWorkflow and replaced with TestHelper.verify.
### Tests
- [x] The following is the result of the "mvn test" command on the appropriate module:
helix-core:
```
[INFO] Tests run: 1151, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4,808.221 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1151, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:20 h
[INFO] Finished at: 2020-07-01T19:57:47-07:00
[INFO] ------------------------------------------------------------------------
```
helix-rest:
```
[INFO] Tests run: 163, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.365 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 163, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 46.985 s
[INFO] Finished at: 2020-07-01T20:13:47-07:00
[INFO] ------------------------------------------------------------------------
```
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [x] My diff has been formatted using helix-style.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #1135: Stabilize TestUpdateWorkflow
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1135:
URL: https://github.com/apache/helix/pull/1135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani commented on a change in pull request #1135: Stabilize TestUpdateWorkflow
Posted by GitBox <gi...@apache.org>.
alirezazamani commented on a change in pull request #1135:
URL: https://github.com/apache/helix/pull/1135#discussion_r454128486
##########
File path: helix-core/src/test/java/org/apache/helix/integration/task/TestUpdateWorkflow.java
##########
@@ -40,7 +40,7 @@
private static final Logger LOG = LoggerFactory.getLogger(TestUpdateWorkflow.class);
@Test
- public void testUpdateRunningQueue() throws InterruptedException {
+ public void testUpdateRunningQueue() throws Exception {
Review comment:
TestHelper.verify throws Exception. So InterruptedException needs to be changed to Exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani commented on pull request #1135: Stabilize TestUpdateWorkflow
Posted by GitBox <gi...@apache.org>.
alirezazamani commented on pull request #1135:
URL: https://github.com/apache/helix/pull/1135#issuecomment-658475318
This PR is ready to be merged, approved by @jiajunwang.
Final commit message:
Stabilize TestUpdateWorkflow
In this commit, Thread.sleep usages have been removed
from TestUpdateWorkflow and replaced with TestHelper.verify.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani commented on a change in pull request #1135: Stabilize TestUpdateWorkflow
Posted by GitBox <gi...@apache.org>.
alirezazamani commented on a change in pull request #1135:
URL: https://github.com/apache/helix/pull/1135#discussion_r454128486
##########
File path: helix-core/src/test/java/org/apache/helix/integration/task/TestUpdateWorkflow.java
##########
@@ -40,7 +40,7 @@
private static final Logger LOG = LoggerFactory.getLogger(TestUpdateWorkflow.class);
@Test
- public void testUpdateRunningQueue() throws InterruptedException {
+ public void testUpdateRunningQueue() throws Exception {
Review comment:
Using TestHelper.verify throws Exception. So InterruptedException needs to be changed to Exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1135: Stabilize TestUpdateWorkflow
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1135:
URL: https://github.com/apache/helix/pull/1135#discussion_r454119057
##########
File path: helix-core/src/test/java/org/apache/helix/integration/task/TestUpdateWorkflow.java
##########
@@ -40,7 +40,7 @@
private static final Logger LOG = LoggerFactory.getLogger(TestUpdateWorkflow.class);
@Test
- public void testUpdateRunningQueue() throws InterruptedException {
+ public void testUpdateRunningQueue() throws Exception {
Review comment:
Just curious, why change the InterruptedException to Exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org