You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pankajastro (via GitHub)" <gi...@apache.org> on 2023/07/19 14:07:29 UTC
[GitHub] [airflow] pankajastro opened a new pull request, #32696: Update Dag trigger API and command docs
pankajastro opened a new pull request, #32696:
URL: https://github.com/apache/airflow/pull/32696
trigger dagrun API and CLI command does not execute task if dag is paused.
document the same in API docs and CLI command docs
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Lee-W commented on a diff in pull request #32696: Update Dag trigger API and command docs
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #32696:
URL: https://github.com/apache/airflow/pull/32696#discussion_r1268253725
##########
airflow/api_connexion/openapi/v1.yaml:
##########
@@ -735,7 +735,7 @@ paths:
$ref: '#/components/responses/Unauthenticated'
post:
- summary: Trigger a new DAG run
+ summary: Trigger a new DAG run. If DAG is paused then darun state would be remain queued and task won't run.
Review Comment:
```suggestion
summary: Trigger a new DAG run. If DAG is paused then dagrun state will remain queued, and the task won't run.
```
##########
airflow/cli/cli_config.py:
##########
@@ -1211,7 +1211,9 @@ class GroupCommand(NamedTuple):
),
ActionCommand(
name="trigger",
- help="Trigger a DAG run",
+ help=(
+ "Trigger a DAG run. If DAG is paused then dagrun state would be remain queued and task won't run."
Review Comment:
```suggestion
"Trigger a new DAG run. If DAG is paused then dagrun state will remain queued, and the task won't run."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #32696: Update Dag trigger API and command docs
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #32696:
URL: https://github.com/apache/airflow/pull/32696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org