You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by rajith attapattu <ra...@gmail.com> on 2012/05/16 19:21:53 UTC

Review Request: QPID-4001 Interfaces for QPID API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5151/
-----------------------------------------------------------

Review request for qpid, Robbie Gemmell, Weston Price, Rafael Schloming, and Rob Godfrey.


Summary
-------

As mentioned in the JIRA (and based on offline discussions I had with some folks) it would be good if we can settle down on a set of interfaces for the java version of the Qpid API.
The JMS layer could then be built on top of this, without having to wait until the api implementation is complete.

Implementation possibilities include,
1. A java implementation of this API
2. This acting as a wrapper for the python (via jython) or c++ client

I wonder if we could do something more clever with the Message interface using generics to denote the type of content.
I certainly appreciate feedback and comments :)


This addresses bug QPID-4001.
    https://issues.apache.org/jira/browse/QPID-4001


Diffs
-----

  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/build.deps 1339266 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/build.xml 1339266 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/build.xml PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/Connection.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/Message.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/Receiver.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/Sender.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/Session.java PRE-CREATION 

Diff: https://reviews.apache.org/r/5151/diff


Testing
-------


Thanks,

rajith


Re: Review Request: QPID-4001 Interfaces for QPID API

Posted by rajith attapattu <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5151/
-----------------------------------------------------------

(Updated June 27, 2012, 5:16 p.m.)


Review request for qpid, Robbie Gemmell, Weston Price, Rafael Schloming, and Rob Godfrey.


Changes
-------

Add exceptions classes and message support interfaces.
Used the cpp binding as a platform to improve the API.


Description (updated)
-------

As mentioned in the JIRA (and based on offline discussions I had with some folks) it would be good if we can settle down on a set of interfaces for the java version of the Qpid API.
The JMS layer could then be built on top of this, without having to wait until the api implementation is complete.

Implementation possibilities include,
1. A java implementation of this API
2. This acting as a wrapper for the python (via jython) or c++ client

I wonder if we could do something more clever with the Message interface using generics to denote the type of content.
I certainly appreciate feedback and comments :)


This addresses bug QPID-4001.
    https://issues.apache.org/jira/browse/QPID-4001


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/AddressAssertionFailedException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/AddressException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/AddressNotFoundException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/AddressResolutionException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/Connection.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/ConnectionException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/ConnectionFactory.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/FetchException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/InvalidOptionStringException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/KeyException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/LinkException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/ListMessage.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/MalformedAddressException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/MapMessage.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/Message.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/MessageEncodingException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/MessageFactory.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/MessageNotWritableException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/MessagingException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/NoMessageAvailableException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/Receiver.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/ReceiverException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/SendException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/Sender.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/SenderException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/Session.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/SessionException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/StringMessage.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/TargetCapacityExceededException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/TransactionAbortedException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/TransactionException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/TransportFailureException.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/UnauthorizedAccessException.java PRE-CREATION 

Diff: https://reviews.apache.org/r/5151/diff/


Testing
-------


Thanks,

rajith attapattu


Re: Review Request: QPID-4001 Interfaces for QPID API

Posted by rajith attapattu <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5151/
-----------------------------------------------------------

(Updated 2012-05-17 04:34:35.003307)


Review request for qpid, Robbie Gemmell, Weston Price, Rafael Schloming, and Rob Godfrey.


Summary (updated)
-------

As mentioned in the JIRA (and based on offline discussions I had with some folks) it would be good if we can settle down on a set of interfaces for the java version of the Qpid API.
The JMS layer could then be built on top of this, without having to wait until the api implementation is complete.

Implementation possibilities include,
1. A java implementation of this API
2. This acting as a wrapper for the python (via jython) or c++ client

I wonder if we could do something more clever with the Message interface using generics to denote the type of content.
I certainly appreciate feedback and comments :)

TODO
Exception heirachy.


This addresses bug QPID-4001.
    https://issues.apache.org/jira/browse/QPID-4001


Diffs
-----

  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/build.deps 1339266 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/build.xml 1339266 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/build.xml PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/Connection.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/Message.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/Receiver.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/Sender.java PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client-api/src/main/java/org/apache/qpid/messaging/Session.java PRE-CREATION 

Diff: https://reviews.apache.org/r/5151/diff


Testing
-------


Thanks,

rajith