cvs2svn testsuite - 2 suggestions

[Max Bowsher <ma...@ukf.net>]

1) I'd like to sort the tests based on which cvsrepos they use. Comments?

2) Is there any good reason to check out a working copy of the converted
repository during the tests? If not, I'd like to stop it doing that, to make
the testsuite run quicker.

Max.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: cvs2svn testsuite - 2 suggestions

[Max Bowsher <ma...@ukf.net>]

Peter S. Housel wrote:
> "Max Bowsher" <ma...@ukf.net> wrote:
>> Peter S. Housel wrote:
>>> I haven't looked at the tests, but I hope they're at least running
"svnadmin
>>> verify" on the generated repositories.  If that's being done then there
>>> probably isn't a point in checking out a working copy.
>>
>> No, they are not running svnadmin verify. I'm not sure whether they
should,
>> though.
>>
>> Is it possible for "svnadmin verify" to fail immediately after "svnadmin
>> load" completes successfully? If so, shouldn't svnadmin be fixed?
>
> It's possible, and this has in fact happened to me due to bugs in cvs2svn.
> I suspect it means that there aren't enough checks to make sure that svn
> transactions are internally consistent.

Oh. OK, I will make it start running svnadmin verify as part of
ensure_conversion, and stop checking out wcs (tweaking the tests that use a
wc where necessary.

Max.



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: cvs2svn testsuite - 2 suggestions

["Peter S. Housel" <ho...@acm.org>]

"Max Bowsher" <ma...@ukf.net> wrote:
> Peter S. Housel wrote:
> > I haven't looked at the tests, but I hope they're at least running
> "svnadmin
> > verify" on the generated repositories.  If that's being done then there
> > probably isn't a point in checking out a working copy.
>
> No, they are not running svnadmin verify. I'm not sure whether they
should,
> though.
>
> Is it possible for "svnadmin verify" to fail immediately after "svnadmin
> load" completes successfully? If so, shouldn't svnadmin be fixed?

It's possible, and this has in fact happened to me due to bugs in cvs2svn.
I suspect it means that there aren't enough checks to make sure that svn
transactions are internally consistent.

-Peter-


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: cvs2svn testsuite - 2 suggestions

[Max Bowsher <ma...@ukf.net>]

Peter S. Housel wrote:
> <kf...@collab.net> wrote:
>> "Max Bowsher" <ma...@ukf.net> writes:
>>> 2) Is there any good reason to check out a working copy of the converted
>>> repository during the tests? If not, I'd like to stop it doing that, to
make
>>> the testsuite run quicker.
>>
>> If we're not using them, let's get rid of them.
>
> I haven't looked at the tests, but I hope they're at least running
"svnadmin
> verify" on the generated repositories.  If that's being done then there
> probably isn't a point in checking out a working copy.

No, they are not running svnadmin verify. I'm not sure whether they should,
though.

Is it possible for "svnadmin verify" to fail immediately after "svnadmin
load" completes successfully? If so, shouldn't svnadmin be fixed?

Max.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: cvs2svn testsuite - 2 suggestions

["Peter S. Housel" <ho...@acm.org>]

<kf...@collab.net> wrote:
> "Max Bowsher" <ma...@ukf.net> writes:
> > 2) Is there any good reason to check out a working copy of the converted
> > repository during the tests? If not, I'd like to stop it doing that, to
make
> > the testsuite run quicker.
>
> If we're not using them, let's get rid of them.

I haven't looked at the tests, but I hope they're at least running "svnadmin
verify" on the generated repositories.  If that's being done then there
probably isn't a point in checking out a working copy.

-Peter-


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: cvs2svn testsuite - 2 suggestions

[kf...@collab.net]

"Max Bowsher" <ma...@ukf.net> writes:
> 1) I'd like to sort the tests based on which cvsrepos they use. Comments?

Sounds fine to me!  If there are any issues that refer to a test by
number instead of name, they'll get messed up, but then they should
have been using the name anyway.

> 2) Is there any good reason to check out a working copy of the converted
> repository during the tests? If not, I'd like to stop it doing that, to make
> the testsuite run quicker.

If we're not using them, let's get rid of them.

Thanks!


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org