You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by "Chris A. Mattmann (JIRA)" <ji...@apache.org> on 2011/08/16 06:22:27 UTC
[jira] [Created] (OODT-310) Port WEngine to trunk
Port WEngine to trunk
---------------------
Key: OODT-310
URL: https://issues.apache.org/jira/browse/OODT-310
Project: OODT
Issue Type: New Feature
Components: workflow manager
Reporter: Chris A. Mattmann
Assignee: Chris A. Mattmann
Fix For: 0.4
This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (OODT-310) Port WEngine to trunk
Posted by Cameron Goodale <si...@gmail.com>.
That is great news. At JPL my issue was using a shortcut url for our svn
repo. http://oodt/repo vs. http://oodt.jpl.nasa.gov/repo but the same
basic deal.
-Cameron
On Mon, Aug 6, 2012 at 8:51 PM, Sheryl John <sh...@gmail.com> wrote:
> Thanks Cameron!
> It worked after changing the url to "http".
>
> On Mon, Aug 6, 2012 at 7:43 PM, Cameron Goodale <si...@gmail.com>
> wrote:
>
> > Sheryl,
> >
> > I get the same error on another project using review board. The issue is
> > caused by filling out too much or too little of the base repository url.
> >
> > If/when you get the right combination to work, make note of it or grab a
> > screen shot. It'll help keep your sanity.
> >
> > Cameron
> > On Aug 6, 2012 11:34 AM, "Brian Foster (JIRA)" <ji...@apache.org> wrote:
> >
> > >
> > > [
> > >
> >
> https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429325#comment-13429325
> > ]
> > >
> > > Brian Foster commented on OODT-310:
> > > -----------------------------------
> > >
> > > EngineRunnerFactory additions fixed in r1369914
> > >
> > > > Port WEngine to trunk
> > > > ---------------------
> > > >
> > > > Key: OODT-310
> > > > URL: https://issues.apache.org/jira/browse/OODT-310
> > > > Project: OODT
> > > > Issue Type: Sub-task
> > > > Components: workflow manager
> > > > Reporter: Chris A. Mattmann
> > > > Assignee: Chris A. Mattmann
> > > > Fix For: 0.5
> > > >
> > > > Attachments: OODT-310.2012-08-03.bfoster.patch.txt,
> > > OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt,
> > > OODT-310.sherylj.101711.patch.txt
> > > >
> > > >
> > > > This issue will track the porting of the wengine-branch
> WorkflowEngine
> > > interface and associated classes to trunk. This involves changing to
> the
> > > Processor model (Sequential, Condition, etc.) which has already begun
> (as
> > > of OODT-70), and also the actual Engine implementation itself, that
> > doesn't
> > > block and that includes a queue-based model developed by [~bfoster].
> > >
> > > --
> > > This message is automatically generated by JIRA.
> > > If you think it was sent incorrectly, please contact your JIRA
> > > administrators:
> > >
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> > > For more information on JIRA, see:
> > http://www.atlassian.com/software/jira
> > >
> > >
> > >
> >
>
>
>
> --
> -Sheryl
>
--
Sent from a Tin Can attached to a String
Re: [jira] [Commented] (OODT-310) Port WEngine to trunk
Posted by Sheryl John <sh...@gmail.com>.
Thanks Cameron!
It worked after changing the url to "http".
On Mon, Aug 6, 2012 at 7:43 PM, Cameron Goodale <si...@gmail.com> wrote:
> Sheryl,
>
> I get the same error on another project using review board. The issue is
> caused by filling out too much or too little of the base repository url.
>
> If/when you get the right combination to work, make note of it or grab a
> screen shot. It'll help keep your sanity.
>
> Cameron
> On Aug 6, 2012 11:34 AM, "Brian Foster (JIRA)" <ji...@apache.org> wrote:
>
> >
> > [
> >
> https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429325#comment-13429325
> ]
> >
> > Brian Foster commented on OODT-310:
> > -----------------------------------
> >
> > EngineRunnerFactory additions fixed in r1369914
> >
> > > Port WEngine to trunk
> > > ---------------------
> > >
> > > Key: OODT-310
> > > URL: https://issues.apache.org/jira/browse/OODT-310
> > > Project: OODT
> > > Issue Type: Sub-task
> > > Components: workflow manager
> > > Reporter: Chris A. Mattmann
> > > Assignee: Chris A. Mattmann
> > > Fix For: 0.5
> > >
> > > Attachments: OODT-310.2012-08-03.bfoster.patch.txt,
> > OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt,
> > OODT-310.sherylj.101711.patch.txt
> > >
> > >
> > > This issue will track the porting of the wengine-branch WorkflowEngine
> > interface and associated classes to trunk. This involves changing to the
> > Processor model (Sequential, Condition, etc.) which has already begun (as
> > of OODT-70), and also the actual Engine implementation itself, that
> doesn't
> > block and that includes a queue-based model developed by [~bfoster].
> >
> > --
> > This message is automatically generated by JIRA.
> > If you think it was sent incorrectly, please contact your JIRA
> > administrators:
> > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> > For more information on JIRA, see:
> http://www.atlassian.com/software/jira
> >
> >
> >
>
--
-Sheryl
Re: [jira] [Commented] (OODT-310) Port WEngine to trunk
Posted by Cameron Goodale <si...@gmail.com>.
Sheryl,
I get the same error on another project using review board. The issue is
caused by filling out too much or too little of the base repository url.
If/when you get the right combination to work, make note of it or grab a
screen shot. It'll help keep your sanity.
Cameron
On Aug 6, 2012 11:34 AM, "Brian Foster (JIRA)" <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429325#comment-13429325]
>
> Brian Foster commented on OODT-310:
> -----------------------------------
>
> EngineRunnerFactory additions fixed in r1369914
>
> > Port WEngine to trunk
> > ---------------------
> >
> > Key: OODT-310
> > URL: https://issues.apache.org/jira/browse/OODT-310
> > Project: OODT
> > Issue Type: Sub-task
> > Components: workflow manager
> > Reporter: Chris A. Mattmann
> > Assignee: Chris A. Mattmann
> > Fix For: 0.5
> >
> > Attachments: OODT-310.2012-08-03.bfoster.patch.txt,
> OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt,
> OODT-310.sherylj.101711.patch.txt
> >
> >
> > This issue will track the porting of the wengine-branch WorkflowEngine
> interface and associated classes to trunk. This involves changing to the
> Processor model (Sequential, Condition, etc.) which has already begun (as
> of OODT-70), and also the actual Engine implementation itself, that doesn't
> block and that includes a queue-based model developed by [~bfoster].
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
[jira] [Commented] (OODT-310) Port WEngine to trunk
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266844#comment-13266844 ]
jiraposter@reviews.apache.org commented on OODT-310:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4961/#review7482
-----------------------------------------------------------
like the patch!... few comments
./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java
<https://reviews.apache.org/r/4961/#comment16558>
Why do you want Holding category to be returned?
./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java
<https://reviews.apache.org/r/4961/#comment16556>
This should return a copy of runnableProcessors here... probably where your synchronization issue is
./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java
<https://reviews.apache.org/r/4961/#comment16554>
getRunnableProcessors() is never null... probably should be a unit-test to insure that functionality
./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java
<https://reviews.apache.org/r/4961/#comment16555>
!querier.getRunnableProcessors().isEmpty()
./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java
<https://reviews.apache.org/r/4961/#comment16565>
When Success/done is passed in, the processor created is incorrect since it has a sub-processor in Queued/waiting
./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java
<https://reviews.apache.org/r/4961/#comment16560>
Should probably add a NOT done processor here
- brian
On 2012-05-02 05:08:45, Chris Mattmann wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4961/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-02 05:08:45)
bq.
bq.
bq. Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Sheryl John, and Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Task Querier thread for OODT-310. See javadocs on: https://builds.apache.org/job/oodt-trunk/javadoc/org/apache/oodt/cas/workflow/engine/TaskQuerier.html
bq.
bq.
bq. This addresses bug OODT-310.
bq. https://issues.apache.org/jira/browse/OODT-310
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java 1332505
bq. ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessor.java 1331866
bq. ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4961/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Includes unit test, that currently isn't passing. I think I know why (something up with my threading logic and synchronized keywords) but wanted to throw it up for review. I'll likely be working on this tomorrow or the following evening.
bq.
bq.
bq. Thanks,
bq.
bq. Chris
bq.
bq.
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.5
>
> Attachments: OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-310) Port WEngine to trunk
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris A. Mattmann updated OODT-310:
-----------------------------------
Fix Version/s: (was: 0.5)
0.4
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.4
>
> Attachments: OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OODT-310) Port WEngine to trunk
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris A. Mattmann resolved OODT-310.
------------------------------------
Resolution: Fixed
In the interest of not having umbrella issues for this and to start executing the plan to wrap up Workflow2, I'm closing this issue out. It's mostly done (TaskQuerier, TaskRunner, EngineRunner, etc. etc.) Thanks to everyone who helped!
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.5
>
> Attachments: OODT-310.2012-08-03.bfoster.patch.txt, OODT-310.2012-08-06.sherylj.patch.txt, OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-310) Port WEngine to trunk
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270988#comment-13270988 ]
jiraposter@reviews.apache.org commented on OODT-310:
----------------------------------------------------
bq. On 2012-05-02 19:20:13, brian Foster wrote:
bq. > ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java, line 79
bq. > <https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line79>
bq. >
bq. > When Success/done is passed in, the processor created is incorrect since it has a sub-processor in Queued/waiting
bq.
bq. Chris Mattmann wrote:
bq. Thoughts on how to fix?
bq.
bq. Sheryl John wrote:
bq. If 'anydoneStates'/done is passed, then don't add taskProcessor and return the 'done' processor?
bq.
bq. Chris Mattmann wrote:
bq. Good idea, Sheryl, I will try that.
bq.
bq. brian Foster wrote:
bq. Maybe change getProcessor signature to something along the lines of:
bq.
bq. private WorkflowProcessor getProcessor(String id,
bq. double priority,
bq. String stateName,
bq. String categoryName,
bq. List<WorkflowProcessor> subProcessors);
bq.
bq. Then just make some helper methods which build test WorkflowProcessors... Maybe even make a WorkflowProcessorBuilder class:
bq.
bq. public class WorkflowProcessorBuilder {
bq.
bq. private String id;
bq. private double priority;
bq. private List<WorkflowProcessor> subProcessors;
bq.
bq. private WorkflowProcessorBuilder() {
bq. subProcessors = Lists.newArrayList();
bq. }
bq.
bq. public static WorkflowProcessorBuilder aWorkflowProcessorBuilder() {
bq. return new WorkflowProcessorBuilder();
bq. }
bq.
bq. public WorkflowProcessorBuilder withId(String id) {
bq. this.id = id;
bq. return this;
bq. }
bq.
bq. public WorkflowProcessorBuilder withPriority(double priority) {
bq. this.priority = priority;
bq. return this;
bq. }
bq.
bq. public WorkflowProcessorBuilder with(WorkflowProcessorBuilder wpb) {
bq. subProcessors.add(wpb.build());
bq. return this;
bq. }
bq. ...
bq. ...
bq. ...
bq.
bq. public WorkflowProcessor build() {
bq. WorkflowProcessor wp = new ...
bq. wp.setId(id);
bq. wp.setPriority(priority);
bq. wp.setSubProcessors(subProcessors);
bq. ...
bq. return wp;
bq. }
bq. }
actually:
public static WorkflowProcessorBuilder aWorkflowProcessorBuilder() {
return new WorkflowProcessorBuilder();
}
should be:
public static WorkflowProcessorBuilder aWorkflowProcessor() {
return new WorkflowProcessorBuilder();
}
- brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4961/#review7482
-----------------------------------------------------------
On 2012-05-02 05:08:45, Chris Mattmann wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4961/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-02 05:08:45)
bq.
bq.
bq. Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Sheryl John, and Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Task Querier thread for OODT-310. See javadocs on: https://builds.apache.org/job/oodt-trunk/javadoc/org/apache/oodt/cas/workflow/engine/TaskQuerier.html
bq.
bq.
bq. This addresses bug OODT-310.
bq. https://issues.apache.org/jira/browse/OODT-310
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java 1332505
bq. ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessor.java 1331866
bq. ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4961/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Includes unit test, that currently isn't passing. I think I know why (something up with my threading logic and synchronized keywords) but wanted to throw it up for review. I'll likely be working on this tomorrow or the following evening.
bq.
bq.
bq. Thanks,
bq.
bq. Chris
bq.
bq.
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.5
>
> Attachments: OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-310) Port WEngine to trunk
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris A. Mattmann updated OODT-310:
-----------------------------------
Issue Type: Sub-task (was: New Feature)
Parent: OODT-215
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.4
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-310) Port WEngine to trunk
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268160#comment-13268160 ]
jiraposter@reviews.apache.org commented on OODT-310:
----------------------------------------------------
bq. On 2012-05-02 19:20:13, brian Foster wrote:
bq. > ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java, line 79
bq. > <https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line79>
bq. >
bq. > When Success/done is passed in, the processor created is incorrect since it has a sub-processor in Queued/waiting
bq.
bq. Chris Mattmann wrote:
bq. Thoughts on how to fix?
bq.
bq. Sheryl John wrote:
bq. If 'anydoneStates'/done is passed, then don't add taskProcessor and return the 'done' processor?
Good idea, Sheryl, I will try that.
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4961/#review7482
-----------------------------------------------------------
On 2012-05-02 05:08:45, Chris Mattmann wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4961/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-02 05:08:45)
bq.
bq.
bq. Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Sheryl John, and Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Task Querier thread for OODT-310. See javadocs on: https://builds.apache.org/job/oodt-trunk/javadoc/org/apache/oodt/cas/workflow/engine/TaskQuerier.html
bq.
bq.
bq. This addresses bug OODT-310.
bq. https://issues.apache.org/jira/browse/OODT-310
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java 1332505
bq. ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessor.java 1331866
bq. ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4961/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Includes unit test, that currently isn't passing. I think I know why (something up with my threading logic and synchronized keywords) but wanted to throw it up for review. I'll likely be working on this tomorrow or the following evening.
bq.
bq.
bq. Thanks,
bq.
bq. Chris
bq.
bq.
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.5
>
> Attachments: OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-310) Port WEngine to trunk
Posted by "Chris A. Mattmann (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202094#comment-13202094 ]
Chris A. Mattmann commented on OODT-310:
----------------------------------------
Committed Sheryl's unit tests in r1241352. Going to try and wrap up the code for WEngine this week. Wish me luck!
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.4
>
> Attachments: OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-310) Port WEngine to trunk
Posted by "Brian Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Foster updated OODT-310:
------------------------------
Attachment: OODT-310.2012-08-03.bfoster.patch.txt
- attached patch
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.5
>
> Attachments: OODT-310.2012-08-03.bfoster.patch.txt, OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-310) Port WEngine to trunk
Posted by "Brian Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428434#comment-13428434 ]
Brian Foster commented on OODT-310:
-----------------------------------
EngineRunnerFactory additions can be reviewed here: https://reviews.apache.org/r/6357/
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.5
>
> Attachments: OODT-310.2012-08-03.bfoster.patch.txt, OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-310) Port WEngine to trunk
Posted by "Brian Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429325#comment-13429325 ]
Brian Foster commented on OODT-310:
-----------------------------------
EngineRunnerFactory additions fixed in r1369914
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.5
>
> Attachments: OODT-310.2012-08-03.bfoster.patch.txt, OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-310) Port WEngine to trunk
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270981#comment-13270981 ]
jiraposter@reviews.apache.org commented on OODT-310:
----------------------------------------------------
bq. On 2012-05-02 19:20:13, brian Foster wrote:
bq. > ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java, line 79
bq. > <https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line79>
bq. >
bq. > When Success/done is passed in, the processor created is incorrect since it has a sub-processor in Queued/waiting
bq.
bq. Chris Mattmann wrote:
bq. Thoughts on how to fix?
bq.
bq. Sheryl John wrote:
bq. If 'anydoneStates'/done is passed, then don't add taskProcessor and return the 'done' processor?
bq.
bq. Chris Mattmann wrote:
bq. Good idea, Sheryl, I will try that.
Maybe change getProcessor signature to something along the lines of:
private WorkflowProcessor getProcessor(String id,
double priority,
String stateName,
String categoryName,
List<WorkflowProcessor> subProcessors);
Then just make some helper methods which build test WorkflowProcessors... Maybe even make a WorkflowProcessorBuilder class:
public class WorkflowProcessorBuilder {
private String id;
private double priority;
private List<WorkflowProcessor> subProcessors;
private WorkflowProcessorBuilder() {
subProcessors = Lists.newArrayList();
}
public static WorkflowProcessorBuilder aWorkflowProcessorBuilder() {
return new WorkflowProcessorBuilder();
}
public WorkflowProcessorBuilder withId(String id) {
this.id = id;
return this;
}
public WorkflowProcessorBuilder withPriority(double priority) {
this.priority = priority;
return this;
}
public WorkflowProcessorBuilder with(WorkflowProcessorBuilder wpb) {
subProcessors.add(wpb.build());
return this;
}
...
...
...
public WorkflowProcessor build() {
WorkflowProcessor wp = new ...
wp.setId(id);
wp.setPriority(priority);
wp.setSubProcessors(subProcessors);
...
return wp;
}
}
- brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4961/#review7482
-----------------------------------------------------------
On 2012-05-02 05:08:45, Chris Mattmann wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4961/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-02 05:08:45)
bq.
bq.
bq. Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Sheryl John, and Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Task Querier thread for OODT-310. See javadocs on: https://builds.apache.org/job/oodt-trunk/javadoc/org/apache/oodt/cas/workflow/engine/TaskQuerier.html
bq.
bq.
bq. This addresses bug OODT-310.
bq. https://issues.apache.org/jira/browse/OODT-310
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java 1332505
bq. ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessor.java 1331866
bq. ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4961/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Includes unit test, that currently isn't passing. I think I know why (something up with my threading logic and synchronized keywords) but wanted to throw it up for review. I'll likely be working on this tomorrow or the following evening.
bq.
bq.
bq. Thanks,
bq.
bq. Chris
bq.
bq.
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.5
>
> Attachments: OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-310) Port WEngine to trunk
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266350#comment-13266350 ]
jiraposter@reviews.apache.org commented on OODT-310:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4961/
-----------------------------------------------------------
Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Sheryl John, and Thomas Bennett.
Summary
-------
Task Querier thread for OODT-310. See javadocs on: https://builds.apache.org/job/oodt-trunk/javadoc/org/apache/oodt/cas/workflow/engine/TaskQuerier.html
This addresses bug OODT-310.
https://issues.apache.org/jira/browse/OODT-310
Diffs
-----
./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java 1332505
./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessor.java 1331866
./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java PRE-CREATION
Diff: https://reviews.apache.org/r/4961/diff
Testing
-------
Includes unit test, that currently isn't passing. I think I know why (something up with my threading logic and synchronized keywords) but wanted to throw it up for review. I'll likely be working on this tomorrow or the following evening.
Thanks,
Chris
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.5
>
> Attachments: OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-310) Port WEngine to trunk
Posted by "Sheryl John (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sheryl John updated OODT-310:
-----------------------------
Attachment: OODT-310.sherylj.101711.patch.txt
- Added unit test TestXmlRpcWorkflowManager.java
- Test to see if workflow instance is created after starting off workflow manager
- Currently, test fails as the lucene repository is not being created and hence, no instance is recorded.
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.4
>
> Attachments: OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-310) Port WEngine to trunk
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266928#comment-13266928 ]
jiraposter@reviews.apache.org commented on OODT-310:
----------------------------------------------------
bq. On 2012-05-02 19:20:13, brian Foster wrote:
bq. > ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java, line 89
bq. > <https://reviews.apache.org/r/4961/diff/1/?file=105930#file105930line89>
bq. >
bq. > Why do you want Holding category to be returned?
good question I messed that up. Should be !(processor.getState().getCategory().getName().equals("done") || processor.getState().getCategory().getName().equals("holding")) IOW not either of those.
Fixed in latest version. Will upload soon.
bq. On 2012-05-02 19:20:13, brian Foster wrote:
bq. > ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java, line 130
bq. > <https://reviews.apache.org/r/4961/diff/1/?file=105930#file105930line130>
bq. >
bq. > This should return a copy of runnableProcessors here... probably where your synchronization issue is
PERFECT idea! Thanks dude.
bq. On 2012-05-02 19:20:13, brian Foster wrote:
bq. > ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java, line 60
bq. > <https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line60>
bq. >
bq. > getRunnableProcessors() is never null... probably should be a unit-test to insure that functionality
Agreed. Will add.
bq. On 2012-05-02 19:20:13, brian Foster wrote:
bq. > ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java, line 61
bq. > <https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line61>
bq. >
bq. > !querier.getRunnableProcessors().isEmpty()
yep better idea.
bq. On 2012-05-02 19:20:13, brian Foster wrote:
bq. > ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java, line 79
bq. > <https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line79>
bq. >
bq. > When Success/done is passed in, the processor created is incorrect since it has a sub-processor in Queued/waiting
Thoughts on how to fix?
bq. On 2012-05-02 19:20:13, brian Foster wrote:
bq. > ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java, line 125
bq. > <https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line125>
bq. >
bq. > Should probably add a NOT done processor here
Yep good idea. Will add.
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4961/#review7482
-----------------------------------------------------------
On 2012-05-02 05:08:45, Chris Mattmann wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4961/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-02 05:08:45)
bq.
bq.
bq. Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Sheryl John, and Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Task Querier thread for OODT-310. See javadocs on: https://builds.apache.org/job/oodt-trunk/javadoc/org/apache/oodt/cas/workflow/engine/TaskQuerier.html
bq.
bq.
bq. This addresses bug OODT-310.
bq. https://issues.apache.org/jira/browse/OODT-310
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java 1332505
bq. ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessor.java 1331866
bq. ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4961/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Includes unit test, that currently isn't passing. I think I know why (something up with my threading logic and synchronized keywords) but wanted to throw it up for review. I'll likely be working on this tomorrow or the following evening.
bq.
bq.
bq. Thanks,
bq.
bq. Chris
bq.
bq.
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.5
>
> Attachments: OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-310) Port WEngine to trunk
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268128#comment-13268128 ]
jiraposter@reviews.apache.org commented on OODT-310:
----------------------------------------------------
bq. On 2012-05-02 19:20:13, brian Foster wrote:
bq. > ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java, line 79
bq. > <https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line79>
bq. >
bq. > When Success/done is passed in, the processor created is incorrect since it has a sub-processor in Queued/waiting
bq.
bq. Chris Mattmann wrote:
bq. Thoughts on how to fix?
If 'anydoneStates'/done is passed, then don't add taskProcessor and return the 'done' processor?
- Sheryl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4961/#review7482
-----------------------------------------------------------
On 2012-05-02 05:08:45, Chris Mattmann wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4961/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-02 05:08:45)
bq.
bq.
bq. Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Sheryl John, and Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Task Querier thread for OODT-310. See javadocs on: https://builds.apache.org/job/oodt-trunk/javadoc/org/apache/oodt/cas/workflow/engine/TaskQuerier.html
bq.
bq.
bq. This addresses bug OODT-310.
bq. https://issues.apache.org/jira/browse/OODT-310
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java 1332505
bq. ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/WorkflowProcessor.java 1331866
bq. ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4961/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Includes unit test, that currently isn't passing. I think I know why (something up with my threading logic and synchronized keywords) but wanted to throw it up for review. I'll likely be working on this tomorrow or the following evening.
bq.
bq.
bq. Thanks,
bq.
bq. Chris
bq.
bq.
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.5
>
> Attachments: OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-310) Port WEngine to trunk
Posted by "Sheryl John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sheryl John updated OODT-310:
-----------------------------
Attachment: OODT-310.2012-08-06.sherylj.patch.txt
TestXmlRpcWorkflowManager JUnit test pass. Also able to kick off wmgr with no exceptions.
I tried uploading the diff to ReviewBoard, but I get this weird message:
The file "https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java" (revision 1370097) was not found in the repository
I'll try uploading the diff again from another machine.
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.5
>
> Attachments: OODT-310.2012-08-03.bfoster.patch.txt, OODT-310.2012-08-06.sherylj.patch.txt, OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-310) Port WEngine to trunk
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris A. Mattmann updated OODT-310:
-----------------------------------
Attachment: OODT-310.Mattmann.082311.patch.txt
- initial patch that begins to port the priority based sorting and stub for the PrioritizedQueueWorkflowEngine to trunk. Comments welcome.
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.4
>
> Attachments: OODT-310.Mattmann.082311.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-310) Port WEngine to trunk
Posted by "Chris A. Mattmann (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris A. Mattmann updated OODT-310:
-----------------------------------
Attachment: OODT-310.Mattmann.100911.patch.txt
- doesn't fully work (though it compiles) but gives you an idea of where I'm headed. I'm going to break off the Runner framework into its own issue and include separate unit tests for those.
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.4
>
> Attachments: OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-310) Port WEngine to trunk
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris A. Mattmann updated OODT-310:
-----------------------------------
Fix Version/s: (was: 0.4)
0.5
> Port WEngine to trunk
> ---------------------
>
> Key: OODT-310
> URL: https://issues.apache.org/jira/browse/OODT-310
> Project: OODT
> Issue Type: Sub-task
> Components: workflow manager
> Reporter: Chris A. Mattmann
> Assignee: Chris A. Mattmann
> Fix For: 0.5
>
> Attachments: OODT-310.Mattmann.082311.patch.txt, OODT-310.Mattmann.100911.patch.txt, OODT-310.sherylj.101711.patch.txt
>
>
> This issue will track the porting of the wengine-branch WorkflowEngine interface and associated classes to trunk. This involves changing to the Processor model (Sequential, Condition, etc.) which has already begun (as of OODT-70), and also the actual Engine implementation itself, that doesn't block and that includes a queue-based model developed by [~bfoster].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira