You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by jm...@apache.org on 2022/07/14 23:26:12 UTC

[datasketches-cpp] branch master updated: remove pip as a build-system dependency in pyproject.toml

This is an automated email from the ASF dual-hosted git repository.

jmalkin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/datasketches-cpp.git


The following commit(s) were added to refs/heads/master by this push:
     new 6a9aa64  remove pip as a build-system dependency in pyproject.toml
     new 818e3ba  Merge pull request #293 from jamie256/dev/jamie/windows_ci
6a9aa64 is described below

commit 6a9aa6447de4f594dbc9dbe6ab79821e0ecf398e
Author: Jamie Broomall <ja...@whylabs.ai>
AuthorDate: Thu Jul 14 15:39:00 2022 -0700

    remove pip as a build-system dependency in pyproject.toml
---
 pyproject.toml          | 1 -
 python/README.md        | 2 +-
 python/pybind11Path.cmd | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/pyproject.toml b/pyproject.toml
index 4474058..5bcf6b7 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -2,7 +2,6 @@
 requires = ["wheel",
             "setuptools >= 30.3.0",
             "cmake >= 3.16",
-            "pip >= 10.0",
             "pybind11[global] >= 2.6.0"]
 build-backend = "setuptools.build_meta"
 
diff --git a/python/README.md b/python/README.md
index cdd0a98..82f267d 100644
--- a/python/README.md
+++ b/python/README.md
@@ -76,7 +76,7 @@ The only developer-specific instructions relate to running unit tests.
 
 ### Unit tests
 
-The Python unit tests are run via `tox`, with no arguments, from the project root directory -- not the python subdirectory. Tox creates a temporary virtual environment in which to build and run teh unit tests. In the event you are missing the necessary pacakge, tox may be installed with `python3 -m pip install --upgrade tox`.
+The Python unit tests are run via `tox`, with no arguments, from the project root directory -- not the python subdirectory. Tox creates a temporary virtual environment in which to build and run the unit tests. In the event you are missing the necessary pacakge, tox may be installed with `python3 -m pip install --upgrade tox`.
 
 ## License
 
diff --git a/python/pybind11Path.cmd b/python/pybind11Path.cmd
index 650625b..e07f0b5 100644
--- a/python/pybind11Path.cmd
+++ b/python/pybind11Path.cmd
@@ -1,3 +1,3 @@
 @echo off
 :: Takes path to the Python interpreter and returns the path to pybind11
-%1 -m pip show pybind11 | %1 -c "import sys,re;[sys.stdout.write(re.sub('^Location:\\s+','',line)) for line in sys.stdin if re.search('^Location:\\s+',line)]"
+%1 -c "import pybind11,sys;sys.stdout.write(pybind11.get_cmake_dir())"
\ No newline at end of file


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org