You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/15 13:39:42 UTC
[GitHub] [airflow] nathadfield opened a new pull request #9832: BigQueryTableExistenceSensor needs to specify keyword arguments
nathadfield opened a new pull request #9832:
URL: https://github.com/apache/airflow/pull/9832
Currently the BigQueryTableExistenceSensor in `providers` fails due to requirements to specify keyword rather than positional arguments. #9830
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nathadfield commented on pull request #9832: BigQueryTableExistenceSensor needs to specify keyword arguments
Posted by GitBox <gi...@apache.org>.
nathadfield commented on pull request #9832:
URL: https://github.com/apache/airflow/pull/9832#issuecomment-658823509
@turbaszek There are tests for `hook.table_exists` that call it properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #9832: BigQueryTableExistenceSensor needs to specify keyword arguments
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #9832:
URL: https://github.com/apache/airflow/pull/9832#issuecomment-658819983
@nathadfield good catch! Please adjust the tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #9832: BigQueryTableExistenceSensor needs to specify keyword arguments
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #9832:
URL: https://github.com/apache/airflow/pull/9832
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nathadfield edited a comment on pull request #9832: BigQueryTableExistenceSensor needs to specify keyword arguments
Posted by GitBox <gi...@apache.org>.
nathadfield edited a comment on pull request #9832:
URL: https://github.com/apache/airflow/pull/9832#issuecomment-658823509
@turbaszek There are tests for `hook.table_exists` that call it properly.
https://github.com/apache/airflow/blob/master/tests/providers/google/cloud/hooks/test_bigquery.py#L105
Were you thinking of something extra?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nathadfield commented on pull request #9832: BigQueryTableExistenceSensor needs to specify keyword arguments
Posted by GitBox <gi...@apache.org>.
nathadfield commented on pull request #9832:
URL: https://github.com/apache/airflow/pull/9832#issuecomment-658827487
Nevermind. I see what you're referring to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nathadfield commented on pull request #9832: BigQueryTableExistenceSensor needs to specify keyword arguments
Posted by GitBox <gi...@apache.org>.
nathadfield commented on pull request #9832:
URL: https://github.com/apache/airflow/pull/9832#issuecomment-658879246
Test updated and all checks have now passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org