You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2011/08/17 01:39:59 UTC
[Bug 6651] New: SCORE tag is no longer padded
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6651
Bug #: 6651
Summary: SCORE tag is no longer padded
Product: Spamassassin
Version: 3.3.2
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Libraries
AssignedTo: dev@spamassassin.apache.org
ReportedBy: bruce@untroubled.org
Classification: Unclassified
My prefs contains the following directive:
rewrite_header Subject SPAM _SCORE(0)_
With version 3.3.1 and prior, this produced a score padded to (at least) 2
digits before the decimal place. With version 3.3.2 this padding no longer
happens.
Reverting commit 966355 (Bug 6419 patch commit to resolve rounding issue
irregularity with spamd/spamc) on top of trunk fixes the problem.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6651] SCORE tag is no longer padded
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6651
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@pccc.com
--- Comment #1 from Kevin A. McGrail <km...@pccc.com> 2011-08-17 18:29:13 UTC ---
This change was by design to unify the numerous places where scores were
padded/rounded/etc.
What does the lack of padding break?
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6651] SCORE tag is no longer padded
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6651
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.4.0
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6651] SCORE tag is no longer padded
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6651
--- Comment #3 from Kevin A. McGrail <km...@pccc.com> 2011-08-17 18:35:53 UTC ---
(In reply to comment #2)
> If there is an alternate method of doing padding, I would gladly use it, but
> the documentation still refers to _SCORE(PAD)_ which no longer works.
>
> The lack of padding breaks sorting by spam score in mail clients that don't
> automagically sort by number, since 10 sorts lower than 2-9 etc.
Thanks for the good explanation. I'll look into this bug more and consider it
valid.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6651] SCORE tag is no longer padded
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6651
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #5 from Kevin A. McGrail <km...@pccc.com> 2011-12-07 22:23:24 UTC ---
(In reply to comment #4)
> Created attachment 5016 [details]
> Proposed fix
>
> The attached patch fixes the problem for me. The actual padding code is reused
> from the previous version of PerMsgStatus.pm.
You answered the question of the $pad param still being used. I forget about
the _SCORE(pad)_ tag and I assumed you meant the padding changed on the score
because of all the revisions to unify rounding, etc.
You are right that this should be reverted and documented and will get it done
shortly.
svn commit -m 'reverting to previous padding for scores bug 6651 specifically
for _SCORE(pad)_ tag' lib/Mail/SpamAssassin/PerMsgStatus.pm
Sending lib/Mail/SpamAssassin/PerMsgStatus.pm
Transmitting file data .
Committed revision 1211678.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6651] SCORE tag is no longer padded
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6651
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kivinen@iki.fi
--- Comment #6 from Kevin A. McGrail <km...@pccc.com> ---
*** Bug 6902 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6651] SCORE tag is no longer padded
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6651
--- Comment #4 from Bruce Guenter <br...@untroubled.org> 2011-12-07 21:31:20 UTC ---
Created attachment 5016
--> https://issues.apache.org/SpamAssassin/attachment.cgi?id=5016
Proposed fix
The attached patch fixes the problem for me. The actual padding code is reused
from the previous version of PerMsgStatus.pm.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6651] SCORE tag is no longer padded
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6651
Bruce Guenter <br...@untroubled.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bruce@untroubled.org
--- Comment #2 from Bruce Guenter <br...@untroubled.org> 2011-08-17 18:33:20 UTC ---
If there is an alternate method of doing padding, I would gladly use it, but
the documentation still refers to _SCORE(PAD)_ which no longer works.
The lack of padding breaks sorting by spam score in mail clients that don't
automagically sort by number, since 10 sorts lower than 2-9 etc.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.