You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "yamt (via GitHub)" <gi...@apache.org> on 2023/03/03 14:58:57 UTC
[GitHub] [nuttx-apps] yamt opened a new pull request, #1617: interpreter/toywasm: Update toywasm version
yamt opened a new pull request, #1617:
URL: https://github.com/apache/nuttx-apps/pull/1617
## Summary
interpreter/toywasm: Update toywasm version
## Impact
## Testing
Tested on esp32-devkitc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] yamt commented on pull request #1617: interpreter/toywasm: Update toywasm version
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on PR #1617:
URL: https://github.com/apache/nuttx-apps/pull/1617#issuecomment-1453993867
> let's squash the second patch into the first one.
i'm not inclined to do so because the file in the first commit is a copy of machine-generated file and the second commit is a manual edit to appease nxstyle.
(while IMO there is no point to run nxstyle on these files, i don't have a better solution right now.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1617: interpreter/toywasm: Update toywasm version
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #1617:
URL: https://github.com/apache/nuttx-apps/pull/1617#issuecomment-1454430344
If so, it's better to update the script to generate the code in the well format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1617: interpreter/toywasm: Update toywasm version
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #1617:
URL: https://github.com/apache/nuttx-apps/pull/1617#issuecomment-1454680019
> > If so, it's better to update the script to generate the code in the well format.
>
> in future, maybe. it's sad nxstyle doesn't have an auto formatting tool.
So, you have to sqaush the patch manually now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] yamt commented on pull request #1617: interpreter/toywasm: Update toywasm version
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on PR #1617:
URL: https://github.com/apache/nuttx-apps/pull/1617#issuecomment-1460270348
> > > If so, it's better to update the script to generate the code in the well format.
> >
> >
> > in future, maybe. it's sad nxstyle doesn't have an auto formatting tool.
>
> So, you have to sqaush the patch manually now.
i still prefer not to squash. but i will.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1617: interpreter/toywasm: Update toywasm version
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #1617:
URL: https://github.com/apache/nuttx-apps/pull/1617#issuecomment-1453878318
let's squash the second patch into the first one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1617: interpreter/toywasm: Update toywasm version
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #1617:
URL: https://github.com/apache/nuttx-apps/pull/1617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] yamt commented on pull request #1617: interpreter/toywasm: Update toywasm version
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on PR #1617:
URL: https://github.com/apache/nuttx-apps/pull/1617#issuecomment-1460271394
> > > > If so, it's better to update the script to generate the code in the well format.
> > >
> > >
> > > in future, maybe. it's sad nxstyle doesn't have an auto formatting tool.
> >
> >
> > So, you have to sqaush the patch manually now.
>
> i still prefer not to squash. but i will.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] yamt commented on pull request #1617: interpreter/toywasm: Update toywasm version
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on PR #1617:
URL: https://github.com/apache/nuttx-apps/pull/1617#issuecomment-1454669575
> If so, it's better to update the script to generate the code in the well format.
in future, maybe.
it's sad nxstyle doesn't have an auto formatting tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org