[GitHub] [incubator-superset] villebro commented on a change in pull request #8164: [sqllab] More detailed async error messages for sqllab

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #8164: [sqllab] More detailed async error messages for sqllab
URL: https://github.com/apache/incubator-superset/pull/8164#discussion_r321075341
 
 

 ##########
 File path: superset/db_engine_specs/hive.py
 ##########
 @@ -200,7 +200,7 @@ def extract_error_message(cls, e):
         match = re.search(r'errorMessage="(.*?)(?<!\\)"', msg)
         if match:
             msg = match.group(1)
-        return msg
+        return f"Hive error: {msg}"
 
 Review comment:
   I would much prefer to see this in `base.py` along the lines of `f"{self.engine} error: {msg}"` for uniformity and only the engine-specific message extraction logic where necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org