You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2005/10/06 05:54:12 UTC

[jira] Created: (MNG-1101) release pom, and next version, is missing pieces of pom

release pom, and next version, is missing pieces of pom
-------------------------------------------------------

         Key: MNG-1101
         URL: http://jira.codehaus.org/browse/MNG-1101
     Project: Maven 2
        Type: Bug
  Components: maven-release-plugin  
 Reporter: Brett Porter
     Fix For: 2.0-beta-4


eg, exclusions and reporting get removed. seems it could be something in clone model?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1101) release pom, and next version, is missing pieces of pom

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1101?page=comments#action_48925 ] 

John Casey commented on MNG-1101:
---------------------------------

Brett, I see what you mean. It will effectively negate any version ranges as soon as the artifact is released. I think it's enough to have the fully resolved POM in the artifact and in the release-tag in SCM.

I'll start working in this direction.

> release pom, and next version, is missing pieces of pom
> -------------------------------------------------------
>
>          Key: MNG-1101
>          URL: http://jira.codehaus.org/browse/MNG-1101
>      Project: Maven 2
>         Type: Bug
>   Components: maven-release-plugin
>     Reporter: Brett Porter
>     Assignee: John Casey
>      Fix For: 2.0

>
>
> eg, exclusions and reporting get removed. seems it could be something in clone model?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1101) release pom, and next version, is missing pieces of pom

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1101?page=comments#action_49707 ] 

John Casey commented on MNG-1101:
---------------------------------

it's set to warn if you try to release:perform with release-pom.xml, but it will allow deploying the release with non-standard POM files now. If you try to use release-pom.xml, it will warn and prompt you to change your mind.

Also, exclusions, systemPath, and optional settings are now propagated to the release-pom.xml.

> release pom, and next version, is missing pieces of pom
> -------------------------------------------------------
>
>          Key: MNG-1101
>          URL: http://jira.codehaus.org/browse/MNG-1101
>      Project: Maven 2
>         Type: Bug
>   Components: maven-release-plugin
>     Reporter: Brett Porter
>     Assignee: John Casey
>      Fix For: 2.0.1

>
> Original Estimate: 1 hour
>        Time Spent: 2 hours
>         Remaining: 0 minutes
>
> eg, exclusions and reporting get removed. seems it could be something in clone model?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MNG-1101) release pom, and next version, is missing pieces of pom

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-1101?page=all ]
     
John Casey closed MNG-1101:
---------------------------

    Resolution: Fixed

> release pom, and next version, is missing pieces of pom
> -------------------------------------------------------
>
>          Key: MNG-1101
>          URL: http://jira.codehaus.org/browse/MNG-1101
>      Project: Maven 2
>         Type: Bug
>   Components: maven-release-plugin
>     Reporter: Brett Porter
>     Assignee: John Casey
>      Fix For: 2.0.1

>
> Original Estimate: 1 hour
>        Time Spent: 2 hours
>         Remaining: 0 minutes
>
> eg, exclusions and reporting get removed. seems it could be something in clone model?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1101) release pom, and next version, is missing pieces of pom

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1101?page=comments#action_48627 ] 

Brett Porter commented on MNG-1101:
-----------------------------------

I'm starting to think we ditch the idea of a fully resolved pom.

How about just resolving the versions into release-pom.xml?

The only other advantage is the super POM. I think we can tie that to modelVersion.

Thoughts?

> release pom, and next version, is missing pieces of pom
> -------------------------------------------------------
>
>          Key: MNG-1101
>          URL: http://jira.codehaus.org/browse/MNG-1101
>      Project: Maven 2
>         Type: Bug
>   Components: maven-release-plugin
>     Reporter: Brett Porter
>     Assignee: John Casey
>      Fix For: 2.0

>
>
> eg, exclusions and reporting get removed. seems it could be something in clone model?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1101) release pom, and next version, is missing pieces of pom

Posted by "Arik Kfir (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1101?page=comments#action_48463 ] 

Arik Kfir commented on MNG-1101:
--------------------------------

I also noticed that plugin-configuration for the 'release' plugin gets wiped as well. I have this section in the pom which is always removed from the next-dev version:
            <plugin>
                <artifactId>maven-release-plugin</artifactId>
                <inherited>false</inherited>
                <configuration>
                    <tagBase>http://www.someserver.com/svn/proj/tags</tagBase>
                </configuration>
            </plugin>

However - other plugin configurations remain intact...umm....?

> release pom, and next version, is missing pieces of pom
> -------------------------------------------------------
>
>          Key: MNG-1101
>          URL: http://jira.codehaus.org/browse/MNG-1101
>      Project: Maven 2
>         Type: Bug
>   Components: maven-release-plugin
>     Reporter: Brett Porter
>      Fix For: 2.0-beta-4

>
>
> eg, exclusions and reporting get removed. seems it could be something in clone model?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1101) release pom, and next version, is missing pieces of pom

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1101?page=comments#action_48665 ] 

Brett Porter commented on MNG-1101:
-----------------------------------

ok, we definitely need to do this.

the release pom is also what is deployed to the repo, so wiping out dep mgmt and resolving profiles (Which is currently done deliberately) is not desired.

We need to:
- keep the original model in tact, relying on deterministic inheritence to work as is
- resolve variables (interpolation), as that is affected by runtime
- leave all profiles in, but mark the ones used as active by default, I assume (more investigation needed)

How does this sound?

> release pom, and next version, is missing pieces of pom
> -------------------------------------------------------
>
>          Key: MNG-1101
>          URL: http://jira.codehaus.org/browse/MNG-1101
>      Project: Maven 2
>         Type: Bug
>   Components: maven-release-plugin
>     Reporter: Brett Porter
>     Assignee: John Casey
>      Fix For: 2.0

>
>
> eg, exclusions and reporting get removed. seems it could be something in clone model?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1101) release pom, and next version, is missing pieces of pom

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1101?page=comments#action_48666 ] 

Brett Porter commented on MNG-1101:
-----------------------------------

continuing thinking out loud...

I'm not sure we want to resolve versions for a repository pom. The patterns are important. So if commons-beanutils can work with logging 1.0+ and was released against 1.1, then your tree should get 1.0+, not 1.1

So maybe what we want here is an untouched copy going to the repo, and release-pom fully resolved as before but without the bugs.

... certainly warrants more discussion

> release pom, and next version, is missing pieces of pom
> -------------------------------------------------------
>
>          Key: MNG-1101
>          URL: http://jira.codehaus.org/browse/MNG-1101
>      Project: Maven 2
>         Type: Bug
>   Components: maven-release-plugin
>     Reporter: Brett Porter
>     Assignee: John Casey
>      Fix For: 2.0

>
>
> eg, exclusions and reporting get removed. seems it could be something in clone model?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1101) release pom, and next version, is missing pieces of pom

Posted by "Arik Kfir (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1101?page=comments#action_48630 ] 

Arik Kfir commented on MNG-1101:
--------------------------------

you mean that 'deploy' will store the pom as it is, with only the version changed to the release version? If it saves you maintaining cloning-code - I'm all for it! :)

> release pom, and next version, is missing pieces of pom
> -------------------------------------------------------
>
>          Key: MNG-1101
>          URL: http://jira.codehaus.org/browse/MNG-1101
>      Project: Maven 2
>         Type: Bug
>   Components: maven-release-plugin
>     Reporter: Brett Porter
>     Assignee: John Casey
>      Fix For: 2.0

>
>
> eg, exclusions and reporting get removed. seems it could be something in clone model?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1101) release pom, and next version, is missing pieces of pom

Posted by "Arik Kfir (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1101?page=comments#action_48668 ] 

Arik Kfir commented on MNG-1101:
--------------------------------

That depends - which one will be used, and when? 

If I release project A, I have "A.pom" and "release-A.pom" in the repo. 
Now I create project B which uses A - would m2 use the "release-A.pom" or the standard (untouched) "A.pom"?


> release pom, and next version, is missing pieces of pom
> -------------------------------------------------------
>
>          Key: MNG-1101
>          URL: http://jira.codehaus.org/browse/MNG-1101
>      Project: Maven 2
>         Type: Bug
>   Components: maven-release-plugin
>     Reporter: Brett Porter
>     Assignee: John Casey
>      Fix For: 2.0

>
>
> eg, exclusions and reporting get removed. seems it could be something in clone model?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-1101) release pom, and next version, is missing pieces of pom

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-1101?page=all ]

John Casey updated MNG-1101:
----------------------------

    Remaining Estimate: 1 hour
     Original Estimate: 3600

may have to rework the jar plugin as well, if we want the fully resolved POM in the artifact.

I'll probably start by leaving that out. The POM in the artifact will - at least initially - be the untouched, unresolved version.

> release pom, and next version, is missing pieces of pom
> -------------------------------------------------------
>
>          Key: MNG-1101
>          URL: http://jira.codehaus.org/browse/MNG-1101
>      Project: Maven 2
>         Type: Bug
>   Components: maven-release-plugin
>     Reporter: Brett Porter
>     Assignee: John Casey
>      Fix For: 2.0

>
> Original Estimate: 1 hour
>         Remaining: 1 hour
>
> eg, exclusions and reporting get removed. seems it could be something in clone model?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org