You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/07/24 02:40:12 UTC

[GitHub] [incubator-dolphinscheduler] shi-hailong opened a new pull request #3296: Update dolphinscheduler.conf

shi-hailong opened a new pull request #3296:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3296


   /ui下的资源访问不应该发送到api-server
   
   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds checkstyle plugin.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Add maven-checkstyle-plugin to root pom.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added dolphinscheduler-dao tests for end-to-end.*
     - *Added CronUtilsTest to verify the change.*
     - *Manually verified the change by testing locally.*
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] felix-thinkingdata commented on pull request #3296: Update dolphinscheduler.conf

Posted by GitBox <gi...@apache.org>.
felix-thinkingdata commented on pull request #3296:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3296#issuecomment-663329878


   > @shi-hailong Please resolve Unit Test failed
   
    UT MODULE  gc problem,Refer to this solution #3264，Comment out those GC problem tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #3296: [Feature-docker][ui] Update dolphinscheduler.conf

Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #3296:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3296#issuecomment-663423337


   > @shi-hailong Please resolve Unit Test failed
   
   this is not his problem,he just change nginx config


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #3296: [Feature-docker][ui] Update dolphinscheduler.conf

Posted by GitBox <gi...@apache.org>.
dailidong merged pull request #3296:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3296


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] gabrywu commented on pull request #3296: Update dolphinscheduler.conf

Posted by GitBox <gi...@apache.org>.
gabrywu commented on pull request #3296:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3296#issuecomment-663327933


   @shi-hailong Please resolve Unit Test failed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #3296: [Feature-docker][ui] Update dolphinscheduler.conf

Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #3296:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3296#issuecomment-663455534


   thanks for your first contribution, looking forward to your next contribution, if you need any help, please send mail to dev@dolphinscheduler.apache.org or contact my wechat(510570367), when added, please tell me your github id, thx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org