You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2016/06/30 22:20:46 UTC

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3811: skip test sequence file filtering race against release builds 

Michael Brown has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3545

Change subject: IMPALA-3811: skip test_sequence_file_filtering_race against release builds
......................................................................

IMPALA-3811: skip test_sequence_file_filtering_race against release builds

The test_sequence_file_filtering_race test relies on a special Impala
option that is only available in debug builds. The test needs to be
skipped when running against release builds.

Change-Id: I3260fdb60b0d95551aae56e01c5318365efc248a
---
M tests/custom_cluster/test_seq_file_filtering.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/45/3545/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3260fdb60b0d95551aae56e01c5318365efc248a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3811: skip test sequence file filtering race against release builds

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has submitted this change and it was merged.

Change subject: IMPALA-3811: skip test_sequence_file_filtering_race against release builds
......................................................................


IMPALA-3811: skip test_sequence_file_filtering_race against release builds

The test_sequence_file_filtering_race test relies on a special Impala
option that is only available in debug builds. The test needs to be
skipped when running against release builds.

Change-Id: I3260fdb60b0d95551aae56e01c5318365efc248a
Reviewed-on: http://gerrit.cloudera.org:8080/3545
Reviewed-by: Henry Robinson <he...@cloudera.com>
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Michael Brown <mi...@cloudera.com>
---
M tests/custom_cluster/test_seq_file_filtering.py
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Michael Brown: Verified
  Henry Robinson: Looks good to me, approved
  Dan Hecht: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/3545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3260fdb60b0d95551aae56e01c5318365efc248a
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3811: skip test sequence file filtering race against release builds

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3811: skip test_sequence_file_filtering_race against release builds
......................................................................


Patch Set 1: Code-Review+2

Thanks!

-- 
To view, visit http://gerrit.cloudera.org:8080/3545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3260fdb60b0d95551aae56e01c5318365efc248a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3811: skip test sequence file filtering race against release builds

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.

Change subject: IMPALA-3811: skip test_sequence_file_filtering_race against release builds
......................................................................


Patch Set 1: -Code-Review Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/3545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3260fdb60b0d95551aae56e01c5318365efc248a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3811: skip test sequence file filtering race against release builds

Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3811: skip test_sequence_file_filtering_race against release builds
......................................................................


Patch Set 1: Code-Review+2

Approved by gatekeeper.

-- 
To view, visit http://gerrit.cloudera.org:8080/3545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3260fdb60b0d95551aae56e01c5318365efc248a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3811: skip test sequence file filtering race against release builds

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.

Change subject: IMPALA-3811: skip test_sequence_file_filtering_race against release builds
......................................................................


Patch Set 1: Code-Review+1

http://sandbox.jenkins.cloudera.com/job/impala-private-build-and-test/3576/
http://sandbox.jenkins.cloudera.com/job/impala-private-build-and-test/3577/

-- 
To view, visit http://gerrit.cloudera.org:8080/3545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3260fdb60b0d95551aae56e01c5318365efc248a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3811: skip test sequence file filtering race against release builds

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.

Change subject: IMPALA-3811: skip test_sequence_file_filtering_race against release builds
......................................................................


Patch Set 1:

Thanks to both of you. I'm doing private builds (debug and release) to make sure the test passes and skips correctly in both.

-- 
To view, visit http://gerrit.cloudera.org:8080/3545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3260fdb60b0d95551aae56e01c5318365efc248a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No