You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sgrebnov <gi...@git.apache.org> on 2015/04/15 01:40:20 UTC
[GitHub] cordova-windows pull request: CB-8856 Fix 'Id' attr is invalid whe...
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-windows/pull/66
CB-8856 Fix 'Id' attr is invalid when creating Windows Store submission build
We should NOT change Application/Id in .appxmanifest as it does not make any sense, but could lead to build failures like in this particular case:
https://issues.apache.org/jira/browse/CB-8856
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-8856
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/66.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #66
----
commit 258a21dbf6ac4bd020e304de8544992e5e3cd9f2
Author: sgrebnov <v-...@microsoft.com>
Date: 2015-04-14T22:49:23Z
CB-8856 Fix 'Id' attribute is invalid when creating Windows Store submission build
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8856 Fix 'Id' attr is invalid whe...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/66#issuecomment-94604271
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8856 Fix 'Id' attr is invalid whe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org