You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2022/11/19 00:25:33 UTC
[GitHub] [gobblin] ZihanLi58 opened a new pull request, #3605: [GOBBLIN-1746] Add fs.uri to FsDatasetDescriptor to support copy between volumes in GaaS
ZihanLi58 opened a new pull request, #3605:
URL: https://github.com/apache/gobblin/pull/3605
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1746
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
This is to support copy in same cluster but between different volume. We add the fs.uri in dataset descriptor to make sure it's a scalable way for us to config the file system uri. By default, we use the fs.uri from data node
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Unit test, also test deploy GaaS locally with new datapack
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] ZihanLi58 commented on a diff in pull request #3605: [GOBBLIN-1746] Add fs.uri to FsDatasetDescriptor to support copy between volumes in GaaS
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on code in PR #3605:
URL: https://github.com/apache/gobblin/pull/3605#discussion_r1029941587
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -33,7 +33,6 @@
import org.apache.gobblin.kafka.client.DecodeableKafkaRecord;
import org.apache.gobblin.metrics.ContextAwareMeter;
-import org.apache.gobblin.metrics.event.EventSubmitter;
Review Comment:
Oh I need to run rebase, after force push, this disapper
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -33,7 +33,6 @@
import org.apache.gobblin.kafka.client.DecodeableKafkaRecord;
import org.apache.gobblin.metrics.ContextAwareMeter;
-import org.apache.gobblin.metrics.event.EventSubmitter;
Review Comment:
Oh I need to run rebase, after force push, this disappear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo commented on a diff in pull request #3605: [GOBBLIN-1746] Add fs.uri to FsDatasetDescriptor to support copy between volumes in GaaS
Posted by GitBox <gi...@apache.org>.
Will-Lo commented on code in PR #3605:
URL: https://github.com/apache/gobblin/pull/3605#discussion_r1029910666
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/dataset/FSDatasetDescriptor.java:
##########
@@ -143,6 +143,7 @@ public boolean contains(DatasetDescriptor o) {
FSDatasetDescriptor other = (FSDatasetDescriptor) o;
+
Review Comment:
Nit: Unnecessary whitespace?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -33,7 +33,6 @@
import org.apache.gobblin.kafka.client.DecodeableKafkaRecord;
import org.apache.gobblin.metrics.ContextAwareMeter;
-import org.apache.gobblin.metrics.event.EventSubmitter;
Review Comment:
Is this change related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] ZihanLi58 merged pull request #3605: [GOBBLIN-1746] Add fs.uri to FsDatasetDescriptor to support copy between volumes in GaaS
Posted by GitBox <gi...@apache.org>.
ZihanLi58 merged PR #3605:
URL: https://github.com/apache/gobblin/pull/3605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3605: [GOBBLIN-1746] Add fs.uri to FsDatasetDescriptor to support copy between volumes in GaaS
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3605:
URL: https://github.com/apache/gobblin/pull/3605#issuecomment-1320705937
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3605](https://codecov.io/gh/apache/gobblin/pull/3605?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9054a18) into [master](https://codecov.io/gh/apache/gobblin/commit/47b9bb0024c6005925a6b958c0e0563a35ecb8bb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (47b9bb0) will **decrease** coverage by `3.92%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3605 +/- ##
============================================
- Coverage 47.71% 43.78% -3.93%
+ Complexity 8613 2060 -6553
============================================
Files 1712 408 -1304
Lines 65473 17623 -47850
Branches 7101 2154 -4947
============================================
- Hits 31241 7717 -23524
+ Misses 31521 9047 -22474
+ Partials 2711 859 -1852
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3605?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/service/modules/dataset/FSDatasetDescriptor.java](https://codecov.io/gh/apache/gobblin/pull/3605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9kYXRhc2V0L0ZTRGF0YXNldERlc2NyaXB0b3IuamF2YQ==) | | |
| [...modules/flowgraph/DatasetDescriptorConfigKeys.java](https://codecov.io/gh/apache/gobblin/pull/3605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvRGF0YXNldERlc2NyaXB0b3JDb25maWdLZXlzLmphdmE=) | | |
| [...dules/flowgraph/pathfinder/AbstractPathFinder.java](https://codecov.io/gh/apache/gobblin/pull/3605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvcGF0aGZpbmRlci9BYnN0cmFjdFBhdGhGaW5kZXIuamF2YQ==) | | |
| [...g/apache/gobblin/compliance/DatasetDescriptor.java](https://codecov.io/gh/apache/gobblin/pull/3605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY29tcGxpYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jb21wbGlhbmNlL0RhdGFzZXREZXNjcmlwdG9yLmphdmE=) | | |
| [.../apache/gobblin/binary\_creation/DataTestTools.java](https://codecov.io/gh/apache/gobblin/pull/3605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1iaW5hcnktbWFuYWdlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9iaW5hcnlfY3JlYXRpb24vRGF0YVRlc3RUb29scy5qYXZh) | | |
| [...n/compaction/action/CompactionWatermarkAction.java](https://codecov.io/gh/apache/gobblin/pull/3605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25XYXRlcm1hcmtBY3Rpb24uamF2YQ==) | | |
| [...apache/gobblin/metrics/MultiReporterException.java](https://codecov.io/gh/apache/gobblin/pull/3605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9NdWx0aVJlcG9ydGVyRXhjZXB0aW9uLmphdmE=) | | |
| [.../elasticsearch/writer/ElasticsearchRestWriter.java](https://codecov.io/gh/apache/gobblin/pull/3605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9FbGFzdGljc2VhcmNoUmVzdFdyaXRlci5qYXZh) | | |
| [.../gobblin/service/monitoring/GitConfigListener.java](https://codecov.io/gh/apache/gobblin/pull/3605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9HaXRDb25maWdMaXN0ZW5lci5qYXZh) | | |
| [...in/data/management/policy/SelectNothingPolicy.java](https://codecov.io/gh/apache/gobblin/pull/3605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3BvbGljeS9TZWxlY3ROb3RoaW5nUG9saWN5LmphdmE=) | | |
| ... and [2110 more](https://codecov.io/gh/apache/gobblin/pull/3605/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org