[PR] Move CloudBatchSubmitJobOperator job normalization out of __init__ [airflow]

["yunusakca (via GitHub)" <gi...@apache.org>]

yunusakca opened a new pull request, #71201:
URL: https://github.com/apache/airflow/pull/71201

   Moves `CloudBatchSubmitJobOperator`'s `Job` protobuf → dict normalization out of
   `__init__`, as part of the exemption-list burn-down tracked in #70296.
   
   Template fields are rendered after the constructor runs, so reading a template
   field's value inside `__init__` operates on the un-rendered Jinja expression
   rather than the real value. The `job` protobuf-to-dict conversion — added for
   #37217 so the renderer can descend into nested fields such as a runnable's
   container commands — is exactly that pattern.
   
   The conversion has to run *before* Jinja rendering, not after: moving it to
   `execute()` would silently stop nested Jinja expressions inside a `Job`
   protobuf from ever being rendered. It now lives in `prepare_template()`, the
   hook Airflow runs after construction but before rendering, matching the pattern
   `CloudBuildCreateBuildOperator` already uses in this provider.
   
   `CloudBatchSubmitJobOperator`'s entry is removed from
   `validate_operators_init_exemptions.txt`.
   
   The existing rendering test already covers both a `dict` and a protobuf `Job`
   input; a new test asserts the normalization happens in `prepare_template()`
   rather than the constructor.
   
   related: #70296
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Sonnet 5 and Opus 5)
   
   Generated-by: Claude Code (Sonnet 5 and Opus 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move CloudBatchSubmitJobOperator job normalization out of __init__ [airflow]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk closed pull request #71201: Move CloudBatchSubmitJobOperator job normalization out of __init__
URL: https://github.com/apache/airflow/pull/71201


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move CloudBatchSubmitJobOperator job normalization out of __init__ [airflow]

["boring-cyborg[bot] (via GitHub)" <gi...@apache.org>]

boring-cyborg[bot] commented on PR #71201:
URL: https://github.com/apache/airflow/pull/71201#issuecomment-5196437488

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
   - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move CloudBatchSubmitJobOperator job normalization out of __init__ [airflow]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on PR #71201:
URL: https://github.com/apache/airflow/pull/71201#issuecomment-5333180438

   Better fix in #70835 - already merged. Closing as duplicate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org