[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38205: [SPARK-40747][CORE] Support setting driver log url using env vars on other resource managers

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #38205:
URL: https://github.com/apache/spark/pull/38205#discussion_r993040890


##########
core/src/main/scala/org/apache/spark/scheduler/SchedulerBackend.scala:
##########
@@ -73,7 +75,12 @@ private[spark] trait SchedulerBackend {
    * Executors tab for the driver.
    * @return Map containing the log names and their respective URLs
    */
-  def getDriverLogUrls: Option[Map[String, String]] = None
+  def getDriverLogUrls: Option[Map[String, String]] = {

Review Comment:
   Shall we explicitly mention the target resource managers instead of `Support setting driver log url using env vars on other resource managers` because `YarnClusterSchedulerBackend` will not use this implementation?
   
   https://github.com/apache/spark/blob/b9998cf1bf3501936bdf7c0d2a8cc3ddf0115a06/resource-managers/yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClusterSchedulerBackend.scala#L38-L40



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org