You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2014/10/02 19:18:38 UTC

[jira] [Commented] (THRIFT-1847) TSSLSocket.cpp and TFileTransport.cpp incorrectly excluded from Visual Studio project file

    [ https://issues.apache.org/jira/browse/THRIFT-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156789#comment-14156789 ] 

Hudson commented on THRIFT-1847:
--------------------------------

SUCCESS: Integrated in Thrift #1287 (See [https://builds.apache.org/job/Thrift/1287/])
THRIFT-1847 TSSLSocket.cpp and TFileTransport.cpp incorrectly excluded from Visual Studio project file (jensg: rev 656a2fbdaedf5b25bbb7ba2c08d0cd8c0592f917)
* lib/cpp/libthrift.vcxproj


> TSSLSocket.cpp and TFileTransport.cpp incorrectly excluded from Visual Studio project file
> ------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1847
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1847
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9
>         Environment: MSVC 2010 (Windows 7) and MSVC 2012 (Windows 8)
>            Reporter: Chris Stylianou
>            Assignee: Jens Geyer
>            Priority: Minor
>              Labels: cpp, msvc
>             Fix For: 0.9.2
>
>         Attachments: thrift-msvc.patch
>
>
> Both TSSLSocket.cpp and TFileTransport.cpp are incorrectly excluded from Visual Studio project file, so they are not built. I've attached a patch to include them again.
> TSSLSocket.cpp also has an issue due to the use of 'snprintf' which is a C99 feature that isn't provided by MSVC compilers. I've also included a fix for this in the attached patch which uses '_snprintf_s' for MSVC instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)