[GitHub] [airflow] potiuk commented on pull request #30025: Git clean should work if root owned files are in the working tree

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on PR #30025:
URL: https://github.com/apache/airflow/pull/30025#issuecomment-1464209733

   We should not have sudo on MacOS -  it's not necessary and will require you to provide the password (unles you - insecurely  - set your sudo to be passwordless) which is a bit annoying.
   
   Also maybe we should simply use the existing "fix_ownership" methods we already use in `breeze ci fix-ownership` command and run it before git-clean (and add simillar `--use-sudo` flag)? https://github.com/apache/airflow/blob/b9c231ceb0f3053a27744b80e95f08ac0684fe38/dev/breeze/src/airflow_breeze/commands/ci_commands.py#L151 
   
   The nice thing with that solution is that it uses docker to fix the ownership, which does not require you to provide the password for sudo.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org