[GitHub] [solr] epugh commented on a diff in pull request #1213: SOLR-16574: Demonstrate Dense Vectors and KNN as part of the Films example

[GitBox <gi...@apache.org>]

epugh commented on code in PR #1213:
URL: https://github.com/apache/solr/pull/1213#discussion_r1044891360


##########
solr/example/films/vectors/create_dataset.py:
##########
@@ -0,0 +1,48 @@
+from sentence_transformers import SentenceTransformer, util
+import torch
+
+from films import *
+
+#### Load the 10-dimensions model
+model = SentenceTransformer(FILEPATH_FILMS_MODEL)

Review Comment:
   > Gradlew returned and error:
   > 
   > ```
   > Execution failed for task ':solr:example:rat'.
   > > Detected license header issues (skip with -Pvalidation.rat.failOnError=false):
   >   Unknown license: /home/runner/work/solr/solr/solr/example/films/vectors/films.py
   >   Unknown license: /home/runner/work/solr/solr/solr/example/films/vectors/create_dataset.py
   >   Unknown license: /home/runner/work/solr/solr/solr/example/films/vectors/create_model.py
   > ```
   > 
   > Not sure how to proceed.
   
   I think you need to just add teh ASL license text at the top...   look at some of the scripts in `dev-tools/scripts` for examples...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org