You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/05/09 21:02:33 UTC
[GitHub] [netbeans] sdedic commented on a change in pull request #1242:
[NETBEANS-2509] Bring back docker plugin support for unix sockets
sdedic commented on a change in pull request #1242: [NETBEANS-2509] Bring back docker plugin support for unix sockets
URL: https://github.com/apache/netbeans/pull/1242#discussion_r282664381
##########
File path: ide/docker.api/src/org/netbeans/modules/docker/api/DockerSupport.java
##########
@@ -129,12 +128,11 @@ public void removeChangeListener(ChangeListener listener) {
}
public boolean isSocketSupported() {
- return false;
-// if (BaseUtilities.getOperatingSystem() != BaseUtilities.OS_LINUX) {
-// return false;
-// }
-// String arch = System.getProperty("os.arch"); // NOI18N
-// return arch != null && (arch.contains("x86") || arch.contains("amd64")); // NOI18N
+ if (BaseUtilities.getOperatingSystem() != BaseUtilities.OS_LINUX) {
Review comment:
What about MacOS X ? `junixsocket`'s documenation says it supports mac too...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists