You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2020/07/13 06:43:31 UTC
[GitHub] [incubator-tuweni] atoulme opened a new pull request #128: Add roundtrip rlp tests for all eth messages
atoulme opened a new pull request #128:
URL: https://github.com/apache/incubator-tuweni/pull/128
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/apache/incubator-tuweni/blob/master/CONTRIBUTING.md -->
## PR description
Add roundtrip rlp tests for all eth messages
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #128: Add roundtrip rlp tests for all eth messages
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #128:
URL: https://github.com/apache/incubator-tuweni/pull/128#issuecomment-657612562
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/128?src=pr&el=h1) Report
> Merging [#128](https://codecov.io/gh/apache/incubator-tuweni/pull/128?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/377028f6db44ff7c9c030312a3e4a29d1c8012ac&el=desc) will **increase** coverage by `6.77%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/128?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #128 +/- ##
============================================
+ Coverage 58.80% 65.58% +6.77%
- Complexity 754 4177 +3423
============================================
Files 162 399 +237
Lines 5981 19512 +13531
Branches 589 2419 +1830
============================================
+ Hits 3517 12796 +9279
- Misses 2119 5332 +3213
- Partials 345 1384 +1039
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #integration | `58.70% <ø> (-0.11%)` | `749.00 <ø> (-5.00)` | |
| #unit | `57.97% <ø> (?)` | `3788.00 <ø> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/128?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/tuweni/devp2p/v5/internal/DefaultUdpConnector.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvaW50ZXJuYWwvRGVmYXVsdFVkcENvbm5lY3Rvci5rdA==) | `81.35% <0.00%> (-0.85%)` | `30.00% <0.00%> (ø%)` | |
| [...e/tuweni/scuttlebutt/Ed25519PublicKeyIdentity.java](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9zY3V0dGxlYnV0dC9FZDI1NTE5UHVibGljS2V5SWRlbnRpdHkuamF2YQ==) | `58.82% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...otlin/org/apache/tuweni/les/BlockHeadersMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-bGVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9sZXMvQmxvY2tIZWFkZXJzTWVzc2FnZS5rdA==) | `100.00% <0.00%> (ø)` | `5.00% <0.00%> (?%)` | |
| [...n/java/org/apache/tuweni/progpow/KISS99Random.java](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-cHJvZ3Bvdy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3Byb2dwb3cvS0lTUzk5UmFuZG9tLmphdmE=) | `100.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...ava/org/apache/tuweni/eth/genesis/GenesisFile.java](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-ZXRoL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvZXRoL2dlbmVzaXMvR2VuZXNpc0ZpbGUuamF2YQ==) | `86.44% <0.00%> (ø)` | `29.00% <0.00%> (?%)` | |
| [...ain/java/org/apache/tuweni/rlp/BytesRLPReader.java](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-cmxwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvcmxwL0J5dGVzUkxQUmVhZGVyLmphdmE=) | `55.00% <0.00%> (ø)` | `28.00% <0.00%> (?%)` | |
| [...a/org/apache/tuweni/config/EmptyConfiguration.java](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-Y29uZmlnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY29uZmlnL0VtcHR5Q29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ache/tuweni/bytes/MutableArrayWrappingBytes48.java](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9NdXRhYmxlQXJyYXlXcmFwcGluZ0J5dGVzNDguamF2YQ==) | `66.66% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...rc/main/java/org/apache/tuweni/toml/TomlTable.java](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-dG9tbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3RvbWwvVG9tbFRhYmxlLmphdmE=) | `26.47% <0.00%> (ø)` | `31.00% <0.00%> (?%)` | |
| [...crypto/sodium/DefaultDetachedEncryptionResult.java](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL3NvZGl1bS9EZWZhdWx0RGV0YWNoZWRFbmNyeXB0aW9uUmVzdWx0LmphdmE=) | `100.00% <0.00%> (ø)` | `5.00% <0.00%> (?%)` | |
| ... and [285 more](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/128?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/128?src=pr&el=footer). Last update [021a33b...5586ec4](https://codecov.io/gh/apache/incubator-tuweni/pull/128?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme merged pull request #128: Add roundtrip rlp tests for all eth messages
Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #128:
URL: https://github.com/apache/incubator-tuweni/pull/128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #128: Add roundtrip rlp tests for all eth messages
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #128:
URL: https://github.com/apache/incubator-tuweni/pull/128#issuecomment-657612562
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/128?src=pr&el=h1) Report
> Merging [#128](https://codecov.io/gh/apache/incubator-tuweni/pull/128?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/377028f6db44ff7c9c030312a3e4a29d1c8012ac&el=desc) will **decrease** coverage by `0.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/128?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #128 +/- ##
============================================
- Coverage 58.80% 57.97% -0.83%
- Complexity 754 3788 +3034
============================================
Files 162 374 +212
Lines 5981 19133 +13152
Branches 589 2414 +1825
============================================
+ Hits 3517 11093 +7576
- Misses 2119 6809 +4690
- Partials 345 1231 +886
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #integration | `?` | `?` | |
| #unit | `57.97% <ø> (?)` | `3788.00 <ø> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/128?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kotlin/org/apache/tuweni/devp2p/v5/UdpConnector.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvVWRwQ29ubmVjdG9yLmt0) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rg/apache/tuweni/devp2p/v5/misc/TrackingMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvbWlzYy9UcmFja2luZ01lc3NhZ2Uua3Q=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...i/devp2p/v5/internal/handler/PingMessageHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvaW50ZXJuYWwvaGFuZGxlci9QaW5nTWVzc2FnZUhhbmRsZXIua3Q=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../devp2p/v5/internal/handler/NodesMessageHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvaW50ZXJuYWwvaGFuZGxlci9Ob2Rlc01lc3NhZ2VIYW5kbGVyLmt0) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [360 more](https://codecov.io/gh/apache/incubator-tuweni/pull/128/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/128?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/128?src=pr&el=footer). Last update [021a33b...5586ec4](https://codecov.io/gh/apache/incubator-tuweni/pull/128?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org