You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by Graham Charters <gc...@googlemail.com> on 2010/03/04 16:56:09 UTC
Maven bundle plugin version conversion
Hi, I'm writing a maven plugin that needs to do coversion of maven
versions to osgi versions. I want to depend on the
maven-bundle-plugin for this because I need the conversion scheme to
be identical. I've done this and started using the
DefaultMaven2OsgiConverter, but for some reason, the versions I get
are different from those generated by the maven-bundle-plugin. For
example, the converter changes 1.0.0-incubating-SNAPSHOT to
1.0.0.incubating_SNAPSHOT (as well as making it a valid OSGi version,
it converts the '-' to '_'), whereas the maven-bundle-plugin changes
this to 1.0.0.incubating-SNAPSHOT (leaves '-' alone). Am I using the
wrong bit of code to do the conversion or driving it incorrectly? Any
help would be greatly appreciated.
My apologies if this should be on the users list rather than dev. It
seems to fall between the two...
Many thanks,
Graham.
Re: Maven bundle plugin version conversion
Posted by Graham Charters <gc...@googlemail.com>.
Thanks, Guillaume. That explains a lot, and yes, I think aligning is good.
Regards, Graham.
On 5 March 2010 12:48, Guillaume Nodet <gn...@gmail.com> wrote:
> I think the answer is that the job is not actually done by the
> DefaultMaven2OsgiConverter.
> It's done by BND in
> http://bnd.cvs.sourceforge.net/viewvc/bnd/aQute.bnd/src/aQute/lib/osgi/Analyzer.java?revision=1.24&view=markup
> The method is named cleanupVersion()
> I think it would make sense to align.
> In karaf we also need to OSGi version at build time for maven resource
> filtering, so we should somehow add it as a goal too.
>
> On Thu, Mar 4, 2010 at 18:06, Graham Charters <gc...@googlemail.com> wrote:
>> This bug seems to describe my poblem:
>> https://jira.codehaus.org/browse/MECLIPSE-467
>>
>> What I don't understand is why DefaultMaven2OsgiConverter gives
>> results different from the maven-bundle-plugin.
>>
>> Any help in understanding this and how to resolve it would be greatly
>> appreciated.
>>
>> Thanks, Graham.
>>
>> On 4 March 2010 15:56, Graham Charters <gc...@googlemail.com> wrote:
>>> Hi, I'm writing a maven plugin that needs to do coversion of maven
>>> versions to osgi versions. I want to depend on the
>>> maven-bundle-plugin for this because I need the conversion scheme to
>>> be identical. I've done this and started using the
>>> DefaultMaven2OsgiConverter, but for some reason, the versions I get
>>> are different from those generated by the maven-bundle-plugin. For
>>> example, the converter changes 1.0.0-incubating-SNAPSHOT to
>>> 1.0.0.incubating_SNAPSHOT (as well as making it a valid OSGi version,
>>> it converts the '-' to '_'), whereas the maven-bundle-plugin changes
>>> this to 1.0.0.incubating-SNAPSHOT (leaves '-' alone). Am I using the
>>> wrong bit of code to do the conversion or driving it incorrectly? Any
>>> help would be greatly appreciated.
>>>
>>> My apologies if this should be on the users list rather than dev. It
>>> seems to fall between the two...
>>>
>>> Many thanks,
>>>
>>> Graham.
>>>
>>
>
>
>
> --
> Cheers,
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> Open Source SOA
> http://fusesource.com
>
Re: Maven bundle plugin version conversion
Posted by Guillaume Nodet <gn...@gmail.com>.
I think the answer is that the job is not actually done by the
DefaultMaven2OsgiConverter.
It's done by BND in
http://bnd.cvs.sourceforge.net/viewvc/bnd/aQute.bnd/src/aQute/lib/osgi/Analyzer.java?revision=1.24&view=markup
The method is named cleanupVersion()
I think it would make sense to align.
In karaf we also need to OSGi version at build time for maven resource
filtering, so we should somehow add it as a goal too.
On Thu, Mar 4, 2010 at 18:06, Graham Charters <gc...@googlemail.com> wrote:
> This bug seems to describe my poblem:
> https://jira.codehaus.org/browse/MECLIPSE-467
>
> What I don't understand is why DefaultMaven2OsgiConverter gives
> results different from the maven-bundle-plugin.
>
> Any help in understanding this and how to resolve it would be greatly
> appreciated.
>
> Thanks, Graham.
>
> On 4 March 2010 15:56, Graham Charters <gc...@googlemail.com> wrote:
>> Hi, I'm writing a maven plugin that needs to do coversion of maven
>> versions to osgi versions. I want to depend on the
>> maven-bundle-plugin for this because I need the conversion scheme to
>> be identical. I've done this and started using the
>> DefaultMaven2OsgiConverter, but for some reason, the versions I get
>> are different from those generated by the maven-bundle-plugin. For
>> example, the converter changes 1.0.0-incubating-SNAPSHOT to
>> 1.0.0.incubating_SNAPSHOT (as well as making it a valid OSGi version,
>> it converts the '-' to '_'), whereas the maven-bundle-plugin changes
>> this to 1.0.0.incubating-SNAPSHOT (leaves '-' alone). Am I using the
>> wrong bit of code to do the conversion or driving it incorrectly? Any
>> help would be greatly appreciated.
>>
>> My apologies if this should be on the users list rather than dev. It
>> seems to fall between the two...
>>
>> Many thanks,
>>
>> Graham.
>>
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
Re: Maven bundle plugin version conversion
Posted by Graham Charters <gc...@googlemail.com>.
This bug seems to describe my poblem:
https://jira.codehaus.org/browse/MECLIPSE-467
What I don't understand is why DefaultMaven2OsgiConverter gives
results different from the maven-bundle-plugin.
Any help in understanding this and how to resolve it would be greatly
appreciated.
Thanks, Graham.
On 4 March 2010 15:56, Graham Charters <gc...@googlemail.com> wrote:
> Hi, I'm writing a maven plugin that needs to do coversion of maven
> versions to osgi versions. I want to depend on the
> maven-bundle-plugin for this because I need the conversion scheme to
> be identical. I've done this and started using the
> DefaultMaven2OsgiConverter, but for some reason, the versions I get
> are different from those generated by the maven-bundle-plugin. For
> example, the converter changes 1.0.0-incubating-SNAPSHOT to
> 1.0.0.incubating_SNAPSHOT (as well as making it a valid OSGi version,
> it converts the '-' to '_'), whereas the maven-bundle-plugin changes
> this to 1.0.0.incubating-SNAPSHOT (leaves '-' alone). Am I using the
> wrong bit of code to do the conversion or driving it incorrectly? Any
> help would be greatly appreciated.
>
> My apologies if this should be on the users list rather than dev. It
> seems to fall between the two...
>
> Many thanks,
>
> Graham.
>