You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/21 12:53:19 UTC
[GitHub] [maven-compiler-plugin] pzygielo opened a new pull request, #153: [MCOMPILER-457] Warn about warn-config conflicting values
pzygielo opened a new pull request, #153:
URL: https://github.com/apache/maven-compiler-plugin/pull/153
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCOMPILER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
Posted by GitBox <gi...@apache.org>.
pzygielo commented on PR #153:
URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1326375665
Is there any change requested here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
Posted by GitBox <gi...@apache.org>.
pzygielo commented on PR #153:
URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1335567397
May I ask for review, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
Posted by GitBox <gi...@apache.org>.
olamy commented on PR #153:
URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1326913635
maybe we should simply change `showWarnings` to `true` per default as described in MCOMPILER-457?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] slawekjaranowski commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #153:
URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1301854894
Does this PR resolve issue?
As I understood setting only `failOnWarning` to `true` has no efect.
Maybe when `failOnWarning` is `true` we also need to change `showWarnings` to `true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] slawekjaranowski merged pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #153:
URL: https://github.com/apache/maven-compiler-plugin/pull/153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
Posted by GitBox <gi...@apache.org>.
pzygielo commented on PR #153:
URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1327514243
> maybe we should simply change `showWarnings` to `true` per default as described in MCOMPILER-457?
- Doing so in apache/maven-compiler-plugin#157
- What about THIS change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
Posted by GitBox <gi...@apache.org>.
pzygielo commented on PR #153:
URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1302396964
I didn't want to change currently implemented logic.
MCOMPILER-457 happened to me as well. Caused some... confusion.
For future me, that does not remember that, it'd be fine to be warned about strange plugin set up.
> Maybe when `failOnWarning` is true we also need to change `showWarnings` to true.
Maybe. I'd like to have the warning at least in such case as well, that parameter is updated out of my control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
Posted by GitBox <gi...@apache.org>.
pzygielo commented on PR #153:
URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1301766219
May I ask for review, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org