You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/25 11:11:39 UTC

[GitHub] [druid] JaeGeunBang opened a new pull request #9562: Remove unnecessary apis

JaeGeunBang opened a new pull request #9562: Remove unnecessary apis
URL: https://github.com/apache/druid/pull/9562
 
 
   ### Description
   
   When building with `mvn clean test`, the following WARNING message is displayed for each project test.
   
   ```
   [INFO] Reading API signatures: /mnt/c/Users/jgb71/git/druid/codestyle/joda-time-forbidden-apis.txt
   [INFO] Reading API signatures: /mnt/c/Users/jgb71/git/druid/codestyle/druid-forbidden-apis.txt
   [WARNING] Method not found while parsing signature: com.google.common.util.concurrent.MoreExecutors#newDirectExecutorService() [signature ignored]
   [WARNING] Method not found while parsing signature: com.google.common.util.concurrent.MoreExecutors#directExecutor() [signature ignored]
   [WARNING] Method not found while parsing signature: java.nio.file.Files#createTempDirectory(java.lang.String prefix,java.nio.file.FileAttribute...) [signature ignored]
   [WARNING] Method not found while parsing signature: org.apache.commons.io.FileUtils#deleteDirectory() [signature ignored]
   [WARNING] Some signatures were ignored because the following classes were not found on classpath:
   [WARNING]   com.amazonaws.annotation.GuardedBy, com.google.common.io.BaseEncoding.base64,... (and 2 more).
   [INFO] Loading classes to check...
   [INFO] Scanning classes for violations...
   ```
   
   Even if the WARNING message is shown, it does not affect the build, but I think it's wrong to see the WARNING message for each project build. Methods that were not found after reading the API signatures were removed. So the warning message was no longer appear.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org