[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3208: [CI][test] test many modules upate

[GitBox <gi...@apache.org>]

EricJoy2048 commented on code in PR #3208:
URL: https://github.com/apache/incubator-seatunnel/pull/3208#discussion_r1007085290


##########
seatunnel-core/pom.xml:
##########
@@ -30,6 +30,17 @@
     <artifactId>seatunnel-core</artifactId>
     <packaging>pom</packaging>
 
+    <modules>
+        <module>seatunnel-core-base</module>
+        <module>seatunnel-core-flink</module>
+        <module>seatunnel-core-spark</module>
+        <module>seatunnel-core-flink-sql</module>
+        <module>seatunnel-core-starter</module>
+        <module>seatunnel-flink-starter</module>
+        <module>seatunnel-spark-starter</module>
+        <module>seatunnel-starter</module>
+    </modules>

Review Comment:
   > Should the engine-all profile be removed? @CalvinKirs CC
   
   Yes, `engine-all` profile is not used now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org