You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Mike Heath (JIRA)" <ji...@apache.org> on 2008/02/29 06:16:52 UTC
[jira] Created: (DIRMINA-538) Rename FileRegion.setPosition() to
something more descriptive of what it is doing
Rename FileRegion.setPosition() to something more descriptive of what it is doing
---------------------------------------------------------------------------------
Key: DIRMINA-538
URL: https://issues.apache.org/jira/browse/DIRMINA-538
Project: MINA
Issue Type: Improvement
Affects Versions: 2.0.0-M1
Reporter: Mike Heath
Fix For: 2.0.0-M2
FileRegion.setPosition() is poorly named because invoking this method updates FileRegion.getPosition(), FileRegion.getCount(), and FileRegion.getWrittenBytes(). I suggest we rename it to update(long) and document what should happen when it's invoked.
Also, FileRegion.getCount() isn't descriptive of what the method is returning. Something like FileRegion.getRemainingBytes() is more descriptive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRMINA-538) Rename FileRegion.setPosition() to
something more descriptive of what it is doing
Posted by "Mike Heath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Heath resolved DIRMINA-538.
--------------------------------
Resolution: Fixed
> Rename FileRegion.setPosition() to something more descriptive of what it is doing
> ---------------------------------------------------------------------------------
>
> Key: DIRMINA-538
> URL: https://issues.apache.org/jira/browse/DIRMINA-538
> Project: MINA
> Issue Type: Improvement
> Affects Versions: 2.0.0-M1
> Reporter: Mike Heath
> Assignee: Mike Heath
> Fix For: 2.0.0-M2
>
>
> FileRegion.setPosition() is poorly named because invoking this method updates FileRegion.getPosition(), FileRegion.getCount(), and FileRegion.getWrittenBytes(). I suggest we rename it to update(long) and document what should happen when it's invoked.
> Also, FileRegion.getCount() isn't descriptive of what the method is returning. Something like FileRegion.getRemainingBytes() is more descriptive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DIRMINA-538) Rename FileRegion.setPosition() to
something more descriptive of what it is doing
Posted by "Mike Heath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Heath reassigned DIRMINA-538:
----------------------------------
Assignee: Mike Heath
> Rename FileRegion.setPosition() to something more descriptive of what it is doing
> ---------------------------------------------------------------------------------
>
> Key: DIRMINA-538
> URL: https://issues.apache.org/jira/browse/DIRMINA-538
> Project: MINA
> Issue Type: Improvement
> Affects Versions: 2.0.0-M1
> Reporter: Mike Heath
> Assignee: Mike Heath
> Fix For: 2.0.0-M2
>
>
> FileRegion.setPosition() is poorly named because invoking this method updates FileRegion.getPosition(), FileRegion.getCount(), and FileRegion.getWrittenBytes(). I suggest we rename it to update(long) and document what should happen when it's invoked.
> Also, FileRegion.getCount() isn't descriptive of what the method is returning. Something like FileRegion.getRemainingBytes() is more descriptive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRMINA-538) Rename FileRegion.setPosition() to
something more descriptive of what it is doing
Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Vermillard closed DIRMINA-538.
-------------------------------------
> Rename FileRegion.setPosition() to something more descriptive of what it is doing
> ---------------------------------------------------------------------------------
>
> Key: DIRMINA-538
> URL: https://issues.apache.org/jira/browse/DIRMINA-538
> Project: MINA
> Issue Type: Improvement
> Affects Versions: 2.0.0-M1
> Reporter: Mike Heath
> Assignee: Mike Heath
> Fix For: 2.0.0-M2
>
>
> FileRegion.setPosition() is poorly named because invoking this method updates FileRegion.getPosition(), FileRegion.getCount(), and FileRegion.getWrittenBytes(). I suggest we rename it to update(long) and document what should happen when it's invoked.
> Also, FileRegion.getCount() isn't descriptive of what the method is returning. Something like FileRegion.getRemainingBytes() is more descriptive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.