You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "casaroli (via GitHub)" <gi...@apache.org> on 2026/08/02 22:23:14 UTC
[PR] arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
casaroli opened a new pull request, #19600:
URL: https://github.com/apache/nuttx/pull/19600
## Summary
ARM PIC uses r10 as the base register, but the tree has never been consistent about it. `arch/arm/src/common/Toolchain.defs` gives `CONFIG_BUILD_PIC` `-mpic-register=r9` at line 594 and `CONFIG_PIC` `-mpic-register=r10` at line 620, and `arm_initialstate.c` sets `REG_R9` from inline assembly under one and `REG_PIC` under the other, with a comment that reads *"Set the PIC base register (probably R10)"*. This settles it on r9 for all of PIC: NXFLAT, ELF PIC and `CONFIG_BUILD_PIC` alike.
r9 is the right register rather than an arbitrary one. It is the AAPCS platform register, the "static base", and it is what GCC itself selects for `-msingle-pic-base` on an EABI target; r10 is the non-EABI default.
It also fixes a configuration that cannot build today. Stack checking adds `-ffixed-r10` in `armv7-m/Toolchain.defs:149` and `armv8-m/Toolchain.defs:168` while `CONFIG_PIC` adds `-mpic-register=r10`, and GCC rejects the pair with *"unable to use 'r10' for PIC register"*. The comment above `REG_PIC` has always said the register "can be R9 if stack checking is enabled", but the definition was unconditionally `REG_R10`, so it would have named the wrong register even if the build had succeeded.
## Why the NXFLAT thunk generator comes with it
Moving the register on its own breaks NXFLAT, silently. Import thunks are generated by `mknxflat`, which had the register baked into its template as `add ip,ip,sl`, so a module compiled `-mpic-register=r9` reaches its data through r9 while its import stubs still add r10, and it branches to a wild address on its first call into the base firmware.
`mknxflat` lives outside this repository, in the buildroot NXFLAT toolchain, so the kernel and the tool could drift with nothing to detect it. The first commit therefore brings it in-tree as `tools/nxflat/`, with libbfd replaced by reading the ELF symbol table directly — libbfd was only ever used to open the file and enumerate symbols, and it is GPL, which we cannot depend on. The thunks are then generated from a single `NXFLAT_PIC_REG` on every build, so the two cannot drift.
That commit changes no output. Against the upstream tool, for both ARM and Thumb-2, with and without `-w`, over modules exercising the plain, weak and non-returning thunk paths, the generated thunk files are byte-identical.
## Modules built before this change
They are refused at load rather than left to crash.
The NXFLAT header cannot carry a version: `h_magic` is written by `ldnxflat`, which is GPL, derived from elf2flt, and stays out of this repository, so it can never be changed in step with the loader. The import table can, because both of its ends are in-tree — `mknxflat` emits it and `nxflat_bindimports()` reads it — and `ldnxflat` passes it through untouched. Every module now imports `__nxflat_abi_v2`, the base firmware defines it, and a module that does not import it is refused with `-ENOEXEC`.
Making the marker a real exported symbol rather than a name the loader special-cases keeps it out of the build system's way: a board's symbol table picks it up exactly as it picks up `printf`, so `mksymtab.sh` and its equivalents need no change. It also diagnoses the reverse direction for free — a module built against a newer ABI than its firmware fails with `Exported symbol "__nxflat_abi_v2" not found`.
## Impact
Most of the churn is boards restating a default. `ARCHPICFLAGS` is a `?=` default so that a board only speaks up when it differs, and twenty-six were assigning the value the default already had; those lines are removed rather than edited. `MKNXFLAT` gets the same treatment: thirteen boards named the same tool, and the only thing that varies is ARM versus Thumb-2, which falls out of `CONFIG_ARM_THUMB`. `LDNXFLAT` gains a default too — it stays an out-of-tree PATH lookup, but naming it centrally fixes boards that never assigned it, where it expanded to nothing and handed make a recipe beginning `-e`, whose leading dash make ate as "ignore errors".
The non-ARM boards carrying `-mpic-register=r10` lose it. It is an ARM-only option, reachable only through `CPICFLAGS`, which is only used to build NXFLAT modules, and no non-ARM board enables NXFLAT; six other RISC-V boards already omitted it.
`mknxflat` is built only when `CONFIG_NXFLAT` is set, following the `CONFIG_BOARD_ETC_ROMFS_PASSWD_ENABLE` precedent in `tools/Unix.mk`.
**Breaking change for NXFLAT users.** A prebuilt NXFLAT module, or one built with an out-of-tree `mknxflat`, will no longer load. It is rejected cleanly with `-ENOEXEC` rather than crashing, and the fix is to rebuild it against this tree. Nothing else is affected: `CONFIG_PIC` without `CONFIG_NXFLAT` needs no action, and configurations with neither are untouched.
## Licensing
`tools/nxflat/mknxflat.c` and the two `.def` templates are BSD-3-Clause, copyright Gregory Nutt and Cadenux LLC, imported from the NuttX buildroot NXFLAT toolchain with their headers intact. The containing repository's `COPYING` is GPL-2.0, but these particular files carry their own BSD-3 grant, name only Nutt and Cadenux as copyright holders, and descend from XFLAT's `ldelflib` rather than from elf2flt. @gregory-nutt for confirmation.
`ldnxflat` is deliberately not imported. It is GPL-2.0-or-later and derives from elf2flt, with roughly ten copyright holders reaching back to 1996 — it cannot be relicensed and cannot live in an Apache repository. NXFLAT continues to need it from the buildroot toolchain, exactly as today.
## Testing
Host: macOS 26.5.1 on arm64, Arm GNU Toolchain 14.2.Rel1, QEMU 11.0.3.
`lm3s6965-ek:qemu-nxflat` under QEMU, configured and built with no overrides. The `nxflat` example runs the errno, hello and struct modules with output identical to the same configuration built from master:
```
* Executing errno -> Hello, World on stdout / stderr, errno is 2
* Executing hello -> Hello, world! It has been said.
* Executing struct -> End-of-Test.. Exit-ing
```
The same firmware, with the modules rebuilt by the old out-of-tree generator, refuses all three:
```
ERROR: exec(errno) failed: 8
ERROR: exec(hello) failed: 8
```
Before the ABI marker that same combination locked up in a HardFault with no console output, which is what the marker is for.
`mps3-an547:picostest`, which is `CONFIG_PIC` without `CONFIG_NXFLAT`, builds clean and does not build the thunk generator.
`tools/checkpatch.sh -f` passes on every changed C file and header.
Not covered: ELF PIC has no runtime coverage here. `mps3-an547:picostest` builds and boots identically to master, but NSH takes no console input in that configuration under QEMU — on master as well — so no module is actually executed. The modules were confirmed statically to use r9 as their PIC base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "casaroli (via GitHub)" <gi...@apache.org>.
casaroli commented on PR #19600:
URL: https://github.com/apache/nuttx/pull/19600#issuecomment-5169914479
Related: https://www.mail-archive.com/dev@nuttx.apache.org/msg14863.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19600:
URL: https://github.com/apache/nuttx/pull/19600#issuecomment-5160650080
<!-- membrowse-pr-comment -->
## <img src="https://membrowse.com/membrowse-logo.svg" height="24" align="top"> MemBrowse Memory Report
### [hifive1-revb](https://membrowse.com/public/apache/nuttx/target/hifive1-revb/compare?head=0cac58772f6e01384e0dd7649bb21295ce910f62&base=4002e6af5f99ec7bf2fb91335f4c325c1ec95d9c)
- **flash**: .text +4 B (+0.0%, 83,412 B / 4,194,304 B, total: 2% used)
*No memory changes detected for:*
- [arduino-mega2560](https://membrowse.com/public/apache/nuttx/target/arduino-mega2560/compare?head=0cac58772f6e01384e0dd7649bb21295ce910f62&base=4002e6af5f99ec7bf2fb91335f4c325c1ec95d9c)
- [esp32-devkitc](https://membrowse.com/public/apache/nuttx/target/esp32-devkitc/compare?head=0cac58772f6e01384e0dd7649bb21295ce910f62&base=4002e6af5f99ec7bf2fb91335f4c325c1ec95d9c)
- [mirtoo](https://membrowse.com/public/apache/nuttx/target/mirtoo/compare?head=0cac58772f6e01384e0dd7649bb21295ce910f62&base=4002e6af5f99ec7bf2fb91335f4c325c1ec95d9c)
- [qemu-armv8a](https://membrowse.com/public/apache/nuttx/target/qemu-armv8a/compare?head=0cac58772f6e01384e0dd7649bb21295ce910f62&base=4002e6af5f99ec7bf2fb91335f4c325c1ec95d9c)
- [qemu-intel64](https://membrowse.com/public/apache/nuttx/target/qemu-intel64/compare?head=0cac58772f6e01384e0dd7649bb21295ce910f62&base=4002e6af5f99ec7bf2fb91335f4c325c1ec95d9c)
- [rx65n-rsk2mb](https://membrowse.com/public/apache/nuttx/target/rx65n-rsk2mb/compare?head=0cac58772f6e01384e0dd7649bb21295ce910f62&base=4002e6af5f99ec7bf2fb91335f4c325c1ec95d9c)
- [s698pm-dkit](https://membrowse.com/public/apache/nuttx/target/s698pm-dkit/compare?head=0cac58772f6e01384e0dd7649bb21295ce910f62&base=4002e6af5f99ec7bf2fb91335f4c325c1ec95d9c)
- [stm32-nucleo-f103rb](https://membrowse.com/public/apache/nuttx/target/stm32-nucleo-f103rb/compare?head=0cac58772f6e01384e0dd7649bb21295ce910f62&base=4002e6af5f99ec7bf2fb91335f4c325c1ec95d9c)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "casaroli (via GitHub)" <gi...@apache.org>.
casaroli commented on PR #19600:
URL: https://github.com/apache/nuttx/pull/19600#issuecomment-5170620453
> I have no issue with the BSD code being converted to pure Apache 2.0 following the ASF headers. Some files were jointly copyrighted with Cadenux LLC which I owned many years ago and I was the only person doing the development. So I am comfortable with all of that. The only concern would be the code that has a some ancient uCLinux influenced logic in it. This is original code but derives from ancient GPL uClinux code in some logical sense (although I am avoiding the word "derived" because of its copyright implications). I think that is only one file (?) If everyone else is comfortable, then I am too. I would wait until people in Europe, especially Alin, have a chance to weigh in, however. Alin did all of the original BSD/GPL to Apache licensing analysis and changes when we first joined the ASF so his opinion carries the greatest weight.
Thanks Greg, and the file you are thinking of is not in this PR.
That is ldnxflat.c: its header says "converted from elf2flt.c" and carries Greg Ungerer's and Phil Blundell's copyrights. It stays out of tree in buildroot, and NuttX keeps calling it as an external tool exactly as today.
What is imported is six files: mknxflat.c, nxflat_thunk.h, thunk_arm.c, thunk_thumb2.c and the two dyncall skeletons. mknxflat.c says "Modified from ldelflib", the code you describe as yours and Cadenux's, and I grepped all six for elf2flt, uClinux, XFLAT and GPL — there is nothing.
I have converted those six to the ASF header in a separate commit, so the change is reviewable on its own and easy to drop or reword. Waiting on Alin before this goes anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #19600:
URL: https://github.com/apache/nuttx/pull/19600#discussion_r3701189067
##########
tools/nxflat/thunk_thumb2.c:
##########
@@ -33,13 +33,21 @@
#include "nxflat_thunk.h"
-/* The format strings are file-scope statics inside the .def, so each
+/* The format strings have file scope inside the .def, so each
* architecture gets its own translation unit and the two sets cannot
- * collide. The .def is byte-for-byte the upstream file.
+ * collide. The .def is the upstream file, less one comment typo.
*/
#include "dyncall_skeleton_thumb2.def"
+/****************************************************************************
+ * Private Functions
+ ****************************************************************************/
+
+/* None: this translation unit exists only to give one architecture's
Review Comment:
move to previous patch
##########
tools/Unix.mk:
##########
@@ -286,6 +286,9 @@ tools/cnvwindeps$(HOSTEXEEXT):
tools/mkpasswd$(HOSTEXEEXT):
$(Q) $(MAKE) -C tools -f Makefile.host mkpasswd$(HOSTEXEEXT)
+tools/mknxflat$(HOSTEXEEXT):
Review Comment:
move to the first patch
##########
boards/hc/m9s12/demo9s12ne64/scripts/Make.defs:
##########
@@ -54,7 +54,7 @@ ARCHCFLAGS = -fno-common
ARCHCXXFLAGS = -fno-common -fno-exceptions -fcheck-new
ARCHWARNINGS = -Wall -Wstrict-prototypes -Wshadow -Wundef
ARCHWARNINGSXX = -Wall -Wshadow -Wundef
-ARCHPICFLAGS = -fpic -msingle-pic-base -mpic-register=r10
+ARCHPICFLAGS = -fpic -msingle-pic-base
Review Comment:
remove ALL ARCHPICFLAGS under boards folder and move to arch's Toolchain.defs
##########
binfmt/libnxflat/libnxflat_bind.c:
##########
@@ -60,6 +61,22 @@
# define nxflat_dumpbuffer(m,b,n)
#endif
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+/* The module ABI marker. Every module built by tools/nxflat/mknxflat
+ * imports this, and a board's exported symbol table picks it up the same
+ * way it picks up any other imported name, so nothing has to special-case
+ * it in the build. Its value is never used; only its presence matters.
+ *
+ * A module built against a newer ABI than the firmware therefore fails
+ * with "Exported symbol __nxflat_abi_vN not found", which names the
+ * problem, and a module built against an older one is caught below.
+ */
+
+void *NXFLAT_ABI_MARKER;
Review Comment:
why need
##########
boards/arm/tiva/eagle100/scripts/Make.defs:
##########
@@ -31,7 +31,6 @@ CXXFLAGS := $(ARCHCXXFLAGS) $(ARCHOPTIMIZATION) $(ARCHCPUFLAGS) $(ARCHXXINCLUDES
CPPFLAGS := $(ARCHINCLUDES) $(ARCHDEFINES) $(EXTRAFLAGS)
AFLAGS := $(CFLAGS) -D__ASSEMBLY__
-MKNXFLAT = mknxflat
LDNXFLAT = ldnxflat
Review Comment:
remove too in ALL places
##########
boards/arm/cxd56xx/spresense/scripts/Make.defs:
##########
@@ -35,7 +35,6 @@ endif
ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)
-MKNXFLAT = mknxflat
LDNXFLAT = ldnxflat
Review Comment:
remove too
##########
boards/arm/am67/t3-gem-o1/scripts/Make.defs:
##########
@@ -27,7 +27,7 @@ include $(TOPDIR)/arch/arm/src/armv7-r/Toolchain.defs
LDSCRIPT = sdram.ld
ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)
-ARCHPICFLAGS = -fpic -msingle-pic-base -mpic-register=r10 -ffixed-r10
+ARCHPICFLAGS = -fpic -msingle-pic-base -mpic-register=r9 -ffixed-r9
Review Comment:
remove, use arch's definition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] !arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #19600:
URL: https://github.com/apache/nuttx/pull/19600#issuecomment-5179354206
@jerpelea PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "casaroli (via GitHub)" <gi...@apache.org>.
casaroli commented on PR #19600:
URL: https://github.com/apache/nuttx/pull/19600#issuecomment-5164283980
@patacongo — a licensing question, since you are the copyright holder.
This PR imports mknxflat into the tree as tools/nxflat/. The reason is in the PR body: moving the ARM PIC base register to r9 breaks NXFLAT silently, because mknxflat bakes the register into the import thunks it generates as add ip,ip,sl, and while the tool lives outside this repository it can drift out of step with the kernel.
The three files taken are mknxflat.c and arm/dyncall_skeleton.def / thumb2/dyncall_skeleton.def from the buildroot NXFLAT toolchain. Each carries a BSD-3-Clause header naming you and Cadenux LLC, and notes that the code derives from XFLAT's ldelflib. The containing repository's COPYING is GPL-2.0, so I would like that confirmed rather than assumed: is the per-file BSD-3 grant the operative licence for those three files, and are you content for them to be imported here with their headers intact?
ldnxflat is deliberately not imported. It carries an explicit GPL-2.0-or-later notice and descends from elf2flt, with roughly ten copyright holders going back to 1996, so it stays where it is and NXFLAT continues to need it from buildroot.
The only substantive change to the imported code is dropping the libbfd dependency, which was used solely to open the file and enumerate symbols; the tool now reads the ELF symbol table directly. The generated thunk files are byte-identical to what the current tool produces, for both ARM and Thumb-2, with and without -w.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "patacongo (via GitHub)" <gi...@apache.org>.
patacongo commented on PR #19600:
URL: https://github.com/apache/nuttx/pull/19600#issuecomment-5170247335
I have no issue with the BSD code being converted to pure Apache 2.0 following the ASF headers. Some files were jointly copyrighted with Cadenux LLC which I owned many years ago and I was the only person doing the development. So I am comfortable with all of that.
The only concern would be the code that has a some ancient uCLinux influenced logic in it. This is original code but derives from ancient GPL uClinux code in some logical sense (although I am avoiding the word "derived" because of its copyright implications). I think that is only one file (?)
If everyone else is comfortable, then I am too. I would wait until people in Europe, especially Alin, have a chance to weigh in, however. Alin did all of the original BSD/GPL to Apache licensing analysis and changes when we first joined the ASF so his opinion carries the greatest weight.
________________________________
From: CeDeROM ***@***.***>
Sent: Monday, August 3, 2026 11:12 AM
To: apache/nuttx ***@***.***>
Cc: patacongo ***@***.***>; Mention ***@***.***>
Subject: Re: [apache/nuttx] arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree (PR #19600)
@cederom requested changes on this pull request.
Thank you @casaroli<https://github.com/casaroli> lets just wait for Gregory Nutt states agreement on the mailing list to relicense files from BSD to Apache so we can already merge Apache :-)
—
Reply to this email directly, view it on GitHub<https://github.com/apache/nuttx/pull/19600?email_source=notifications&email_token=ABFUG6W5TEHGI4E3YHBABTD5IDIXBA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBUG4ZDOMJZHE2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#pullrequestreview-4847271994>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABFUG6X4HD26HE42SA2WVW35IDIXBAVCNFSNUABFKJSXA33TNF2G64TZHMZDEOBRGAZTENZTHNEXG43VMU5TKMBUGQ3TKNJYGE22C5QC>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/ABFUG6RR5PATD5EWRTV6ZW35IDIXBA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBUG4ZDOMJZHE2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android<https://github.com/notifications/mobile/android/ABFUG6WEZGOHULTOHFQ43BD5IDIXBA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBUG4ZDOMJZHE2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today!
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] !arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #19600:
URL: https://github.com/apache/nuttx/pull/19600#issuecomment-5178675107
@casaroli please fix the documentation ci error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] !arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "cederom (via GitHub)" <gi...@apache.org>.
cederom commented on PR #19600:
URL: https://github.com/apache/nuttx/pull/19600#issuecomment-5183948172
Amazing piece of work @casaroli =)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "patacongo (via GitHub)" <gi...@apache.org>.
patacongo commented on PR #19600:
URL: https://github.com/apache/nuttx/pull/19600#issuecomment-5170477289
Cadenus License
Some of the code lists Cadenux LLC as the copyright holder. Cadenux was Linux engineering services company that existed from around 2002-2004. I and a partner were the owners of Cadenux LLC. I was the only partner involved with XFLAT. I grant that software which included the Cadenux license to the Apache Software Foundation.
I did not discuss that with my ex-partner but I think I would have his concurrence and, in any event, I think I do have the authority to grant that code to the ASF even without concurrence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] !arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "casaroli (via GitHub)" <gi...@apache.org>.
casaroli closed pull request #19600: !arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree
URL: https://github.com/apache/nuttx/pull/19600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] !arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "casaroli (via GitHub)" <gi...@apache.org>.
casaroli commented on PR #19600:
URL: https://github.com/apache/nuttx/pull/19600#issuecomment-5178963716
> @casaroli please fix the documentation ci error.
The documentation CI error is not related to this PR changes and is happening in any PR that touches documentation.
I will investigate and try to push the fix in another PR anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] !arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #19600:
URL: https://github.com/apache/nuttx/pull/19600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #19600:
URL: https://github.com/apache/nuttx/pull/19600#discussion_r3701189067
##########
tools/nxflat/thunk_thumb2.c:
##########
@@ -33,13 +33,21 @@
#include "nxflat_thunk.h"
-/* The format strings are file-scope statics inside the .def, so each
+/* The format strings have file scope inside the .def, so each
* architecture gets its own translation unit and the two sets cannot
- * collide. The .def is byte-for-byte the upstream file.
+ * collide. The .def is the upstream file, less one comment typo.
*/
#include "dyncall_skeleton_thumb2.def"
+/****************************************************************************
+ * Private Functions
+ ****************************************************************************/
+
+/* None: this translation unit exists only to give one architecture's
Review Comment:
move to previous patch
##########
tools/Unix.mk:
##########
@@ -286,6 +286,9 @@ tools/cnvwindeps$(HOSTEXEEXT):
tools/mkpasswd$(HOSTEXEEXT):
$(Q) $(MAKE) -C tools -f Makefile.host mkpasswd$(HOSTEXEEXT)
+tools/mknxflat$(HOSTEXEEXT):
Review Comment:
move to the first patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "casaroli (via GitHub)" <gi...@apache.org>.
casaroli commented on code in PR #19600:
URL: https://github.com/apache/nuttx/pull/19600#discussion_r3701831833
##########
binfmt/libnxflat/libnxflat_bind.c:
##########
@@ -60,6 +61,22 @@
# define nxflat_dumpbuffer(m,b,n)
#endif
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+/* The module ABI marker. Every module built by tools/nxflat/mknxflat
+ * imports this, and a board's exported symbol table picks it up the same
+ * way it picks up any other imported name, so nothing has to special-case
+ * it in the build. Its value is never used; only its presence matters.
+ *
+ * A module built against a newer ABI than the firmware therefore fails
+ * with "Exported symbol __nxflat_abi_vN not found", which names the
+ * problem, and a module built against an older one is caught below.
+ */
+
+void *NXFLAT_ABI_MARKER;
Review Comment:
This is part of the mechanism within our reach (mknxflat, not in ldnxflat) that we can use to reject old (r10) nxflat modules instead of just loading them and jumping to wrong r9.
Ideally this should be done with the magic, but it requires bringing ldnxflat here (which is GPL and full of licensing problems).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm: Use r9 as the PIC base register, and bring mknxflat in-tree [nuttx]
Posted by "cederom (via GitHub)" <gi...@apache.org>.
cederom commented on PR #19600:
URL: https://github.com/apache/nuttx/pull/19600#issuecomment-5170455649
@jerpelea what do you think?? :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org