You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/01/21 19:12:29 UTC
Review Request 30131: Used persistent volumes consistently in the
code base.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Repository: mesos-git
Description
-------
Used persistent volumes consistently in the code base. (previously, we used persistent disk).
Diffs
-----
include/mesos/resources.hpp 7935e7f9bfe66d1900594dcdcb800c4593a3940f
src/common/resources.cpp 214e441fb86aa0c094c28ed5801089051468137b
src/master/drf_sorter.cpp 967c8aa00606445785836c3e3825a6f467746d33
src/master/master.cpp e9dcca3c92c94f3123519855e238bcef47eeece9
src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be
src/slave/containerizer/isolators/posix/disk.cpp bb1779fd644a33527068868a45cf9c19d7732727
src/tests/resource_offers_tests.cpp d098e7016ac0da7f1d629af099bb1b8fa66da839
src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a
src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489
Diff: https://reviews.apache.org/r/30131/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 30131: Used persistent volumes consistently in the
code base.
Posted by Jie Yu <yu...@gmail.com>.
> On Jan. 23, 2015, 7:16 a.m., Michael Park wrote:
> > include/mesos/resources.hpp, lines 160-161
> > <https://reviews.apache.org/r/30131/diff/1/?file=828568#file828568line160>
> >
> > Rather than taking a template type `F`, we can take a `bool (*predicate)(const Resource&)` or `const lambda::function<bool(const Resource&)> &predicate`. This would allow us to move the definition into the `cpp` file as well. Is there a reason you chose `F` instead?
The reason I choose F is because it would allow us to use inline lambda in the future:
```
resources.filter([] (const Resource& resource) {
return resource.has_disk() && resource.disk().has_persistence();
});
```
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/#review69364
-----------------------------------------------------------
On Jan. 21, 2015, 6:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30131/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 6:12 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Used persistent volumes consistently in the code base. (previously, we used persistent disk).
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 7935e7f9bfe66d1900594dcdcb800c4593a3940f
> src/common/resources.cpp 214e441fb86aa0c094c28ed5801089051468137b
> src/master/drf_sorter.cpp 967c8aa00606445785836c3e3825a6f467746d33
> src/master/master.cpp e9dcca3c92c94f3123519855e238bcef47eeece9
> src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be
> src/slave/containerizer/isolators/posix/disk.cpp bb1779fd644a33527068868a45cf9c19d7732727
> src/tests/resource_offers_tests.cpp d098e7016ac0da7f1d629af099bb1b8fa66da839
> src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a
> src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489
>
> Diff: https://reviews.apache.org/r/30131/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30131: Used persistent volumes consistently in the
code base.
Posted by Michael Park <mc...@gmail.com>.
> On Jan. 23, 2015, 7:16 a.m., Michael Park wrote:
> > include/mesos/resources.hpp, lines 160-161
> > <https://reviews.apache.org/r/30131/diff/1/?file=828568#file828568line160>
> >
> > Rather than taking a template type `F`, we can take a `bool (*predicate)(const Resource&)` or `const lambda::function<bool(const Resource&)> &predicate`. This would allow us to move the definition into the `cpp` file as well. Is there a reason you chose `F` instead?
>
> Jie Yu wrote:
> The reason I choose F is because it would allow us to use inline lambda in the future:
> ```
> resources.filter([] (const Resource& resource) {
> return resource.has_disk() && resource.disk().has_persistence();
> });
> ```
I see. `const lambda::function<bool(const Resource&)> &predicate` will accept that lambda as well.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/#review69364
-----------------------------------------------------------
On Jan. 21, 2015, 6:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30131/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 6:12 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Used persistent volumes consistently in the code base. (previously, we used persistent disk).
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 7935e7f9bfe66d1900594dcdcb800c4593a3940f
> src/common/resources.cpp 214e441fb86aa0c094c28ed5801089051468137b
> src/master/drf_sorter.cpp 967c8aa00606445785836c3e3825a6f467746d33
> src/master/master.cpp e9dcca3c92c94f3123519855e238bcef47eeece9
> src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be
> src/slave/containerizer/isolators/posix/disk.cpp bb1779fd644a33527068868a45cf9c19d7732727
> src/tests/resource_offers_tests.cpp d098e7016ac0da7f1d629af099bb1b8fa66da839
> src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a
> src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489
>
> Diff: https://reviews.apache.org/r/30131/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30131: Used persistent volumes consistently in the
code base.
Posted by Jie Yu <yu...@gmail.com>.
> On Jan. 23, 2015, 7:16 a.m., Michael Park wrote:
> > include/mesos/resources.hpp, lines 174-180
> > <https://reviews.apache.org/r/30131/diff/1/?file=828568#file828568line174>
> >
> > I think the `static bool isPersistentVolume(const Resource&)` function introduced in https://reviews.apache.org/r/29742 is easier to use and will also work seamlessly with the above `filter` function. Could we use that instead?
Doesn't applied anymore.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/#review69364
-----------------------------------------------------------
On Jan. 26, 2015, 6:21 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30131/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2015, 6:21 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Used persistent volumes consistently in the code base. (previously, we used persistent disk).
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 7935e7f9bfe66d1900594dcdcb800c4593a3940f
> src/common/resources.cpp 214e441fb86aa0c094c28ed5801089051468137b
> src/master/drf_sorter.cpp 967c8aa00606445785836c3e3825a6f467746d33
> src/master/master.cpp bda8fda9bc2e52ccc1d75e2541e4604989515e13
> src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be
> src/slave/containerizer/isolators/posix/disk.cpp bb1779fd644a33527068868a45cf9c19d7732727
> src/tests/resource_offers_tests.cpp 4395dd248bd410a2a2887e39a5f9a99d41e2735b
> src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a
> src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489
>
> Diff: https://reviews.apache.org/r/30131/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30131: Used persistent volumes consistently in the
code base.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/#review69364
-----------------------------------------------------------
include/mesos/resources.hpp
<https://reviews.apache.org/r/30131/#comment114051>
Rather than taking a template type `F`, we can take a `bool (*predicate)(const Resource&)` or `const lambda::function<bool(const Resource&)> &predicate`. This would allow us to move the definition into the `cpp` file as well. Is there a reason you chose `F` instead?
include/mesos/resources.hpp
<https://reviews.apache.org/r/30131/#comment114052>
I think the `static bool isPersistentVolume(const Resource&)` function introduced in https://reviews.apache.org/r/29742 is easier to use and will also work seamlessly with the above `filter` function. Could we use that instead?
- Michael Park
On Jan. 21, 2015, 6:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30131/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 6:12 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Used persistent volumes consistently in the code base. (previously, we used persistent disk).
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 7935e7f9bfe66d1900594dcdcb800c4593a3940f
> src/common/resources.cpp 214e441fb86aa0c094c28ed5801089051468137b
> src/master/drf_sorter.cpp 967c8aa00606445785836c3e3825a6f467746d33
> src/master/master.cpp e9dcca3c92c94f3123519855e238bcef47eeece9
> src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be
> src/slave/containerizer/isolators/posix/disk.cpp bb1779fd644a33527068868a45cf9c19d7732727
> src/tests/resource_offers_tests.cpp d098e7016ac0da7f1d629af099bb1b8fa66da839
> src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a
> src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489
>
> Diff: https://reviews.apache.org/r/30131/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30131: Used persistent volumes consistently in the
code base.
Posted by Jie Yu <yu...@gmail.com>.
> On Jan. 22, 2015, 1:12 a.m., Ben Mahler wrote:
> > include/mesos/resources.hpp, lines 159-180
> > <https://reviews.apache.org/r/30131/diff/1/?file=828568#file828568line159>
> >
> > I'm curious why you chose to stray from the existing Filter design in resources.cpp, I like that one because it can live entirely outside the 'Resources' abstraction (doesn't need to be a member function, can be an outside class in this file).
> >
> > This one seems a bit trickier, since you have to deal with some ambiuity around what it means to filter (i.e. if you want to filter x, does that mean you keep x or remove x? To me I think of the latter), unless we rename 'filter' to predicate.
Used the existing Filter design and integrated with RoleFilter.
> On Jan. 22, 2015, 1:12 a.m., Ben Mahler wrote:
> > src/common/resources.cpp, lines 528-550
> > <https://reviews.apache.org/r/30131/diff/1/?file=828569#file828569line528>
> >
> > Can you consolidate this one with what you're adding?
Integrated.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/#review69103
-----------------------------------------------------------
On Jan. 26, 2015, 6:21 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30131/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2015, 6:21 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Used persistent volumes consistently in the code base. (previously, we used persistent disk).
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 7935e7f9bfe66d1900594dcdcb800c4593a3940f
> src/common/resources.cpp 214e441fb86aa0c094c28ed5801089051468137b
> src/master/drf_sorter.cpp 967c8aa00606445785836c3e3825a6f467746d33
> src/master/master.cpp bda8fda9bc2e52ccc1d75e2541e4604989515e13
> src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be
> src/slave/containerizer/isolators/posix/disk.cpp bb1779fd644a33527068868a45cf9c19d7732727
> src/tests/resource_offers_tests.cpp 4395dd248bd410a2a2887e39a5f9a99d41e2735b
> src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a
> src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489
>
> Diff: https://reviews.apache.org/r/30131/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30131: Used persistent volumes consistently in the
code base.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/#review69103
-----------------------------------------------------------
include/mesos/resources.hpp
<https://reviews.apache.org/r/30131/#comment113725>
I'm curious why you chose to stray from the existing Filter design in resources.cpp, I like that one because it can live entirely outside the 'Resources' abstraction (doesn't need to be a member function, can be an outside class in this file).
This one seems a bit trickier, since you have to deal with some ambiuity around what it means to filter (i.e. if you want to filter x, does that mean you keep x or remove x? To me I think of the latter), unless we rename 'filter' to predicate.
src/common/resources.cpp
<https://reviews.apache.org/r/30131/#comment113707>
Can you consolidate this one with what you're adding?
- Ben Mahler
On Jan. 21, 2015, 6:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30131/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 6:12 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Used persistent volumes consistently in the code base. (previously, we used persistent disk).
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 7935e7f9bfe66d1900594dcdcb800c4593a3940f
> src/common/resources.cpp 214e441fb86aa0c094c28ed5801089051468137b
> src/master/drf_sorter.cpp 967c8aa00606445785836c3e3825a6f467746d33
> src/master/master.cpp e9dcca3c92c94f3123519855e238bcef47eeece9
> src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be
> src/slave/containerizer/isolators/posix/disk.cpp bb1779fd644a33527068868a45cf9c19d7732727
> src/tests/resource_offers_tests.cpp d098e7016ac0da7f1d629af099bb1b8fa66da839
> src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a
> src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489
>
> Diff: https://reviews.apache.org/r/30131/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30131: Used persistent volumes consistently in the
code base.
Posted by Jie Yu <yu...@gmail.com>.
> On Jan. 26, 2015, 6:58 p.m., Ben Mahler wrote:
> > include/mesos/resources.hpp, line 247
> > <https://reviews.apache.org/r/30131/diff/2/?file=834317#file834317line247>
> >
> > Do you want this implicit? Looks like you're being explicit in the .cpp code when using this.
made it explicit.
> On Jan. 26, 2015, 6:58 p.m., Ben Mahler wrote:
> > include/mesos/resources.hpp, lines 228-233
> > <https://reviews.apache.org/r/30131/diff/2/?file=834317#file834317line228>
> >
> > It's a bit unusual to define all the child classes in the base class, the general pattern seems to be:
> >
> > ```
> > T
> > FooT
> > BarT
> > ...
> > ```
> >
> > Any reason to stray from that in this case, but not in other cases?
> >
> > Keeping it inside Resources sounds good for now, but it might make it inconsistent for others to add Filters (since this is a public interface), maybe add a TODO to pull it out, possibly inside a resources::filters namespace?
Followed our exiting style: Filter, RoleFilter and PersistentVolumeFilter.
> On Jan. 26, 2015, 6:58 p.m., Ben Mahler wrote:
> > include/mesos/resources.hpp, line 263
> > <https://reviews.apache.org/r/30131/diff/2/?file=834317#file834317line263>
> >
> > Not yours, but should this be an Option?
Fixed.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/#review69646
-----------------------------------------------------------
On Jan. 26, 2015, 6:21 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30131/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2015, 6:21 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Used persistent volumes consistently in the code base. (previously, we used persistent disk).
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 7935e7f9bfe66d1900594dcdcb800c4593a3940f
> src/common/resources.cpp 214e441fb86aa0c094c28ed5801089051468137b
> src/master/drf_sorter.cpp 967c8aa00606445785836c3e3825a6f467746d33
> src/master/master.cpp bda8fda9bc2e52ccc1d75e2541e4604989515e13
> src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be
> src/slave/containerizer/isolators/posix/disk.cpp bb1779fd644a33527068868a45cf9c19d7732727
> src/tests/resource_offers_tests.cpp 4395dd248bd410a2a2887e39a5f9a99d41e2735b
> src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a
> src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489
>
> Diff: https://reviews.apache.org/r/30131/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30131: Used persistent volumes consistently in the
code base.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/#review69646
-----------------------------------------------------------
Ship it!
Modulo the Filter comment, we should consider making that consistent with the rest of our code (T, BarT, FooT, ...), or at the very least add a NOTE as to why we nest all the subclasses.
include/mesos/resources.hpp
<https://reviews.apache.org/r/30131/#comment114389>
It's a bit unusual to define all the child classes in the base class, the general pattern seems to be:
```
T
FooT
BarT
...
```
Any reason to stray from that in this case, but not in other cases?
Keeping it inside Resources sounds good for now, but it might make it inconsistent for others to add Filters (since this is a public interface), maybe add a TODO to pull it out, possibly inside a resources::filters namespace?
include/mesos/resources.hpp
<https://reviews.apache.org/r/30131/#comment114384>
Do you want this implicit? Looks like you're being explicit in the .cpp code when using this.
include/mesos/resources.hpp
<https://reviews.apache.org/r/30131/#comment114386>
Not yours, but should this be an Option?
src/tests/resources_tests.cpp
<https://reviews.apache.org/r/30131/#comment114391>
volume1 and volume2? Like you did below?
- Ben Mahler
On Jan. 26, 2015, 6:21 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30131/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2015, 6:21 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Used persistent volumes consistently in the code base. (previously, we used persistent disk).
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 7935e7f9bfe66d1900594dcdcb800c4593a3940f
> src/common/resources.cpp 214e441fb86aa0c094c28ed5801089051468137b
> src/master/drf_sorter.cpp 967c8aa00606445785836c3e3825a6f467746d33
> src/master/master.cpp bda8fda9bc2e52ccc1d75e2541e4604989515e13
> src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be
> src/slave/containerizer/isolators/posix/disk.cpp bb1779fd644a33527068868a45cf9c19d7732727
> src/tests/resource_offers_tests.cpp 4395dd248bd410a2a2887e39a5f9a99d41e2735b
> src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a
> src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489
>
> Diff: https://reviews.apache.org/r/30131/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30131: Used persistent volumes consistently in the
code base.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/
-----------------------------------------------------------
(Updated Jan. 26, 2015, 6:21 p.m.)
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Changes
-------
Review comments from BenM. Refactor the filter mechanism.
Repository: mesos-git
Description
-------
Used persistent volumes consistently in the code base. (previously, we used persistent disk).
Diffs (updated)
-----
include/mesos/resources.hpp 7935e7f9bfe66d1900594dcdcb800c4593a3940f
src/common/resources.cpp 214e441fb86aa0c094c28ed5801089051468137b
src/master/drf_sorter.cpp 967c8aa00606445785836c3e3825a6f467746d33
src/master/master.cpp bda8fda9bc2e52ccc1d75e2541e4604989515e13
src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be
src/slave/containerizer/isolators/posix/disk.cpp bb1779fd644a33527068868a45cf9c19d7732727
src/tests/resource_offers_tests.cpp 4395dd248bd410a2a2887e39a5f9a99d41e2735b
src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a
src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489
Diff: https://reviews.apache.org/r/30131/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 30131: Used persistent volumes consistently in the
code base.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/#review68987
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29973, 29974, 29975, 29976, 30129, 30130, 30131]
All tests passed.
- Mesos ReviewBot
On Jan. 21, 2015, 6:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30131/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 6:12 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Used persistent volumes consistently in the code base. (previously, we used persistent disk).
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 7935e7f9bfe66d1900594dcdcb800c4593a3940f
> src/common/resources.cpp 214e441fb86aa0c094c28ed5801089051468137b
> src/master/drf_sorter.cpp 967c8aa00606445785836c3e3825a6f467746d33
> src/master/master.cpp e9dcca3c92c94f3123519855e238bcef47eeece9
> src/messages/messages.proto 5bd075e9bfe17be334294b5e4c573eb0233030be
> src/slave/containerizer/isolators/posix/disk.cpp bb1779fd644a33527068868a45cf9c19d7732727
> src/tests/resource_offers_tests.cpp d098e7016ac0da7f1d629af099bb1b8fa66da839
> src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a
> src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489
>
> Diff: https://reviews.apache.org/r/30131/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>