You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/14 20:14:51 UTC

[GitHub] [arrow] wjones127 commented on a diff in pull request #14191: ARROW-17798: [C++][Parquet] Add DELTA_BINARY_PACKED encoder to Parquet writer

wjones127 commented on code in PR #14191:
URL: https://github.com/apache/arrow/pull/14191#discussion_r995972982


##########
cpp/src/arrow/util/bit_stream_utils.h:
##########
@@ -69,6 +69,13 @@ class BitWriter {
   template <typename T>
   bool PutAligned(T v, int num_bytes);
 
+  /// Writes v to given pointer using num_bytes. If T is larger than
+  /// num_bytes, the extra high-order bytes will be ignored. Returns false if
+  /// there was not enough space.
+  /// Assume the v is stored in buffer_ as a litte-endian format

Review Comment:
   `v` is `val`?
   ```suggestion
     /// Writes val to given pointer using num_bytes. If T is larger than
     /// num_bytes, the extra high-order bytes will be ignored. Returns false if
     /// there was not enough space.
     /// Assume the val is stored in buffer_ as a litte-endian format
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org