You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/28 09:04:06 UTC

[GitHub] [spark] zhengruifeng opened a new pull request, #38818: [SPARK-41238][CONNECT][PYTHON] Support `DayTimeIntervalType` in the client

zhengruifeng opened a new pull request, #38818:
URL: https://github.com/apache/spark/pull/38818

   ### What changes were proposed in this pull request?
   Support `DayTimeIntervalType` in the client
   
   
   ### Why are the changes needed?
   In https://github.com/apache/spark/pull/38770, I forgot to deal with `DayTimeIntervalType`
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   added test case, the schema should be 
   ```
   In [1]: query = """ SELECT INTERVAL '100 10:30' DAY TO MINUTE AS interval """
   
   In [2]: spark.sql(query).schema
   Out[2]: StructType([StructField('interval', DayTimeIntervalType(0, 2), False)])
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng closed pull request #38818: [SPARK-41238][CONNECT][PYTHON][FOLLOWUP] Support `DayTimeIntervalType` in the client

Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #38818: [SPARK-41238][CONNECT][PYTHON][FOLLOWUP] Support `DayTimeIntervalType` in the client
URL: https://github.com/apache/spark/pull/38818


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #38818: [SPARK-41238][CONNECT][PYTHON][FOLLOWUP] Support `DayTimeIntervalType` in the client

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38818:
URL: https://github.com/apache/spark/pull/38818#issuecomment-1329966529

   thanks for reivews, merged into master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org