You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "zuobiao-zhou (via GitHub)" <gi...@apache.org> on 2023/09/06 08:24:43 UTC
[GitHub] [pulsar-site] zuobiao-zhou opened a new pull request, #698: SEO for Adaptors
zuobiao-zhou opened a new pull request, #698:
URL: https://github.com/apache/pulsar-site/pull/698
This PR do SEO for Adaptors
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [x] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] zuobiao-zhou commented on pull request #698: SEO for Adaptors
Posted by "zuobiao-zhou (via GitHub)" <gi...@apache.org>.
zuobiao-zhou commented on PR #698:
URL: https://github.com/apache/pulsar-site/pull/698#issuecomment-1707897859
PTAL @Anonymitaet TIA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] cbornet commented on a diff in pull request #698: SEO for Adaptors
Posted by "cbornet (via GitHub)" <gi...@apache.org>.
cbornet commented on code in PR #698:
URL: https://github.com/apache/pulsar-site/pull/698#discussion_r1325522609
##########
docs/adaptors-storm.md:
##########
@@ -10,7 +11,7 @@ An application can inject data into a Storm topology via a generic Pulsar spout,
## Using the Pulsar Storm Adaptor
-Include dependency for Pulsar Storm Adaptor:
+To use the Pulsar Storm Adaptor, you need to include dependency for Pulsar Storm Adaptor:
```xml
<dependency>
Review Comment:
What is "GAV" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] cbornet commented on a diff in pull request #698: SEO for Adaptors
Posted by "cbornet (via GitHub)" <gi...@apache.org>.
cbornet commented on code in PR #698:
URL: https://github.com/apache/pulsar-site/pull/698#discussion_r1326544622
##########
docs/adaptors-storm.md:
##########
@@ -10,7 +11,7 @@ An application can inject data into a Storm topology via a generic Pulsar spout,
## Using the Pulsar Storm Adaptor
-Include dependency for Pulsar Storm Adaptor:
+To use the Pulsar Storm Adaptor, you need to include dependency for Pulsar Storm Adaptor:
```xml
<dependency>
Review Comment:
Oh ok. The storm adapter has moved to the Storm project so we should update the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #698: SEO for Adaptors
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #698:
URL: https://github.com/apache/pulsar-site/pull/698#discussion_r1325544783
##########
docs/adaptors-storm.md:
##########
@@ -10,7 +11,7 @@ An application can inject data into a Storm topology via a generic Pulsar spout,
## Using the Pulsar Storm Adaptor
-Include dependency for Pulsar Storm Adaptor:
+To use the Pulsar Storm Adaptor, you need to include dependency for Pulsar Storm Adaptor:
```xml
<dependency>
Review Comment:
group id, artifact id, version; that is, a unique identifier for a dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #698: SEO for Adaptors
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #698:
URL: https://github.com/apache/pulsar-site/pull/698#discussion_r1320783384
##########
docs/adaptors-storm.md:
##########
@@ -10,7 +11,7 @@ An application can inject data into a Storm topology via a generic Pulsar spout,
## Using the Pulsar Storm Adaptor
-Include dependency for Pulsar Storm Adaptor:
+To use the Pulsar Storm Adaptor, you need to include dependency for Pulsar Storm Adaptor:
```xml
<dependency>
Review Comment:
Out of thread, @cbornet is the GAV of pulsar storm adaptor changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun merged pull request #698: SEO for Adaptors
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #698:
URL: https://github.com/apache/pulsar-site/pull/698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org